RPC Delete intent #563
RPC Delete intent #563
Conversation
|
Let's also add the second way of deleting an intent: if the user forgot the intent id, they can provide a new bip322 proof spending any of the inputs spent by the registered intent to prove the ownership and the right to execute the operation. |
@altafan please review. |
| if err != nil { | ||
| return err | ||
| } | ||
| var idsToDelete []string |
There was a problem hiding this comment.
should be a map to prevent duplicates
| if in.Txid == op.Hash.String() && in.VOut == op.Index { | ||
| idsToDelete = append(idsToDelete, req.Id) | ||
| } |
There was a problem hiding this comment.
the idea is to allow deleting only one intent at a time, not many. So, shall we break once we found the id to delete?
There was a problem hiding this comment.
not sure about this, as user can craft proof with vtxos belonging to diff intents, maybe delete all? @altafan
| @@ -119,6 +125,12 @@ message RegisterIntentResponse { | |||
| string request_id = 1; | |||
| } | |||
|
|
|||
| message DeleteIntentRequest { | |||
| string request_id = 1; | |||
There was a problem hiding this comment.
these should be oneOf. EIther you provide the intentid (which is a user secret) , or you provide an input (a single input is enough) in a bip322. The reasoning is that intent id is trivial and straightforward, but in the case of a wallet recovery where you only have a private key, the bip322 option works.
| requestID := req.GetRequestId() | ||
| bip322Signature := req.GetBip322Signature() | ||
|
|
||
| if requestID != "" { |
There was a problem hiding this comment.
AH i see it's already in the code as I described. Just needs the proto to use the oneof style?
This adds DeleteIntent RPC.
This closes #557
@altafan please review.