[FIX] fix Keyboard shortcuts being activated globally rather than within heroic #2672
Conversation
|
|
||
| // hotkey to open the downloads screen on frontend | ||
| globalShortcut.register('CommandOrControl+J', () => { | ||
| sendFrontendMessage('openScreen', '/download-manager') |
There was a problem hiding this comment.
I wonder if we can add these shortcuts in the frontend shortcuts.ts file https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/main/src/frontend/helpers/shortcuts.ts
that uses event listeners of the frontend so we can listen the combinations without having to deal with the menu or depending on electron features
There was a problem hiding this comment.
we can always call electron functions when needed through window.api to still support the quit/devtools/reload commands
There was a problem hiding this comment.
I made another PR with that idea since it's reusing things removed from this PR #2684
we can keep all the new shortcuts while also making them local without relying on electron accelerators
Unfortunately, we lose the custom shortcuts we created (but we retain the default ones, like reload, dev tools, quit, etc), but at least I don't have heroic stealing focus every time I press control-r
Use the following Checklist if you have changed something on the Backend or Frontend: