New Keyboard Shortcuts Are Global and Overriding Other Programs

[WillPresley]

Describe the bug

After the 2.7.1 update, I noticed that Ctrl-R wasn't working to refresh the tab in Chrome anymore. After peeking in Process Explorer to see what was firing up when I used the keyboard shortcut, I noticed it was Heroic Launcher. This doesn't seem to be intended behavior, as I would expect those shortcuts to only work with the program focused. If it was intended, it would be great to have a toggle for Local/Global or the ability to change/disable them, because I'd much rather not have them as global shortcuts.

Add logs

(14:32:08) INFO:    [Legendary]:        Refreshing library...
(14:32:08) INFO:    [Legendary]:        Refreshing Epic Games...
(14:32:08) INFO:    [Connection]:       Connectivity: check-online
(14:32:08) INFO:    [Connection]:       Pinging external endpoints
(14:32:08) INFO:    [Legendary]:        Running command: C:\Users\XXXXX\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary --version
(14:32:08) INFO:    [Legendary]:        Legendary location: C:\Users\XXXXX\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary
(14:32:08) INFO:    [Gog]:              GOGDL location: C:\Users\XXXXX\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl
(14:32:08) INFO:    [Gog]:              GOGDL location: C:\Users\XXXXX\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl
(14:32:08) INFO:    [Legendary]:        Game list updated, got 263 games & DLCs
(14:32:08) WARNING: [Backend]:          Protocol already registered.
(14:32:08) INFO:    [Connection]:       Connectivity: online
(14:32:08) INFO:    [Gog]:              Checking if login is valid
(14:32:08) INFO:    [Gog]:              Running command: C:\Users\XXXXX\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\XXXXX\AppData\Roaming\heroic\gog_store\auth.json auth
(14:32:08) INFO:    [Legendary]:        Running command: C:\Users\XXXXX\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary list --third-party
(14:32:10) INFO:    [Backend]:          Loading Screen Ready
(14:32:10) INFO:    [Frontend]:         Refreshing Library
(14:32:10) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(14:32:10) INFO:    [Gog]:              Found 0 game(s) to update
(14:32:10) INFO:    [Backend]:          Frontend Ready
(14:32:10) INFO:    [Backend]:          Checking for new Heroic Updates
(14:32:10) INFO:    [Backend]:          Checking for current version changelog
(14:32:10) INFO:    [Legendary]:        Checking for game updates: C:\Users\XXXXX\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary list --third-party
(14:32:11) INFO:    [Gog]:              Saved username to config file
(14:32:11) INFO:    [Gog]:              Running command: C:\Users\XXXXX\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\XXXXX\AppData\Roaming\heroic\gog_store\auth.json --version
(14:32:13) WARNING: [Backend]:          Could not determine System Info
(14:32:13) INFO:    [Legendary]:        Found 0 games to update
(14:32:14) INFO:    [Backend]:          VCRuntime is installed
(14:32:15) INFO:    [Backend]:          Starting the Download Queue

Steps to reproduce

1. Open Heroic Launcher 2.7.1 on Windows 10. Open a browser that uses Ctrl-R for refresh, and focus it.
2. Use the Ctrl-R shortcut, and Heroic Launcher will reload, instead of the browser tab/window.

Expected behavior

Local to the program keyboard shortcuts

Screenshots

No response

Heroic Version

Latest Stable

System Information

• OS: Windows 10 22H2

Additional information

No response

[ShadowBladezx86]

Can confirm this also is happening in Linux.

[Etaash-mathamsetty]

dumb solution: use wayland lol (if on linux)
but actually though, this needs to get fixed

[Etaash-mathamsetty]

fixed with: #2672