Skip to content

[Fix] Handle shortcuts from the frontend without depending on menu #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented May 6, 2023

This PR is an adaptation of the current globalShortcuts feature, instead of using globalShorcuts that are causing issues, it uses an event listener in the frontend and based on the different combinations it sends a message to the backend to be processed

This fixes #2676 and fixes #2671


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team May 6, 2023 03:24
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, way better now. Tested here and it is working just fine!

@flavioislima flavioislima merged commit c82e6ca into main May 6, 2023
@flavioislima flavioislima deleted the local-shortcuts branch May 6, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hotkeys are captured globally on macOS. New Keyboard Shortcuts Are Global and Overriding Other Programs
2 participants