Skip to content

Hotkeys are captured globally on macOS. #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astrochili opened this issue May 4, 2023 · 2 comments · Fixed by #2684
Closed

Hotkeys are captured globally on macOS. #2676

astrochili opened this issue May 4, 2023 · 2 comments · Fixed by #2684
Labels
bug:confirmed Something isn't working.

Comments

@astrochili
Copy link

astrochili commented May 4, 2023

Describe the bug

It looks like these hotkeys are captured globally on macOS.

Being in the Internet browser, for example, Cmd+R or Cmd+Q affect Heroic, but not the browser. It's absolutely not okay.

Steps to reproduce

Press Cmd+Q (or other hotkey) when Heroic's window isn't active.

Expected behavior

Shortcuts works in the current context and nothing happens in Heroic.

Heroic Version

Version 2.7.1 (2.7.1)

System Information

  • macOS Ventura
@astrochili
Copy link
Author

astrochili commented May 4, 2023

A pull request by @Etaash-mathamsetty already exists, but looks like it just disables the new functionality.

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented May 4, 2023

A pull request by @Etaash-mathamsetty already exists, but looks like it just disables the new functionality.

It doesn't, it retains some of the shortcuts while removing some of the heroic specific ones. While it's possible to add them back, let's fix the bug first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed Something isn't working.
Projects
None yet
3 participants