-
-
Notifications
You must be signed in to change notification settings - Fork 480
[UX] Add Keyboard global shortcuts #2659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on linux and it works fine 👍
I have 2 questions but I don't think they are blockers:
- Maybe Ctrl+D can open the Downloads screen?
- I wonder if there's a way to add menu entries for the library, downloads, and settings shortcuts so then users can discover the shortcuts from the menu like you can discover things like quit/reload/devetools
Or maybe an idea for the future to show this information somewhere inside heroic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. To avoid filling up main.ts
again, is it possible to move the shortcuts to another file/folder?
@ariel, yes we need to make them more discoverable and we can expand that in the future. For now I think as a first implementation is fine though. |
This reverts commit 2210f43.
This reverts commit 2210f43.
…cher#2659)"" This reverts commit 55ac7f5.
This pull request adds several hotkeys to improve the user experience of our application. The new hotkeys are as follows:
CommandOrControl+R: Reloads the app
CommandOrControl+Q: Quits the app
CommandOrControl+Shift+I: Opens the dev tools
CommandOrControl+K: Opens the Heroic settings screen on the frontend
CommandOrControl+L: Opens the library screen
CommandOrControl+J: Opens the downloads screen
Use the following Checklist if you have changed something on the Backend or Frontend: