Skip to content

[UX] Add Keyboard global shortcuts #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023
Merged

[UX] Add Keyboard global shortcuts #2659

merged 1 commit into from
May 3, 2023

Conversation

flavioislima
Copy link
Member

This pull request adds several hotkeys to improve the user experience of our application. The new hotkeys are as follows:

CommandOrControl+R: Reloads the app
CommandOrControl+Q: Quits the app
CommandOrControl+Shift+I: Opens the dev tools
CommandOrControl+K: Opens the Heroic settings screen on the frontend
CommandOrControl+L: Opens the library screen
CommandOrControl+J: Opens the downloads screen


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 28, 2023
@flavioislima flavioislima linked an issue Apr 28, 2023 that may be closed by this pull request
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on linux and it works fine 👍

I have 2 questions but I don't think they are blockers:

  • Maybe Ctrl+D can open the Downloads screen?
  • I wonder if there's a way to add menu entries for the library, downloads, and settings shortcuts so then users can discover the shortcuts from the menu like you can discover things like quit/reload/devetools

image

Or maybe an idea for the future to show this information somewhere inside heroic.

Copy link
Collaborator

@Nocccer Nocccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To avoid filling up main.ts again, is it possible to move the shortcuts to another file/folder?

@flavioislima
Copy link
Member Author

@ariel, yes we need to make them more discoverable and we can expand that in the future. For now I think as a first implementation is fine though.

@flavioislima flavioislima merged commit 2210f43 into main May 3, 2023
@flavioislima flavioislima deleted the feat/shortcuts branch May 3, 2023 07:46
Etaash-mathamsetty added a commit to Etaash-mathamsetty/HeroicGamesLauncher that referenced this pull request May 4, 2023
Etaash-mathamsetty added a commit to Etaash-mathamsetty/HeroicGamesLauncher that referenced this pull request May 4, 2023
Etaash-mathamsetty added a commit to Etaash-mathamsetty/HeroicGamesLauncher that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quit on Ctrl+Q
3 participants