Follow up for "Feature: Implement ChangeTransactionsReport"

[luacmartins]

This PR introduced the following issues.

In review

• Feat: Add ability to unreport transactions #61743

Fixed

• [Due for payment 2025-05-27] Expense - Empty message row after moving report in offline mode #60251
• Update IOU action when moving reports #61221 (comment)
• [Due for payment 2025-04-25] Expense - "Moved this expense to" message is duplicated when submitting track expense to WS. #60225
• [Due for payment 2025-04-28] Review duplicates - Confirm button is not functional after moving report on confirmation page #60254
• [Due for payment 2025-04-28] [$250] Expense - Report field is accessible by receiver in p2p expense and it opens blank page #60238
• [Due for payment 2025-04-28] Expense - Report field shows submitted report but the expense is created in a new report #60229
• [Due for payment 2025-04-28] Expense - Report field in paid expense shows that another report is selected #60232
• [Due for payment 2025-04-28] Expense - Expense is created in report from other workspace when a new workspace is selected #60234
• [Due for payment 2025-04-28] Expense - Report page is blank when submitting expense to workspace with no report #60228
• [$250] Travel - "View trip details" button is not below Report field #60299
• [Change Report] Expense - Report name in Report field shows negative amount in offline mode #60247
• IOU-Report field shows owes amount briefly before updating to IOU #60233
• Distance - Distance and Rate fields become "pending" after returning from waypoint editor #60297
• Invoice- Invoice report title is "user owes amount", but Report field shows Invoice YYYY-MM-DD #60274
• Expense - Infinite loading when WS admin tries to change employee´s expense to another report #60295
• Some random name displayed on the confirmation page when creating an expense #60388
• Expense - When changing expense to another report, preview with "0,00" remains on chat. #60252 (unable to reproduce)
• [$250] Reports - After moving an expense the amount is still shown in money request preview #60271 (unable to reproduce)
• Revert changes in this PR [CP Staging] Disable moved actions #60328

[waterim]

Posting my update!

• Expense - "Moved this expense to" message is duplicated when submitting track expense to WS. #60225 - @luacmartins is working on that
• Expense - Report page is blank when submitting expense to workspace with no report #60228
• Expense - Report field shows submitted report but the expense is created in a new report #60229
• Expense - Report field in paid expense shows that another report is selected #60232
• IOU-Report field shows owes amount briefly before updating to IOU #60233 - v2
• Expense - Expense is created in report from other workspace when a new workspace is selected #60234
• Expense - Empty message row after moving report in offline mode #60251
• Expense - When changing expense to another report, preview with "0,00" remains on chat. #60252
• Review duplicates - Confirm button is not functional after moving report on confirmation page #60254
• [$250] Expense - Report field is accessible by receiver in p2p expense and it opens blank page #60238
• [Change Report] Expense - Report name in Report field shows negative amount in offline mode #60247 - v2
• [$250] Reports - After moving an expense the amount is still shown in money request preview #60271
• Invoice- Invoice report title is "user owes amount", but Report field shows Invoice YYYY-MM-DD #60274
• Expense - Infinite loading when WS admin tries to change employee´s expense to another report #60295
• Distance - Distance and Rate fields become "pending" after returning from waypoint editor #60297 - fixed in v1, lets test it additionally in v2
• [$250] Travel - "View trip details" button is not below Report field #60299 - v2
• Some random name displayed on the confirmation page when creating an expense #60388

[luacmartins]

#60229 - correct behaviour???
I think it's correct that the expense is on a new report, but I think we should display the name of the new report the expense will be put in, not the old submitted report in this case

[waterim]

@luacmartins Updated it not to include submitted reports for submission delays on, and include submitted reports when its off
As it looks like more intutive

[luacmartins]

hmm I'm not sure if that's what we want. @JmillsExpensify @trjExpensify could you please check? Should we be able to add a transaction to a submitted report is delayed submission is on?

[trjExpensify]

I'm looking at the steps in the issue and I'm inclined to say no. In the creation flow the expense shouldn't be added to an existing processing report on delayed submit.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Follow-up]: fix issues related to ChangeTransactionsReport #60318

If no regressions arise, payment will be issued on 2025-04-28. 🎊

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)
• @rayane-d requires payment through NewDot Manual Requests

[luacmartins]

@waterim I'm working on #60225

[luacmartins]

Cool, I'll try to pick up one of the remaining ones then

[luacmartins]

Nice. I looked at the other 2 outstanding issues. The first one is already fixed. The 2nd issue will be fixed by my PR #60857. So all issues will be addressed once follow up 3 is in review.

[MrMuzyk]

Hey @luacmartins! Today I got news that @waterim is on sick leave and he will most likely be back on (05.05). Is there anything here that requires immediate attention and should be taken over or can this issue wait for his return?

[luacmartins]

@MrMuzyk thanks for letting me know. Could you please take a look at these issues? #60288 (comment) I think @waterim was already working on a draft PR for them, but it'd be great if we could get a fix merged in the meantime.

[MrMuzyk]

I'll have a look and see if he pushed his changes yesterday. Maybe I can get this through to the end :)

[MrMuzyk]

Unfortunately he didn't push his changes yesterday :( I'll start looking into these issues and maybe I can fix them before Artem comes back. However it's gonna be tough as we have a few days off as Callstack (01.05 and 02.05) due to public holidays so I only have a bit more than 1 working day for that.

[luacmartins]

Thanks @MrMuzyk. We have 3 issues left, hopefully they aren't too time consuming.

[MrMuzyk]

Hey @luacmartins, Ive wrapped up my stuff and managed to find a bit of time to look into this for the rest of the day. Can you provide me a bit more context on reproducing these issues? I'm a bit out of loop when it comes to reproducing this issues.

1. How can I enable Self DMs?
2. Behind which beta flag is this feature available?

[trjExpensify]

How can I enable Self DMs?

• Mhm, in the Report row shouldn't there be a "Remove from report" option which would unreport the expense (and thus create the selfDM if not created already) Carlos?

Anyhow, you can get the selfDM on account creation if you choose the "Track" option in the onboarding modal in the meantime.

Behind which beta flag is this feature available?

• tableReportView beta this has been put behind, I believe.

[MrMuzyk]

I didn't manage to fix any of the issues today :( I'll be back from my leave on 05.05 (due to public holidays as previously mentioned)

[luacmartins]

Mhm, in the Report row shouldn't there be a "Remove from report" option which would unreport the expense (and thus create the selfDM if not created already) Carlos?

Yes, but that hasn't been implemented yet.

I didn't manage to fix any of the issues today :( I'll be back from my leave on 05.05 (due to public holidays as previously mentioned)

Thanks @MrMuzyk. I'll try to work on some of the issues above in the meantime.

[luacmartins]

Ok, I put up a PR to fix the ghost IOU reportAction. I can't reproduce the other two issues, so I also put up a PR to re-enable the feature for non-beta users. That'd close this issue.

[waterim]

Perfect @luacmartins
Im back from a sick leave, if something new will come up Im here to resolve it!

[luacmartins]

@waterim you can start work on Add ability to unreport transactions. Basically this comment

[waterim]

Sure!

[luacmartins]

I'll take a look at #61221 (comment) next. @waterim please focus on Add ability to unreport transactions