Skip to content

[Change Report] Expense - Report name in Report field shows negative amount in offline mode #60247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 of 8 tasks
mitarachim opened this issue Apr 15, 2025 · 17 comments
Closed
6 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Apr 15, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.28-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go offline.
  3. Create a new workspace.
  4. Go to workspace chat.
  5. Submit an expense.
  6. Go to transaction thread.

Expected Result:

The report name in Report field should not have negative amount.

Actual Result:

The report name in Report field shows negative amount.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6802412_1744697851920.20250415_141412.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @waterim
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Apr 15, 2025
Copy link

melvin-bot bot commented Apr 15, 2025

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 15, 2025

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 15, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 15, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny removed the DeployBlocker Indicates it should block deploying the API label Apr 15, 2025
@mountiny
Copy link
Contributor

@waterim @rayane-d @DylanDylann can you please have a look at this one? I will demote as its all offline and minor

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 15, 2025
@mountiny mountiny changed the title Expense - Report name in Report field shows negative amount in offline mode [Change Report] Expense - Report name in Report field shows negative amount in offline mode Apr 15, 2025
@mountiny mountiny moved this to Second Cohort - HIGH in [#whatsnext] #migrate Apr 15, 2025
@rayane-d
Copy link
Contributor

@joekaufmanexpensify
Copy link
Contributor

Seems like we're making a plan for this above. Let me know if I can help!

@luacmartins
Copy link
Contributor

We'll put this button behind a beta and tackle the issue as a follow up.

@joekaufmanexpensify
Copy link
Contributor

Sounds great, thank you!

Copy link

melvin-bot bot commented Apr 21, 2025

@waterim Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Apr 21, 2025
@joekaufmanexpensify
Copy link
Contributor

PR is WIP

@joekaufmanexpensify
Copy link
Contributor

@waterim is there an ETA to have a PR in review here?

@waterim
Copy link
Contributor

waterim commented Apr 22, 2025

Hey, this one is fixed already and will be opened tomorrow, my draft contains more than one bug and takes a bit longer

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2025
@luacmartins
Copy link
Contributor

Thanks @waterim! We can do one PR per issue if that speeds things up. I think that makes it easier on reviewers too, since it's just one case to test

@joekaufmanexpensify
Copy link
Contributor

Thanks for the update!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 23, 2025
@joekaufmanexpensify
Copy link
Contributor

PR merged

@luacmartins
Copy link
Contributor

This is fixed in staging. Gonna close it out.

@github-project-automation github-project-automation bot moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrate Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

6 participants