Expense - Infinite loading when WS admin tries to change employee´s expense to another report

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.28-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Be logged in with two different accounts in two different devices or environments.
Prerequisite 2: Delayed submissions disabled for workspace.

1. Open the staging.new.expensify.com website.
2. Log in with User A account.
3. Open any workspace chat.
4. Create a manual expense.
5. Navigate to "Settings" and open "Workspaces"
6. Open the workspace where the expense was submitted.
7. Tap on "Members" and invite User B to workspace.
8. Switch to User B account.
9. Open the just invited workspace´s chat.
10. Create a manual expense.
11. Switch to User A account again.
12. Open the report of the expense created by User B.
13. Tap on "Report"
14. Change the expense to a different report.
15. On expense report, tap on "Report" again.
16. Note that expense wasn´t changed to another report.
17. Try to change reports again.
18. Check the page behaviour with this action.

Expected Result:

Admin of a workspace shoulnd´t be able to change employee´s expense to a different report or there should not be infinite loading page

Actual Result:

Admin of a workspace, has the option to change employee´s expense to a different report and infinite loading is experienced when trying to complete that action.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @waterim

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[vincdargento]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MarioExpensify]

There is an ongoing discussion about the ChangeTransactionsReport related flows here. The Report change button will be put behind a beta and all bugs will be addressed in follow up issues.

[luacmartins]

No longer available in staging. Demoting.

[melvin-bot]

@waterim Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@waterim 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[waterim]

@luacmartins

Getting this error from the BE for this issue, what should be an expected behaviour?
Do we need to filter additionally reports?

[luacmartins]

Looking

[luacmartins]

I think the issue is in the FE. We should only show reports from the same workspace AND that belong to the original submitter. I can work on a fix for it tomorrow.

[luacmartins]

Got a PR up for this one #60857

[luacmartins]

This is fixed in staging.