Skip to content

Some random name displayed on the confirmation page when creating an expense #60388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 18 tasks
m-natarajan opened this issue Apr 17, 2025 · 8 comments
Closed
1 of 18 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 17, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): expensify-bug

Action Performed:

  1. go to a workspace
  2. Click create expense
  3. proceed to confirm details page

Expected Result:

Correct report name appears for report field

Actual Result:

Showing random name in the report field

Workaround:

unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @luacmartins
@m-natarajan m-natarajan added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause labels Apr 17, 2025
Copy link

melvin-bot bot commented Apr 17, 2025

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Copy link

melvin-bot bot commented Apr 21, 2025

@waterim Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Apr 21, 2025
Copy link

melvin-bot bot commented Apr 23, 2025

@waterim Huh... This is 4 days overdue. Who can take care of this?

@luacmartins
Copy link
Contributor

I was able to reproduce this. Being fixed in #60857.

Steps to reproduce:
Prerequisite: an admin and an employee in the workspace
Prerequisite 2: Delayed submissions disabled for workspace

  1. [Employee] Create a new report but don't submit it
  2. [Employee] Rename the report to something easy to identify
  3. [Admin] Start the flow to submit a manual expense
  4. [Admin] On the last step, click the Show more button
  5. [Admin] Verify that the report created and renamed by the employee in step 1-2 doesn't show up and instead you see the correct report name

The issue is that we were only filtering for outstanding reports on the same policy, so admins would have access to reports from other users. When creating or moving transactions to reports, admins should only be able to do so between reports belonging to the same user. So the fix is to filter the outstanding reports by policy AND report owner (when moving between existing reports) or currentUser when creating a new report

@luacmartins luacmartins removed Needs Reproduction Reproducible steps needed Overdue retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause labels Apr 24, 2025
@luacmartins luacmartins added Reviewing Has a PR in review and removed Overdue labels Apr 24, 2025
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@luacmartins
Copy link
Contributor

I left a comment above on the reproducible steps. I also have a PR to fix this

@luacmartins
Copy link
Contributor

Fixed in staging. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants