[Due for payment 2025-04-28] Expense - Report page is blank when submitting expense to workspace with no report

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.28-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat that has no expense report.
3. Click + > Create expense > Manual.
4. Enter amountn > Next.
5. Click Show more.
6. Note that Report field has a report title.
7. Click Report.

Expected Result:

Report page should display the report title in Step 6.

Actual Result:

Report page is blank.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The Report page appears blank.

What is the root cause of that problem?

• We always allow users to click on the "Report" row to open the report selector screen:
  

  App/src/components/MoneyRequestConfirmationListFooter.tsx

  Line 655 in 4ee6daa

  <MenuItemWithTopDescription

• However, this behavior occurs regardless of whether we have valid report data to display, which can lead to a blank screen.

What changes do you think we should make in order to solve the problem?

• We should correctly populate the values for these props:

  • App/src/components/MoneyRequestConfirmationListFooter.tsx

    Line 657 in 4ee6daa

    shouldShowRightIcon

  • App/src/components/MoneyRequestConfirmationListFooter.tsx

    Line 668 in 4ee6daa

    interactive

!!getOutstandingReports(policyID, allReports ?? {}).at(0)

with:

const policyID = Object.values(allReports ?? {}).find(
    (report) =>
        report?.reportID === transaction?.reportID ||
        report?.reportID === transaction?.participants?.at(0)?.reportID,
)?.policyID;

• Then, we should ensure the report selector screen handles the empty state gracefully. In:
  

  App/src/pages/iou/request/step/IOURequestStepReport.tsx

  Line 94 in 4ee6daa

  <StepScreenWrapper

  we can display a "not found" or empty state view when no report options are available by setting:

shouldShowNotFoundPage={expenseReports.length === 0}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• None

What alternative solutions did you explore? (Optional)

Option 1:

• In this screen, we can pass the current selected reportName via its url.

• Then in here:

        if (expenseReports.length === 0) {
            return [{text: route.params.reportName, value: '', keyForList: route.params.reportName, isSelected: true, isInteractive: false, isDisabled: false}];
        }

Option 2:

• We can display the empty state view when expenseReports.length === 0

[rayane-d]

Discussing in https://expensify.slack.com/archives/C01GTK53T8Q/p1744712146580769

[mallenexpensify]

Basically I think we should put the button behind the tableReportView beta and then we dont have to hodl the deploy and get through these follow ups safely

Vit recommended the above, if we go this route, we can remove Hourly

[luacmartins]

We'll put this button behind a beta and tackle the issue as a follow up.

[luacmartins]

No longer available in staging. Demoting.

[melvin-bot]

@waterim Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Follow-up]: fix issues related to ChangeTransactionsReport #60318

If no regressions arise, payment will be issued on 2025-04-28. 🎊

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)

[melvin-bot]

@luacmartins / @techievivek @mallenexpensify @waterim The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[luacmartins]

This has been fixed. Closing.