8.2 Deployment #305
Merged
8.2 Deployment #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily remove the methods failing versioning. To be readded once a fix for them is in place.
…tored to make the versioning check pass
Revert "updated angle calc" This reverts commit 6ed0b63. update angle calc
…latedMaterialLifeCycleEnvironmentalImpactFactors
pawelbaran
reviewed
Jun 24, 2025
There was a problem hiding this comment.
No glitches found throughout the testing, can approve on that basis. However, leaving the final word to @adecler who's definitely more in the weeds
adecler
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
Approving based on the following:
- Versioning is working in all UIs :Excel, GH with Rhino 7 & 8
- Versioning check is passing
- The test Runner on Versioning gives no errors on any entry from version 7.3 to 8.1.
- There are some errors from version 7.1. and lower (Versioning errors.txt) but those have been confirmed by @pawelbaran to be known and acceptable.
|
@BHoMBot check ready-to-merge |
1 similar comment
|
@BHoMBot check ready-to-merge |
|
@michaelhoehn to confirm, the following actions are now queued:
There are 119 requests in the queue ahead of you. |
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge |
|
@adecler I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versioning_Toolkit
Feature
CameraDevicecustom versioningBug