Skip to content

Add CameraDevice custom versioning #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2025
Merged

Add CameraDevice custom versioning #299

merged 3 commits into from
Jun 2, 2025

Conversation

michal-pekacki
Copy link
Contributor

@michal-pekacki michal-pekacki commented May 26, 2025 •
edited
Loading

NOTE: Depends on

BHoM-#1683

Issues addressed by this PR

Closes #

Add versioning after changes in BH.oM.Security.Elements.CameraDevice.

Test files

GH script

Changelog

Additional comments

@michal-pekacki michal-pekacki self-assigned this May 26, 2025
@michal-pekacki michal-pekacki added the type:feature New capability or enhancement label May 26, 2025
@pawelbaran
Copy link
Member

@BHoMBot check versioning

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented May 26, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented May 26, 2025

@michal-pekacki to confirm, the following actions are now queued:

  • check versioning

@michal-pekacki
updated angle calc
9a80395 
Revert "updated angle calc"

This reverts commit 6ed0b63.

update angle calc
@michal-pekacki michal-pekacki force-pushed the Revit_SecurityICT_Tool-#66-CameraFieldOfViewUpdate branch from 3ce29a4 to 9a80395 Compare May 29, 2025 11:32
pawelbaran
pawelbaran approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, test file works as expected, happy to approve

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jun 2, 2025

@michal-pekacki just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on BHoM_Engine

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jun 2, 2025

@michal-pekacki just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on BHoM_Engine

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jun 2, 2025

@michal-pekacki just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michal-pekacki on BHoM

@pawelbaran pawelbaran merged commit 85442e9 into develop Jun 2, 2025
5 checks passed
@pawelbaran pawelbaran deleted the Revit_SecurityICT_Tool-#66-CameraFieldOfViewUpdate branch June 2, 2025 07:47
@BHoMBot BHoMBot mentioned this pull request Jun 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelbaran pawelbaran pawelbaran approved these changes

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

@adam-sobieski adam-sobieski Awaiting requested review from adam-sobieski

Assignees

@michal-pekacki michal-pekacki

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michal-pekacki @pawelbaran