Skip to content

Add versioning for metrics and results #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1641
BHoM/LifeCycleAssessment_Toolkit#357

Issues addressed by this PR

Add versioning for metrics and results, removing MetricType no longer a property.

Test files

Changelog

Additional comments

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check core

Copy link

bhombot-ci bot commented Jun 11, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check core

@IsakNaslundBh IsakNaslundBh self-assigned this Jun 11, 2025
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Jun 11, 2025
pawelbaran
pawelbaran previously approved these changes Jun 13, 2025
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 13, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot copyright-compliance
@BHoMBot check core

Copy link

bhombot-ci bot commented Jun 13, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning
  • check installer
  • check core

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after updating from develop

@IsakNaslundBh
Copy link
Contributor Author

IsakNaslundBh commented Jun 13, 2025

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jun 13, 2025

@IsakNaslundBh sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

Copy link

bhombot-ci bot commented Jun 13, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check copyright-compliance

Copy link

bhombot-ci bot commented Jun 13, 2025

@IsakNaslundBh just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh IsakNaslundBh merged commit 65eb360 into develop Jun 13, 2025
5 checks passed
@IsakNaslundBh IsakNaslundBh deleted the LifeCycleAssessment_Toolkit-#306-AddCalculatedMaterialLifeCycleEnvironmentalImpactFactors branch June 13, 2025 11:07
@BHoMBot BHoMBot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants