Skip to content

Redundant MessageForDeleted removed #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025

Conversation

pawelbaran
Copy link
Member

NOTE: Depends on

BHoM/BHoM_Engine#3491

Issues addressed by this PR

Closes #296

Test files

Passing versioning check should be enough - if these indeed were needed, the check would not have passed.

Changelog

Additional comments

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Apr 15, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

Copy link

bhombot-ci bot commented Apr 15, 2025

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine

Copy link
Contributor

@michal-pekacki michal-pekacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense and versioning check passed 👍

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Apr 29, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 33 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Apr 29, 2025

@pawelbaran just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine

Copy link

bhombot-ci bot commented Apr 29, 2025

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran pawelbaran merged commit 58a6654 into develop Apr 29, 2025
5 checks passed
@pawelbaran pawelbaran deleted the BHoM_Engine-#3490-FixCreateEngineType branch April 29, 2025 13:11
@BHoMBot BHoMBot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MessageForDeleted for methods that still exist in the code base
2 participants