Skip to content

fix: remove unused jvm_contrib #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

fix: remove unused jvm_contrib #330

merged 1 commit into from
Feb 6, 2025

Conversation

nikhil-zlai
Copy link
Contributor

@nikhil-zlai nikhil-zlai commented Feb 6, 2025

Summary

Solves sync failures

Checklist

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested
  • Documentation update

Summary by CodeRabbit

  • Chores
    • Streamlined the Java build configuration by removing legacy integration and testing support.

Copy link

coderabbitai bot commented Feb 6, 2025

Walkthrough

This pull request removes references to the deprecated contrib_rules_jvm in the build configuration. The changes eliminate the http_archive definition and its associated dependency setup functions in the WORKSPACE file, and also drop the load statement for the java_test_suite in the prelude file. Other configurations for Scala, Java, and Protobuf remain unchanged.

Changes

File Change Summary
WORKSPACE Removed http_archive for contrib_rules_jvm, along with contrib_rules_jvm_deps() and contrib_rules_jvm_setup() calls.
tools/.../prelude_bazel Removed the load statement for java_test_suite from @contrib_rules_jvm//docs:stardoc-input.bzl.

Possibly related PRs

Suggested reviewers

  • piyush-zlai
  • kumar-zlai

Poem

In files where clutter used to be,
The old JVM calls set themselves free.
A cleaner workspace now stands tall,
Code refined, answering the call.
Cheers to simplicity for one and all!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 656d3ed and 0ef8cd7.

📒 Files selected for processing (2)
  • WORKSPACE (0 hunks)
  • tools/build_rules/prelude_bazel (0 hunks)
💤 Files with no reviewable changes (2)
  • tools/build_rules/prelude_bazel
  • WORKSPACE

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nikhil-zlai nikhil-zlai merged commit 9cf25f3 into main Feb 6, 2025
4 checks passed
@nikhil-zlai nikhil-zlai deleted the sync_fix branch February 6, 2025 06:31
@kumar-zlai
Copy link
Contributor

We are using java_test_suite in service_commons/BUILD.bazel and I seem to be getting sync failures after this change ?

kumar-zlai added a commit that referenced this pull request Feb 6, 2025
kumar-zlai added a commit that referenced this pull request Feb 6, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
nikhil-zlai added a commit that referenced this pull request Feb 19, 2025
## Summary
Solves sync failures

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Streamlined the Java build configuration by removing legacy
integration and testing support.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
nikhil-zlai pushed a commit that referenced this pull request Feb 19, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai bot mentioned this pull request Mar 2, 2025
4 tasks
kumar-zlai pushed a commit that referenced this pull request Apr 25, 2025
## Summary
Solves sync failures

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Streamlined the Java build configuration by removing legacy
integration and testing support.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
kumar-zlai added a commit that referenced this pull request Apr 25, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
kumar-zlai pushed a commit that referenced this pull request Apr 29, 2025
## Summary
Solves sync failures

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Streamlined the Java build configuration by removing legacy
integration and testing support.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
kumar-zlai added a commit that referenced this pull request Apr 29, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary
Solves sync failures

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Streamlined the Java build configuration by removing legacy
integration and testing support.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
## Summary
Solves sync failures

## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Streamlined the Java build configuration by removing legacy
integration and testing support.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
## Summary
Solves sync failures

## Cheour clientslist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Streamlined the Java build configuration by removing legacy
integration and testing support.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants