-
Notifications
You must be signed in to change notification settings - Fork 0
fix: remove unused jvm_contrib #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request removes references to the deprecated Changes
Possibly related PRs
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
We are using java_test_suite in service_commons/BUILD.bazel and I seem to be getting sync failures after this change ? |
This reverts commit 9cf25f3.
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Solves sync failures ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Streamlined the Java build configuration by removing legacy integration and testing support. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Solves sync failures ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Streamlined the Java build configuration by removing legacy integration and testing support. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Solves sync failures ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Streamlined the Java build configuration by removing legacy integration and testing support. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Solves sync failures ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Streamlined the Java build configuration by removing legacy integration and testing support. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Solves sync failures ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Streamlined the Java build configuration by removing legacy integration and testing support. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary Solves sync failures ## Cheour clientslist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Streamlined the Java build configuration by removing legacy integration and testing support. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Solves sync failures
Checklist
Summary by CodeRabbit