-
Notifications
You must be signed in to change notification settings - Fork 0
Revert "fix: remove unused jvm_contrib" #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 9cf25f3.
WalkthroughThe pull request adds new configuration for JVM support in the build system. It introduces an http_archive entry for contrib_rules_jvm in the WORKSPACE file, along with two new functions—contrib_rules_jvm_deps() and contrib_rules_jvm_setup(). Additionally, it imports a java_test_suite rule in the prelude, allowing for enhanced Java test suite management. Changes
Sequence Diagram(s)sequenceDiagram
participant B as Bazel
participant W as WORKSPACE
participant CRJ as contrib_rules_jvm
participant BP as BUILD prelude
B->>W: Load WORKSPACE
W->>CRJ: Process http_archive config
B->>CRJ: Call contrib_rules_jvm_deps() & contrib_rules_jvm_setup()
B->>BP: Load BUILD prelude
BP->>CRJ: Import java_test_suite rule
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsGitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository. Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330 It's breaking our build as we are using `java_test_suite` for service_commons module <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configuration to support improved Java testing capabilities. - Expanded build system functionality with additional integrations for JVM-based test suites. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Reverts #330
It's breaking our build as we are using
java_test_suite
for service_commons moduleSummary by CodeRabbit