Skip to content

Revert "fix: remove unused jvm_contrib" #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

kumar-zlai
Copy link
Contributor

@kumar-zlai kumar-zlai commented Feb 6, 2025

Reverts #330

It's breaking our build as we are using java_test_suite for service_commons module

Summary by CodeRabbit

  • New Features
    • Enhanced configuration to support improved Java testing capabilities.
    • Expanded build system functionality with additional integrations for JVM-based test suites.

Copy link

coderabbitai bot commented Feb 6, 2025

Walkthrough

The pull request adds new configuration for JVM support in the build system. It introduces an http_archive entry for contrib_rules_jvm in the WORKSPACE file, along with two new functions—contrib_rules_jvm_deps() and contrib_rules_jvm_setup(). Additionally, it imports a java_test_suite rule in the prelude, allowing for enhanced Java test suite management.

Changes

File(s) Summary of Changes
WORKSPACE Added http_archive for contrib_rules_jvm; introduced contrib_rules_jvm_deps() and contrib_rules_jvm_setup().
tools/build_rules/.../prelude_bazel Imported java_test_suite from @contrib_rules_jvm//docs:stardoc-input.bzl.

Sequence Diagram(s)

sequenceDiagram
    participant B as Bazel
    participant W as WORKSPACE
    participant CRJ as contrib_rules_jvm
    participant BP as BUILD prelude

    B->>W: Load WORKSPACE
    W->>CRJ: Process http_archive config
    B->>CRJ: Call contrib_rules_jvm_deps() & contrib_rules_jvm_setup()
    B->>BP: Load BUILD prelude
    BP->>CRJ: Import java_test_suite rule
Loading

Possibly related PRs

Suggested reviewers

  • nikhil-zlai
  • tchow-zlai

Poem

In the realm of build, a new rule is spun,
HTTP archives and functions join as one.
Java tests now find their tune,
With setup calls and imports in bloom.
🚀 Code evolves in a joyful run!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 9cf25f3 and f65fb54.

📒 Files selected for processing (2)
  • WORKSPACE (1 hunks)
  • tools/build_rules/prelude_bazel (1 hunks)
🔇 Additional comments (2)
tools/build_rules/prelude_bazel (1)

7-7: LGTM!

Import statement correctly restores java_test_suite rule.

WORKSPACE (1)

51-66: LGTM!

Configuration correctly restores contrib_rules_jvm with proper versioning and setup.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kumar-zlai kumar-zlai merged commit 2539267 into main Feb 6, 2025
4 checks passed
@kumar-zlai kumar-zlai deleted the revert-330-sync_fix branch February 6, 2025 19:37
nikhil-zlai pushed a commit that referenced this pull request Feb 19, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
kumar-zlai added a commit that referenced this pull request Apr 25, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
kumar-zlai added a commit that referenced this pull request Apr 29, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 15, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
chewy-zlai pushed a commit that referenced this pull request May 16, 2025
Reverts #330

It's breaking our build as we are using `java_test_suite` for
service_commons module

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced configuration to support improved Java testing capabilities.
- Expanded build system functionality with additional integrations for
JVM-based test suites.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants