Bazel migration for service_commons module

[kumar-zlai]

Summary

Migrated service_commons module to Bazel from sbt.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced build configuration to support Java 17
  • Added new JVM rulesets for improved testing and development

• Dependencies

  • Updated Netty to version 4.1.111.Final
  • Added JUnit 5 testing components
  • Integrated Vert.x 4.5.10 libraries
  • Added logback and configuration libraries

• Build Improvements

  • Refined Bazel build rules for Java libraries and test suites
  • Streamlined dependency management

[coderabbitai]

Walkthrough

This pull request introduces comprehensive updates to the build configuration and dependency management for a Java project. The changes focus on standardizing Java language and runtime versions to version 17, adding new JVM rulesets, defining service commons libraries and test suites, and expanding the Maven repository with updated and new dependencies across testing, logging, configuration, and Vert.x frameworks.

Changes

File	Change Summary
.bazelrc	Added Java language and runtime version configurations to version 17
WORKSPACE	Added contrib_rules_jvm ruleset with dependencies and setup functions
service_commons/BUILD.bazel	Added Java libraries (lib, test-lib) and test suite with dependencies
service_commons/src/main/java/...ChrononServiceLauncher.java	Simplified statsProps map initialization using Map.of()
tools/build_rules/dependencies/maven_repository.bzl	Added/updated dependencies for JUnit, Netty, Logback, Vert.x, and other libraries
tools/build_rules/prelude_bazel	Added load statements for Java libraries and test suites, introduced SCALA_DEPS

Possibly related PRs

• feat: use log4j2 everywhere in spark consistently #99: Updating logging dependencies to Log4j2
• Bazel migration for spark module #196: Migrating logging framework from SLF4J's Log4j 1.x to Log4j 2.x

Suggested reviewers

• nikhil-zlai
• piyush-zlai
• tchow-zlai

Poem

🚀 Bazel's dance of code and might,
Java seventeen takes its flight,
Dependencies aligned with grace,
Libraries finding their embrace,
A build configuration's delight! 🌟

Warning

Review ran into problems

🔥 Problems

GitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

service_commons/BUILD.bazel (1)

42-63: Optimize test dependencies.

test-lib dependencies are duplicated in test. Move common deps to test-lib.

 java_test_suite(
     name = "test",
     srcs = glob(["src/test/**/*.java"]),
     visibility = ["//visibility:public"],
     runner = "junit5",
     deps = [
         ":lib",
         ":test-lib",
-        "//api:lib",
-        "//api:thrift",
-        "//online:lib",
-        # Libraries
-        maven_artifact("io.vertx:vertx-core"),
-        maven_artifact("io.vertx:vertx-web"),
-        maven_artifact("io.vertx:vertx-web-client"),
-        # Testing
-        maven_artifact("io.vertx:vertx-junit5"),
-        maven_artifact("org.junit.jupiter:junit-jupiter-api"),
         maven_artifact("org.junit.platform:junit-platform-launcher"),
         maven_artifact("org.junit.platform:junit-platform-reporting"),
     ],
 )

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 9d32bfd and 678a67c.

📒 Files selected for processing (6)

• .bazelrc (1 hunks)
• WORKSPACE (1 hunks)
• service_commons/BUILD.bazel (1 hunks)
• service_commons/src/main/java/ai/chronon/service/ChrononServiceLauncher.java (1 hunks)
• tools/build_rules/dependencies/maven_repository.bzl (2 hunks)
• tools/build_rules/prelude_bazel (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• .bazelrc
• service_commons/src/main/java/ai/chronon/service/ChrononServiceLauncher.java

🔇 Additional comments (3)

tools/build_rules/prelude_bazel (1)

11-14: Complete the SCALA_DEPS list.

The comment suggests more Scala deps but none are listed.

tools/build_rules/dependencies/maven_repository.bzl (1)

51-51: Verify Netty version compatibility.

Netty 4.1.111.Final is very recent. Ensure compatibility with Vertx 4.5.10.

WORKSPACE (1)

44-54: LGTM!

contrib_rules_jvm setup is correct and properly integrated.

[tchow-zlai]

btw @kumar-zlai once we get to building out the cloud_gcp target we'll need to use jdk 11 for GCP compatibility.

[piyush-zlai]

I think for the service we should be fine on a newer jdk. It is preferable as we can leverage shenandoah gc etc which has better perf etc on 17..