cleanup: remove tagged filter suite

[nikhil-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor

  • Simplified the internal testing setup by removing extra filtering and categorization elements.

• Tests

  • Streamlined the test suite while maintaining full validation of core functionalities.

[coderabbitai]

Walkthrough

The PR simplifies the test suite by removing the TaggedFilterSuite mixin from the CatalystUtilHiveUDFTest class and deleting the corresponding TaggedFilterSuite trait file. The overridden tagName method is also removed, meaning tests will no longer be conditionally filtered by a tag. Functionality for validating Hive UDFs remains unchanged.

Changes

File(s)	Change Summary
online/.../CatalystUtilHiveUDFTest.scala	Removed TaggedFilterSuite mixin and deleted the overridden tagName method.
online/.../TaggedFilterSuite.scala	Deleted the TaggedFilterSuite trait that enabled tag-based filtering for test execution.

Possibly related PRs

• Tweak spark test setup to tags and run tests appropriately #56: Adjusts tagging in test execution by removing the TaggedFilterSuite mixin similar to the main PR.
• chore:remove taggedFilterSuite #378: Deletes the TaggedFilterSuite trait from multiple test classes, aligning with the removal in this PR.
• fix: remove unused jvm_contrib #330: Involves removing the TaggedFilterSuite trait, affecting tag-based filtering in tests at the code level.

Suggested reviewers

• tchow-zlai
• varant-zlai
• piyush-zlai

Poem

Simplified tests march on their way,
Removing tags to brighten the day.
Traits undone, the clutter gone,
Code stands neat, a cleaner dawn.
Cheers to change in every run!
🚀 Happy coding!

Warning

Review ran into problems

🔥 Problems

GitHub Actions and Pipeline Checks: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 4d3e3ef and cbe83a1.

📒 Files selected for processing (2)

• online/src/test/scala/ai/chronon/online/test/CatalystUtilHiveUDFTest.scala (1 hunks)
• online/src/test/scala/ai/chronon/online/test/TaggedFilterSuite.scala (0 hunks)

💤 Files with no reviewable changes (1)

• online/src/test/scala/ai/chronon/online/test/TaggedFilterSuite.scala

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: non_spark_tests
• GitHub Check: non_spark_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (1)

online/src/test/scala/ai/chronon/online/test/CatalystUtilHiveUDFTest.scala (1)

7-7: Simplified test class inheritance.

Removal of TaggedFilterSuite trait aligns with PR objective to clean up the tagged filter suite.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tchow-zlai]

does this need to be run on its own?

[nikhil-zlai]

does this need to be run on its own?

bazel isolates the tests better by default