-
Notifications
You must be signed in to change notification settings - Fork 1.5k
modified ntp script to hide the error related to cfggen during bootup #3745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified ntp script to hide the error related to cfggen during bootup #3745
Conversation
retest vs please |
it is better to avoid print out this traceback. can you print error message in sonic-cfggen saying the data[yyy] is not available to stderr? This can be a separate pr. |
@lguohan : In this change, we are masking the stderr outside the cfggen. Can we assume that you would be merging this PR? |
let's discuss this in #3775 |
…-net#3745) This PR is to handle the issue 3527. When device boots up, NTP throws a traceback as explained in the issue 3527. - Traceback will be seen when MGMT_VRF_CONFIG does not exist in the database. Traceback is coming from the script “/etc/init.d/ntp”. - Traceback does not affect the NTP functionality with/without management VRF. When MGMT_VRF_CONFIG does not exist or when MGMT_VRF_CONFIG’s mgmtVrfEnabled is configured to “false”, “NTP” will be started in the “default VRF” context, which is working fine even with this traceback. - This traceback error will be hidden by redirecting the error to /dev/null without affecting functionality.
…atically (#21343) #### Why I did it src/sonic-utilities ``` * 899ed9b - (HEAD -> master, origin/master, origin/HEAD) Remove Multi ASIC namespace Check. (#3783) (3 days ago) [Xincun Li] * 9f1eab4 - Memory Statistics Config and Show Commands (#3575) (3 days ago) [Kanza Latif] * 595c2aa - Utilities Changes for DHCP DoS Mitigation Feature (#3301) (3 days ago) [Asad Raza] * a3d15bc - Add multi-asic support for dropconfig (#3735) (3 days ago) [HP] * 5ce06b2 - Add golden config check (#3770) (4 days ago) [Xincun Li] * 3c50dee - Fix `vnet_route_check` for active and inactive routes, add `--all` option (#3763) (9 days ago) [mramezani95] * 40ba225 - Revert "enable pfcwd for backplane ports (#3759)" (#3767) (13 days ago) [Dashuai Zhang] * 2866ccd - enable pfcwd for backplane ports (#3759) (2 weeks ago) [Dashuai Zhang] * 3abd19e - [FC] remove FC delay field (#3577) (3 weeks ago) [Stepan Blyshchak] * 11c2716 - Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. (#3700) (3 weeks ago) [Hua Liu] * 13619aa - [QOS] Skip showing unnecessary warning message (#3708) (3 weeks ago) [Vivek] * f4e6e5b - Fixing 'show ip bgp neighbor <ip>' in frr unified config mode (#3738) (3 weeks ago) [kalash-nexthop] * 9a18155 - Optimize lag_keepalive by crafting the LACPDU packet ourselves (#3170) (3 weeks ago) [Saikrishna Arcot] * a7deb8c - display proper message with proper errno for kvm. (#3750) (3 weeks ago) [Dawei Huang] * 865f196 - [Mellanox] Add new SN5640 platform and HwSKU (#3742) (4 weeks ago) [Noa Or] * 5fa8502 - [show_techsupport][pstore] Archive /var/lib/systemd/pstore info to techsupport (#3745) (4 weeks ago) [Marty Y. Lok] * 8f69d5a - sonic-utilities: WRED stats feature changes on sonic-utilities (#2807) (4 weeks ago) [Rajesh Perumal R] * 9d273f1 - Fix call for spanning-tree commands in dump script (#3723) (4 weeks ago) [DavidZagury] * 6d95d9b - Make 'show ip bgp summary' work even when we don't have any peer groups (#3739) (4 weeks ago) [kalash-nexthop] * 7f3957c - Fix ssdhealth failure on VS platform (#3743) (4 weeks ago) [Vivek] * 97b4e4b - Fix show interface counters for Chassis Packet Supervisor (#3734) (4 weeks ago) [anamehra] * 414935b - Add recover asic_id config if load golden config. (#3711) (5 weeks ago) [Xincun Li] * 973cfdc - Remove partially installer image when image install failed. (#3712) (5 weeks ago) [Hua Liu] * 97c20cc - CLI support for SmartSwitch PMON (#3271) (5 weeks ago) [rameshraghupathy] * 752c3d4 - [ACL] Display rule and table info written to APP DB (#3713) (5 weeks ago) [Vivek] * fbd0c3b - [show][interface] Add changes for show interface flap command (#3724) (5 weeks ago) [vdahiya12] * ddccabe - [show][interface] Add changes for show interface errors command (#3721) (5 weeks ago) [vdahiya12] * be870a6 - [config] Exit with non-zero when qos reload fail (#3710) (6 weeks ago) [Jianyue Wu] * ffa66e9 - Remove debug dump import by default (#3715) (6 weeks ago) [Vivek] * fc3a3cb - [ssdhealth] Check for default device before falling back to discovery (#3693) (6 weeks ago) [Vivek] * 782c33a - [yang] Enforce yang full support in full config command (#3716) (6 weeks ago) [jingwenxie] * a5b7a90 - [show][interfaces] Add proposal for show interfaces flap (#3627) (6 weeks ago) [vdahiya12] * 0083a12 - sonic-utilities: add th5 hwskus to gcu conf file (#3714) (7 weeks ago) [Chris] * 81cf04f - [Mellanox] Add Mellanox-SN5610N-C256S2, Mellanox-SN5610N-C224O8 to GCU validators (#3658) (7 weeks ago) [noaOrMlnx] * 349a101 - [db_migrator] Migrate tunnel table (#3704) (7 weeks ago) [Longxiang Lyu] * 0e327c5 - show ip interfaces: fix exception with BGP unnumbered (#3695) (8 weeks ago) [Brad House] * 7100f73 - [show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info (#3676) (8 weeks ago) [Marty Y. Lok] * 80d4698 - Delete TRSNCEIVER tables while config reload (#3680) (8 weeks ago) [noaOrMlnx] * bf6ff9f - Enable multi asic golden config YANG validation. (#3685) (8 weeks ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
…atically (sonic-net#21343) #### Why I did it src/sonic-utilities ``` * 899ed9b - (HEAD -> master, origin/master, origin/HEAD) Remove Multi ASIC namespace Check. (sonic-net#3783) (3 days ago) [Xincun Li] * 9f1eab4 - Memory Statistics Config and Show Commands (sonic-net#3575) (3 days ago) [Kanza Latif] * 595c2aa - Utilities Changes for DHCP DoS Mitigation Feature (sonic-net#3301) (3 days ago) [Asad Raza] * a3d15bc - Add multi-asic support for dropconfig (sonic-net#3735) (3 days ago) [HP] * 5ce06b2 - Add golden config check (sonic-net#3770) (4 days ago) [Xincun Li] * 3c50dee - Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3763) (9 days ago) [mramezani95] * 40ba225 - Revert "enable pfcwd for backplane ports (sonic-net#3759)" (sonic-net#3767) (13 days ago) [Dashuai Zhang] * 2866ccd - enable pfcwd for backplane ports (sonic-net#3759) (2 weeks ago) [Dashuai Zhang] * 3abd19e - [FC] remove FC delay field (sonic-net#3577) (3 weeks ago) [Stepan Blyshchak] * 11c2716 - Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. (sonic-net#3700) (3 weeks ago) [Hua Liu] * 13619aa - [QOS] Skip showing unnecessary warning message (sonic-net#3708) (3 weeks ago) [Vivek] * f4e6e5b - Fixing 'show ip bgp neighbor <ip>' in frr unified config mode (sonic-net#3738) (3 weeks ago) [kalash-nexthop] * 9a18155 - Optimize lag_keepalive by crafting the LACPDU packet ourselves (sonic-net#3170) (3 weeks ago) [Saikrishna Arcot] * a7deb8c - display proper message with proper errno for kvm. (sonic-net#3750) (3 weeks ago) [Dawei Huang] * 865f196 - [Mellanox] Add new SN5640 platform and HwSKU (sonic-net#3742) (4 weeks ago) [Noa Or] * 5fa8502 - [show_techsupport][pstore] Archive /var/lib/systemd/pstore info to techsupport (sonic-net#3745) (4 weeks ago) [Marty Y. Lok] * 8f69d5a - sonic-utilities: WRED stats feature changes on sonic-utilities (sonic-net#2807) (4 weeks ago) [Rajesh Perumal R] * 9d273f1 - Fix call for spanning-tree commands in dump script (sonic-net#3723) (4 weeks ago) [DavidZagury] * 6d95d9b - Make 'show ip bgp summary' work even when we don't have any peer groups (sonic-net#3739) (4 weeks ago) [kalash-nexthop] * 7f3957c - Fix ssdhealth failure on VS platform (sonic-net#3743) (4 weeks ago) [Vivek] * 97b4e4b - Fix show interface counters for Chassis Packet Supervisor (sonic-net#3734) (4 weeks ago) [anamehra] * 414935b - Add recover asic_id config if load golden config. (sonic-net#3711) (5 weeks ago) [Xincun Li] * 973cfdc - Remove partially installer image when image install failed. (sonic-net#3712) (5 weeks ago) [Hua Liu] * 97c20cc - CLI support for SmartSwitch PMON (sonic-net#3271) (5 weeks ago) [rameshraghupathy] * 752c3d4 - [ACL] Display rule and table info written to APP DB (sonic-net#3713) (5 weeks ago) [Vivek] * fbd0c3b - [show][interface] Add changes for show interface flap command (sonic-net#3724) (5 weeks ago) [vdahiya12] * ddccabe - [show][interface] Add changes for show interface errors command (sonic-net#3721) (5 weeks ago) [vdahiya12] * be870a6 - [config] Exit with non-zero when qos reload fail (sonic-net#3710) (6 weeks ago) [Jianyue Wu] * ffa66e9 - Remove debug dump import by default (sonic-net#3715) (6 weeks ago) [Vivek] * fc3a3cb - [ssdhealth] Check for default device before falling back to discovery (sonic-net#3693) (6 weeks ago) [Vivek] * 782c33a - [yang] Enforce yang full support in full config command (sonic-net#3716) (6 weeks ago) [jingwenxie] * a5b7a90 - [show][interfaces] Add proposal for show interfaces flap (sonic-net#3627) (6 weeks ago) [vdahiya12] * 0083a12 - sonic-utilities: add th5 hwskus to gcu conf file (sonic-net#3714) (7 weeks ago) [Chris] * 81cf04f - [Mellanox] Add Mellanox-SN5610N-C256S2, Mellanox-SN5610N-C224O8 to GCU validators (sonic-net#3658) (7 weeks ago) [noaOrMlnx] * 349a101 - [db_migrator] Migrate tunnel table (sonic-net#3704) (7 weeks ago) [Longxiang Lyu] * 0e327c5 - show ip interfaces: fix exception with BGP unnumbered (sonic-net#3695) (8 weeks ago) [Brad House] * 7100f73 - [show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info (sonic-net#3676) (8 weeks ago) [Marty Y. Lok] * 80d4698 - Delete TRSNCEIVER tables while config reload (sonic-net#3680) (8 weeks ago) [noaOrMlnx] * bf6ff9f - Enable multi asic golden config YANG validation. (sonic-net#3685) (8 weeks ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
…atically (sonic-net#21343) #### Why I did it src/sonic-utilities ``` * 899ed9b - (HEAD -> master, origin/master, origin/HEAD) Remove Multi ASIC namespace Check. (sonic-net#3783) (3 days ago) [Xincun Li] * 9f1eab4 - Memory Statistics Config and Show Commands (sonic-net#3575) (3 days ago) [Kanza Latif] * 595c2aa - Utilities Changes for DHCP DoS Mitigation Feature (sonic-net#3301) (3 days ago) [Asad Raza] * a3d15bc - Add multi-asic support for dropconfig (sonic-net#3735) (3 days ago) [HP] * 5ce06b2 - Add golden config check (sonic-net#3770) (4 days ago) [Xincun Li] * 3c50dee - Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3763) (9 days ago) [mramezani95] * 40ba225 - Revert "enable pfcwd for backplane ports (sonic-net#3759)" (sonic-net#3767) (13 days ago) [Dashuai Zhang] * 2866ccd - enable pfcwd for backplane ports (sonic-net#3759) (2 weeks ago) [Dashuai Zhang] * 3abd19e - [FC] remove FC delay field (sonic-net#3577) (3 weeks ago) [Stepan Blyshchak] * 11c2716 - Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. (sonic-net#3700) (3 weeks ago) [Hua Liu] * 13619aa - [QOS] Skip showing unnecessary warning message (sonic-net#3708) (3 weeks ago) [Vivek] * f4e6e5b - Fixing 'show ip bgp neighbor <ip>' in frr unified config mode (sonic-net#3738) (3 weeks ago) [kalash-nexthop] * 9a18155 - Optimize lag_keepalive by crafting the LACPDU packet ourselves (sonic-net#3170) (3 weeks ago) [Saikrishna Arcot] * a7deb8c - display proper message with proper errno for kvm. (sonic-net#3750) (3 weeks ago) [Dawei Huang] * 865f196 - [Mellanox] Add new SN5640 platform and HwSKU (sonic-net#3742) (4 weeks ago) [Noa Or] * 5fa8502 - [show_techsupport][pstore] Archive /var/lib/systemd/pstore info to techsupport (sonic-net#3745) (4 weeks ago) [Marty Y. Lok] * 8f69d5a - sonic-utilities: WRED stats feature changes on sonic-utilities (sonic-net#2807) (4 weeks ago) [Rajesh Perumal R] * 9d273f1 - Fix call for spanning-tree commands in dump script (sonic-net#3723) (4 weeks ago) [DavidZagury] * 6d95d9b - Make 'show ip bgp summary' work even when we don't have any peer groups (sonic-net#3739) (4 weeks ago) [kalash-nexthop] * 7f3957c - Fix ssdhealth failure on VS platform (sonic-net#3743) (4 weeks ago) [Vivek] * 97b4e4b - Fix show interface counters for Chassis Packet Supervisor (sonic-net#3734) (4 weeks ago) [anamehra] * 414935b - Add recover asic_id config if load golden config. (sonic-net#3711) (5 weeks ago) [Xincun Li] * 973cfdc - Remove partially installer image when image install failed. (sonic-net#3712) (5 weeks ago) [Hua Liu] * 97c20cc - CLI support for SmartSwitch PMON (sonic-net#3271) (5 weeks ago) [rameshraghupathy] * 752c3d4 - [ACL] Display rule and table info written to APP DB (sonic-net#3713) (5 weeks ago) [Vivek] * fbd0c3b - [show][interface] Add changes for show interface flap command (sonic-net#3724) (5 weeks ago) [vdahiya12] * ddccabe - [show][interface] Add changes for show interface errors command (sonic-net#3721) (5 weeks ago) [vdahiya12] * be870a6 - [config] Exit with non-zero when qos reload fail (sonic-net#3710) (6 weeks ago) [Jianyue Wu] * ffa66e9 - Remove debug dump import by default (sonic-net#3715) (6 weeks ago) [Vivek] * fc3a3cb - [ssdhealth] Check for default device before falling back to discovery (sonic-net#3693) (6 weeks ago) [Vivek] * 782c33a - [yang] Enforce yang full support in full config command (sonic-net#3716) (6 weeks ago) [jingwenxie] * a5b7a90 - [show][interfaces] Add proposal for show interfaces flap (sonic-net#3627) (6 weeks ago) [vdahiya12] * 0083a12 - sonic-utilities: add th5 hwskus to gcu conf file (sonic-net#3714) (7 weeks ago) [Chris] * 81cf04f - [Mellanox] Add Mellanox-SN5610N-C256S2, Mellanox-SN5610N-C224O8 to GCU validators (sonic-net#3658) (7 weeks ago) [noaOrMlnx] * 349a101 - [db_migrator] Migrate tunnel table (sonic-net#3704) (7 weeks ago) [Longxiang Lyu] * 0e327c5 - show ip interfaces: fix exception with BGP unnumbered (sonic-net#3695) (8 weeks ago) [Brad House] * 7100f73 - [show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info (sonic-net#3676) (8 weeks ago) [Marty Y. Lok] * 80d4698 - Delete TRSNCEIVER tables while config reload (sonic-net#3680) (8 weeks ago) [noaOrMlnx] * bf6ff9f - Enable multi asic golden config YANG validation. (sonic-net#3685) (8 weeks ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
…atically (sonic-net#21343) #### Why I did it src/sonic-utilities ``` * 899ed9b - (HEAD -> master, origin/master, origin/HEAD) Remove Multi ASIC namespace Check. (sonic-net#3783) (3 days ago) [Xincun Li] * 9f1eab4 - Memory Statistics Config and Show Commands (sonic-net#3575) (3 days ago) [Kanza Latif] * 595c2aa - Utilities Changes for DHCP DoS Mitigation Feature (sonic-net#3301) (3 days ago) [Asad Raza] * a3d15bc - Add multi-asic support for dropconfig (sonic-net#3735) (3 days ago) [HP] * 5ce06b2 - Add golden config check (sonic-net#3770) (4 days ago) [Xincun Li] * 3c50dee - Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3763) (9 days ago) [mramezani95] * 40ba225 - Revert "enable pfcwd for backplane ports (sonic-net#3759)" (sonic-net#3767) (13 days ago) [Dashuai Zhang] * 2866ccd - enable pfcwd for backplane ports (sonic-net#3759) (2 weeks ago) [Dashuai Zhang] * 3abd19e - [FC] remove FC delay field (sonic-net#3577) (3 weeks ago) [Stepan Blyshchak] * 11c2716 - Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. (sonic-net#3700) (3 weeks ago) [Hua Liu] * 13619aa - [QOS] Skip showing unnecessary warning message (sonic-net#3708) (3 weeks ago) [Vivek] * f4e6e5b - Fixing 'show ip bgp neighbor <ip>' in frr unified config mode (sonic-net#3738) (3 weeks ago) [kalash-nexthop] * 9a18155 - Optimize lag_keepalive by crafting the LACPDU packet ourselves (sonic-net#3170) (3 weeks ago) [Saikrishna Arcot] * a7deb8c - display proper message with proper errno for kvm. (sonic-net#3750) (3 weeks ago) [Dawei Huang] * 865f196 - [Mellanox] Add new SN5640 platform and HwSKU (sonic-net#3742) (4 weeks ago) [Noa Or] * 5fa8502 - [show_techsupport][pstore] Archive /var/lib/systemd/pstore info to techsupport (sonic-net#3745) (4 weeks ago) [Marty Y. Lok] * 8f69d5a - sonic-utilities: WRED stats feature changes on sonic-utilities (sonic-net#2807) (4 weeks ago) [Rajesh Perumal R] * 9d273f1 - Fix call for spanning-tree commands in dump script (sonic-net#3723) (4 weeks ago) [DavidZagury] * 6d95d9b - Make 'show ip bgp summary' work even when we don't have any peer groups (sonic-net#3739) (4 weeks ago) [kalash-nexthop] * 7f3957c - Fix ssdhealth failure on VS platform (sonic-net#3743) (4 weeks ago) [Vivek] * 97b4e4b - Fix show interface counters for Chassis Packet Supervisor (sonic-net#3734) (4 weeks ago) [anamehra] * 414935b - Add recover asic_id config if load golden config. (sonic-net#3711) (5 weeks ago) [Xincun Li] * 973cfdc - Remove partially installer image when image install failed. (sonic-net#3712) (5 weeks ago) [Hua Liu] * 97c20cc - CLI support for SmartSwitch PMON (sonic-net#3271) (5 weeks ago) [rameshraghupathy] * 752c3d4 - [ACL] Display rule and table info written to APP DB (sonic-net#3713) (5 weeks ago) [Vivek] * fbd0c3b - [show][interface] Add changes for show interface flap command (sonic-net#3724) (5 weeks ago) [vdahiya12] * ddccabe - [show][interface] Add changes for show interface errors command (sonic-net#3721) (5 weeks ago) [vdahiya12] * be870a6 - [config] Exit with non-zero when qos reload fail (sonic-net#3710) (6 weeks ago) [Jianyue Wu] * ffa66e9 - Remove debug dump import by default (sonic-net#3715) (6 weeks ago) [Vivek] * fc3a3cb - [ssdhealth] Check for default device before falling back to discovery (sonic-net#3693) (6 weeks ago) [Vivek] * 782c33a - [yang] Enforce yang full support in full config command (sonic-net#3716) (6 weeks ago) [jingwenxie] * a5b7a90 - [show][interfaces] Add proposal for show interfaces flap (sonic-net#3627) (6 weeks ago) [vdahiya12] * 0083a12 - sonic-utilities: add th5 hwskus to gcu conf file (sonic-net#3714) (7 weeks ago) [Chris] * 81cf04f - [Mellanox] Add Mellanox-SN5610N-C256S2, Mellanox-SN5610N-C224O8 to GCU validators (sonic-net#3658) (7 weeks ago) [noaOrMlnx] * 349a101 - [db_migrator] Migrate tunnel table (sonic-net#3704) (7 weeks ago) [Longxiang Lyu] * 0e327c5 - show ip interfaces: fix exception with BGP unnumbered (sonic-net#3695) (8 weeks ago) [Brad House] * 7100f73 - [show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info (sonic-net#3676) (8 weeks ago) [Marty Y. Lok] * 80d4698 - Delete TRSNCEIVER tables while config reload (sonic-net#3680) (8 weeks ago) [noaOrMlnx] * bf6ff9f - Enable multi asic golden config YANG validation. (sonic-net#3685) (8 weeks ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
This PR is to handle the issue 3527.
When device boots up, NTP throws a traceback as explained in the issue 3527.
3)This traceback error will be hidden by redirecting the error to /dev/null without affecting functionality.
-->
- What I did
Modified files/image_config/ntp/ntp file to redirect the error returned by sonic-cfggen to /dev/null.
- How to verify it
Rebooted device and verified that the traceback error is not seen in the journalctl. Tested NTP without management VRF and with management VRF and confirmed that it works fine.
- Description for the changelog
Modified files/image_config/ntp/ntp file to redirect the error returned by sonic-cfggen to /dev/null.
NOTE: The other issue reported in the issue3527 is related to LOOPBACK_INTERFACE|pfx_filter. That issue is a different issue which is not related to management VRF; it shall be replied accordingly and tracked in separate issue/PR.