Skip to content

print error-message inside sonic-cfggen if any stderr is masked #3755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kannankvs opened this issue Nov 14, 2019 · 0 comments
Open

print error-message inside sonic-cfggen if any stderr is masked #3755

kannankvs opened this issue Nov 14, 2019 · 0 comments

Comments

@kannankvs
Copy link
Collaborator

This issue is based on the issue3527 and the feedback from related PR3745.
Feedback in PR says "can you print error message in sonic-cfggen saying the data[yyy] is not available to stderr? This can be a separate pr".
This issue is opened to track this requirement.

Description
When device boots up, NTP module calls sonic-cfggen to read a management vrf configuration which returns a traceback if the configuration does not exist. If the particular configuration does not exist, NTP starts in default VRF after ignoring the error, which is fine. The traceback print is unnecessary and hence the PR3745 masks the stderr returned by sonic-cfggen.
When this stderr is masked, the new requirement is to print error message in sonic-cfggen saying the data[yyy] is not available to stderr.

Steps to reproduce the issue:

  1. Reboot with master image and check "journalctl -b --no-pager > j1" and open the file to search for MGMT_VRF_CONFIG traceback from NTP. Once if PR3745 is merged, this traceback will not be visible.

Describe the results you received:
The traceback that was seen before merging PR3745 is no more available. i.e. stderr returned by sonic-cfggen is masked while calling it from "ntp" script.

Describe the results you expected:
sonic-cfggen has to print that the stderr is masked.

**Output of `show version`:**

Master image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants