[DellEMC] S6100 Last Reboot Reason Thermal Support #3767

santhosh-kt · 2019-11-15T13:32:32Z

- What I did

Added support for Thermal event in Last Reboot Reason "show reboot-cause" command.
Updated:
Handled dependency based changes(Between process-reboot-cause and s6100_platform.sh).
Handled newer bios based changes(holding previous reset register values and retrieve them in case of secondary bios boot).

- How I did it
On branch sonic-s6100-lrr
Changes to be committed:
(use "git reset HEAD ..." to unstage)

    modified:   files/image_config/platform/rc.local
    new file:   platform/broadcom/sonic-platform-modules-dell/common/nvram_rd_wr.py
    modified:   platform/broadcom/sonic-platform-modules-dell/debian/platform-modules-s6100.install
    new file:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/fast-reboot_plugin
    modified:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/platform_reboot_override
    modified:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/s6100_platform.sh
    new file:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/track_reboot_reason.sh
    new file:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/warm-reboot_plugin
    modified:   platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py
    modified:   platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py
    new file:   platform/broadcom/sonic-platform-modules-dell/s6100/systemd/s6100-reboot-cause.service

- How to verify it
Added the Unit Test Results.

All Test case result.txt - Updated
Secondary bios boot - test results.txt
Unit test - Last Reboot Reason - S6100.txt - Updated
environment.txt

- Description for the changelog

[DellEMC] S6100 Last Reboot Reason Thermal Support and Dependency based changes

Depends on Azure/sonic-utilities#740
DO NOT MERGE UNTIL ABOVE PR IS MERGED
Update: sonic-net/sonic-utilities#740 is merged.

- A picture of a cute animal (not mandatory but encouraged)

santhosh-kt · 2019-12-09T06:32:14Z

sonic-net/sonic-utilities#740 PR is merged. Please review the above changes.

sujinmkang · 2019-12-14T02:03:40Z

retest this please

santhosh-kt · 2019-12-16T06:42:08Z

Internal discussion is being taken place, please hold the review till further changes applied to this PR.

santhosh-kt · 2020-01-10T09:35:29Z

retest vsimage please

santhosh-kt · 2020-01-14T05:14:45Z

retest vsimage please

santhosh-kt · 2020-01-20T05:45:07Z

Added all the changes. Please continue to review the changes.

santhosh-kt · 2020-01-20T06:05:08Z

retest this please

santhosh-kt · 2020-01-20T10:26:07Z

retest broadcom please

sujinmkang · 2020-01-21T23:05:03Z

retest this please

sujinmkang · 2020-01-24T23:50:16Z

retest vsimage please

sujinmkang

Can you please double check the software reboot reason case?
It seems it's not consistently working.
Jan 25 01:01:56.749931 str-s6100-acs-5 INFO process-reboot-cause: /proc/cmdline indicates reboot type: warm-reboot
Jan 25 01:01:56.750580 str-s6100-acs-5 INFO process-reboot-cause: Previous reboot cause: Unknown software reboot

platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py

platform/broadcom/sonic-platform-modules-dell/s6100/scripts/track_reboot_reason.sh

santhosh-kt · 2020-01-27T11:38:06Z

It looks like, sonic-net/sonic-utilities#740 PR is not synced to master branch. s6100-reboot-cause.service requires this PR, that will handle warm-reboot, fast-reboot and reboot cases in 2.0 API.

Attached logs regarding the plugin - warm-reboot.txt

This sonic-net/sonic-utilities#740 PR is already picked in 201911 but not in master yet.

jleveque · 2020-01-29T05:31:19Z

@santhosh-kt: FYI, sonic-net/sonic-utilities#740 made it into the master branch today with this sonic-utilities submodule update: #4080

files/image_config/platform/rc.local

platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py

files/image_config/platform/rc.local

Updated comments for reboot-cause platform directory

jleveque · 2020-02-04T23:05:52Z

Retest vsimage please

sujinmkang · 2020-02-05T18:36:52Z

Retest vsimage please

files/image_config/platform/rc.local

sujinmkang · 2020-02-11T23:06:23Z

retest vsimage please

santhosh-kt · 2020-05-05T14:55:27Z

These changes are not ported to 201911 yet. Needed to be ported.

…atically (#21343) #### Why I did it src/sonic-utilities ``` * 899ed9b - (HEAD -> master, origin/master, origin/HEAD) Remove Multi ASIC namespace Check. (#3783) (3 days ago) [Xincun Li] * 9f1eab4 - Memory Statistics Config and Show Commands (#3575) (3 days ago) [Kanza Latif] * 595c2aa - Utilities Changes for DHCP DoS Mitigation Feature (#3301) (3 days ago) [Asad Raza] * a3d15bc - Add multi-asic support for dropconfig (#3735) (3 days ago) [HP] * 5ce06b2 - Add golden config check (#3770) (4 days ago) [Xincun Li] * 3c50dee - Fix `vnet_route_check` for active and inactive routes, add `--all` option (#3763) (9 days ago) [mramezani95] * 40ba225 - Revert "enable pfcwd for backplane ports (#3759)" (#3767) (13 days ago) [Dashuai Zhang] * 2866ccd - enable pfcwd for backplane ports (#3759) (2 weeks ago) [Dashuai Zhang] * 3abd19e - [FC] remove FC delay field (#3577) (3 weeks ago) [Stepan Blyshchak] * 11c2716 - Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. (#3700) (3 weeks ago) [Hua Liu] * 13619aa - [QOS] Skip showing unnecessary warning message (#3708) (3 weeks ago) [Vivek] * f4e6e5b - Fixing 'show ip bgp neighbor <ip>' in frr unified config mode (#3738) (3 weeks ago) [kalash-nexthop] * 9a18155 - Optimize lag_keepalive by crafting the LACPDU packet ourselves (#3170) (3 weeks ago) [Saikrishna Arcot] * a7deb8c - display proper message with proper errno for kvm. (#3750) (3 weeks ago) [Dawei Huang] * 865f196 - [Mellanox] Add new SN5640 platform and HwSKU (#3742) (4 weeks ago) [Noa Or] * 5fa8502 - [show_techsupport][pstore] Archive /var/lib/systemd/pstore info to techsupport (#3745) (4 weeks ago) [Marty Y. Lok] * 8f69d5a - sonic-utilities: WRED stats feature changes on sonic-utilities (#2807) (4 weeks ago) [Rajesh Perumal R] * 9d273f1 - Fix call for spanning-tree commands in dump script (#3723) (4 weeks ago) [DavidZagury] * 6d95d9b - Make 'show ip bgp summary' work even when we don't have any peer groups (#3739) (4 weeks ago) [kalash-nexthop] * 7f3957c - Fix ssdhealth failure on VS platform (#3743) (4 weeks ago) [Vivek] * 97b4e4b - Fix show interface counters for Chassis Packet Supervisor (#3734) (4 weeks ago) [anamehra] * 414935b - Add recover asic_id config if load golden config. (#3711) (5 weeks ago) [Xincun Li] * 973cfdc - Remove partially installer image when image install failed. (#3712) (5 weeks ago) [Hua Liu] * 97c20cc - CLI support for SmartSwitch PMON (#3271) (5 weeks ago) [rameshraghupathy] * 752c3d4 - [ACL] Display rule and table info written to APP DB (#3713) (5 weeks ago) [Vivek] * fbd0c3b - [show][interface] Add changes for show interface flap command (#3724) (5 weeks ago) [vdahiya12] * ddccabe - [show][interface] Add changes for show interface errors command (#3721) (5 weeks ago) [vdahiya12] * be870a6 - [config] Exit with non-zero when qos reload fail (#3710) (6 weeks ago) [Jianyue Wu] * ffa66e9 - Remove debug dump import by default (#3715) (6 weeks ago) [Vivek] * fc3a3cb - [ssdhealth] Check for default device before falling back to discovery (#3693) (6 weeks ago) [Vivek] * 782c33a - [yang] Enforce yang full support in full config command (#3716) (6 weeks ago) [jingwenxie] * a5b7a90 - [show][interfaces] Add proposal for show interfaces flap (#3627) (6 weeks ago) [vdahiya12] * 0083a12 - sonic-utilities: add th5 hwskus to gcu conf file (#3714) (7 weeks ago) [Chris] * 81cf04f - [Mellanox] Add Mellanox-SN5610N-C256S2, Mellanox-SN5610N-C224O8 to GCU validators (#3658) (7 weeks ago) [noaOrMlnx] * 349a101 - [db_migrator] Migrate tunnel table (#3704) (7 weeks ago) [Longxiang Lyu] * 0e327c5 - show ip interfaces: fix exception with BGP unnumbered (#3695) (8 weeks ago) [Brad House] * 7100f73 - [show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info (#3676) (8 weeks ago) [Marty Y. Lok] * 80d4698 - Delete TRSNCEIVER tables while config reload (#3680) (8 weeks ago) [noaOrMlnx] * bf6ff9f - Enable multi asic golden config YANG validation. (#3685) (8 weeks ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog

…atically (sonic-net#21343) #### Why I did it src/sonic-utilities ``` * 899ed9b - (HEAD -> master, origin/master, origin/HEAD) Remove Multi ASIC namespace Check. (sonic-net#3783) (3 days ago) [Xincun Li] * 9f1eab4 - Memory Statistics Config and Show Commands (sonic-net#3575) (3 days ago) [Kanza Latif] * 595c2aa - Utilities Changes for DHCP DoS Mitigation Feature (sonic-net#3301) (3 days ago) [Asad Raza] * a3d15bc - Add multi-asic support for dropconfig (sonic-net#3735) (3 days ago) [HP] * 5ce06b2 - Add golden config check (sonic-net#3770) (4 days ago) [Xincun Li] * 3c50dee - Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3763) (9 days ago) [mramezani95] * 40ba225 - Revert "enable pfcwd for backplane ports (sonic-net#3759)" (sonic-net#3767) (13 days ago) [Dashuai Zhang] * 2866ccd - enable pfcwd for backplane ports (sonic-net#3759) (2 weeks ago) [Dashuai Zhang] * 3abd19e - [FC] remove FC delay field (sonic-net#3577) (3 weeks ago) [Stepan Blyshchak] * 11c2716 - Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. (sonic-net#3700) (3 weeks ago) [Hua Liu] * 13619aa - [QOS] Skip showing unnecessary warning message (sonic-net#3708) (3 weeks ago) [Vivek] * f4e6e5b - Fixing 'show ip bgp neighbor <ip>' in frr unified config mode (sonic-net#3738) (3 weeks ago) [kalash-nexthop] * 9a18155 - Optimize lag_keepalive by crafting the LACPDU packet ourselves (sonic-net#3170) (3 weeks ago) [Saikrishna Arcot] * a7deb8c - display proper message with proper errno for kvm. (sonic-net#3750) (3 weeks ago) [Dawei Huang] * 865f196 - [Mellanox] Add new SN5640 platform and HwSKU (sonic-net#3742) (4 weeks ago) [Noa Or] * 5fa8502 - [show_techsupport][pstore] Archive /var/lib/systemd/pstore info to techsupport (sonic-net#3745) (4 weeks ago) [Marty Y. Lok] * 8f69d5a - sonic-utilities: WRED stats feature changes on sonic-utilities (sonic-net#2807) (4 weeks ago) [Rajesh Perumal R] * 9d273f1 - Fix call for spanning-tree commands in dump script (sonic-net#3723) (4 weeks ago) [DavidZagury] * 6d95d9b - Make 'show ip bgp summary' work even when we don't have any peer groups (sonic-net#3739) (4 weeks ago) [kalash-nexthop] * 7f3957c - Fix ssdhealth failure on VS platform (sonic-net#3743) (4 weeks ago) [Vivek] * 97b4e4b - Fix show interface counters for Chassis Packet Supervisor (sonic-net#3734) (4 weeks ago) [anamehra] * 414935b - Add recover asic_id config if load golden config. (sonic-net#3711) (5 weeks ago) [Xincun Li] * 973cfdc - Remove partially installer image when image install failed. (sonic-net#3712) (5 weeks ago) [Hua Liu] * 97c20cc - CLI support for SmartSwitch PMON (sonic-net#3271) (5 weeks ago) [rameshraghupathy] * 752c3d4 - [ACL] Display rule and table info written to APP DB (sonic-net#3713) (5 weeks ago) [Vivek] * fbd0c3b - [show][interface] Add changes for show interface flap command (sonic-net#3724) (5 weeks ago) [vdahiya12] * ddccabe - [show][interface] Add changes for show interface errors command (sonic-net#3721) (5 weeks ago) [vdahiya12] * be870a6 - [config] Exit with non-zero when qos reload fail (sonic-net#3710) (6 weeks ago) [Jianyue Wu] * ffa66e9 - Remove debug dump import by default (sonic-net#3715) (6 weeks ago) [Vivek] * fc3a3cb - [ssdhealth] Check for default device before falling back to discovery (sonic-net#3693) (6 weeks ago) [Vivek] * 782c33a - [yang] Enforce yang full support in full config command (sonic-net#3716) (6 weeks ago) [jingwenxie] * a5b7a90 - [show][interfaces] Add proposal for show interfaces flap (sonic-net#3627) (6 weeks ago) [vdahiya12] * 0083a12 - sonic-utilities: add th5 hwskus to gcu conf file (sonic-net#3714) (7 weeks ago) [Chris] * 81cf04f - [Mellanox] Add Mellanox-SN5610N-C256S2, Mellanox-SN5610N-C224O8 to GCU validators (sonic-net#3658) (7 weeks ago) [noaOrMlnx] * 349a101 - [db_migrator] Migrate tunnel table (sonic-net#3704) (7 weeks ago) [Longxiang Lyu] * 0e327c5 - show ip interfaces: fix exception with BGP unnumbered (sonic-net#3695) (8 weeks ago) [Brad House] * 7100f73 - [show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info (sonic-net#3676) (8 weeks ago) [Marty Y. Lok] * 80d4698 - Delete TRSNCEIVER tables while config reload (sonic-net#3680) (8 weeks ago) [noaOrMlnx] * bf6ff9f - Enable multi asic golden config YANG validation. (sonic-net#3685) (8 weeks ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog

santhosh-kt added 2 commits November 15, 2019 18:35

[DellEMC] S6100 Last Reboot Reason Thermal Support

889d2f6

[DellEMC]S6100 Last Reboot Reason Thermal

05394e6

This was referenced Nov 22, 2019

Platform 2.0 Infra and Reboot Reason support for Dell Platforms #3307

Closed

[DELL] S6100, Z9100 Last Reboot Reason Watchdog, Thermal Support #3479

Closed

[201811][DELL] S6100, Z9100 Last Reboot Reason Watchdog, Thermal Support #3520

Closed

code refactoring and adding unknown software reboot support

6425bb3

santhosh-kt and others added 2 commits January 9, 2020 20:55

Added newer BIOS based changes, dependency changes

858c4c3

Merge branch 'master' into sonic-s6100-lrr

f60120c

lguohan assigned sujinmkang Jan 21, 2020

sujinmkang reviewed Jan 25, 2020

View reviewed changes

platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py Show resolved Hide resolved

platform/broadcom/sonic-platform-modules-dell/s6100/scripts/track_reboot_reason.sh Outdated Show resolved Hide resolved

jleveque suggested changes Jan 29, 2020

View reviewed changes

files/image_config/platform/rc.local Outdated Show resolved Hide resolved

platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py Show resolved Hide resolved

Correcting the directory path in the comment

7eeb610

jleveque suggested changes Jan 29, 2020

View reviewed changes

files/image_config/platform/rc.local Outdated Show resolved Hide resolved

Updated comments for reboot-cause platform

be2de77

Updated comments for reboot-cause platform directory

sujinmkang previously approved these changes Feb 5, 2020

View reviewed changes

santhosh-kt requested a review from jleveque February 7, 2020 10:28

jleveque suggested changes Feb 7, 2020

View reviewed changes

files/image_config/platform/rc.local Outdated Show resolved Hide resolved

Non-alignment spaces resolved

f3ad108

santhosh-kt dismissed sujinmkang’s stale review via f3ad108 February 10, 2020 06:10

sujinmkang approved these changes Feb 18, 2020

View reviewed changes

sujinmkang requested a review from jleveque February 18, 2020 01:14

jleveque approved these changes Feb 18, 2020

View reviewed changes

jleveque added Enhancement ➕ Platform: DellEMC labels Feb 18, 2020

jleveque merged commit 2626565 into sonic-net:master Feb 18, 2020

stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Feb 26, 2020

[DellEMC] S6100 Last Reboot Reason Thermal Support (sonic-net#3767)

0f7fe89

jleveque added the Request for 201911 Branch label May 5, 2020

rlhui pushed a commit that referenced this pull request May 10, 2020

[DellEMC] S6100 Last Reboot Reason Thermal Support (#3767)

1e3df47

rlhui added the Included in 201911 Branch label May 10, 2020

[DellEMC] S6100 Last Reboot Reason Thermal Support #3767

[DellEMC] S6100 Last Reboot Reason Thermal Support #3767

Uh oh!

Conversation

santhosh-kt commented Nov 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

santhosh-kt commented Dec 9, 2019

Uh oh!

sujinmkang commented Dec 14, 2019

Uh oh!

santhosh-kt commented Dec 16, 2019

Uh oh!

santhosh-kt commented Jan 10, 2020

Uh oh!

santhosh-kt commented Jan 14, 2020

Uh oh!

santhosh-kt commented Jan 20, 2020

Uh oh!

santhosh-kt commented Jan 20, 2020

Uh oh!

santhosh-kt commented Jan 20, 2020

Uh oh!

sujinmkang commented Jan 21, 2020

Uh oh!

sujinmkang commented Jan 24, 2020

Uh oh!

sujinmkang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

santhosh-kt commented Jan 27, 2020

Uh oh!

jleveque commented Jan 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jleveque commented Feb 4, 2020

Uh oh!

sujinmkang commented Feb 5, 2020

Uh oh!

Uh oh!

sujinmkang commented Feb 11, 2020

Uh oh!

santhosh-kt commented May 5, 2020

Uh oh!

Uh oh!

santhosh-kt commented Nov 15, 2019 •

edited

Loading