Skip to content

Commit 899ed9b

Browse files
Remove Multi ASIC namespace Check. (sonic-net#3783)
* Remove Multi ASIC namespace Check. * fix ut.
1 parent 9f1eab4 commit 899ed9b

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

config/main.py

-8
Original file line numberDiff line numberDiff line change
@@ -1397,14 +1397,6 @@ def config_file_yang_validation(filename):
13971397
if not isinstance(config, dict):
13981398
return False
13991399

1400-
# If the device is multi-ASIC, check if all required namespaces exist
1401-
if multi_asic.is_multi_asic():
1402-
required_namespaces = [HOST_NAMESPACE, *multi_asic.get_namespace_list()]
1403-
for ns in required_namespaces:
1404-
asic_name = HOST_NAMESPACE if ns == DEFAULT_NAMESPACE else ns
1405-
if asic_name not in config:
1406-
return False
1407-
14081400
sy = sonic_yang.SonicYang(YANG_DIR)
14091401
sy.loadYangModel()
14101402
asic_list = [HOST_NAMESPACE]

tests/config_test.py

-9
Original file line numberDiff line numberDiff line change
@@ -1286,15 +1286,6 @@ def test_config_file_yang_validation(self):
12861286
mock_read_json_file.assert_called_once_with('dummy_file.json')
12871287
mock_load_yang_model.assert_not_called()
12881288

1289-
# Test with missing namespaces in multi-ASIC config
1290-
with mock.patch('config.main.read_json_file', return_value={'localhost': {}}) as mock_read_json_file:
1291-
with mock.patch('config.main.multi_asic.is_multi_asic', return_value=True):
1292-
with mock.patch('config.main.multi_asic.get_namespace_list', return_value=['asic0', 'asic1']):
1293-
with mock.patch('config.main.sonic_yang.SonicYang.loadYangModel') as mock_load_yang_model:
1294-
assert not config_file_yang_validation('dummy_file.json')
1295-
mock_read_json_file.assert_called_once_with('dummy_file.json')
1296-
mock_load_yang_model.assert_not_called()
1297-
12981289
# Test with valid config
12991290
valid_config = {
13001291
'DEVICE_METADATA': {

0 commit comments

Comments
 (0)