[rule based autotagging] Add Delete Rule API Logic #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruai0511
force-pushed
the
get-rule-api-PR
branch
3 times, most recently
from
1e1b71b to
9e396a5
Compare
There was a problem hiding this comment.
This rule can be replaced with AcknowledgedResponse
There was a problem hiding this comment.
We will not need this once we remove the source class as commented above to use AcknowledgedResponse
|
We would also need to add rest based yaml tests once create API pr is merged |
ruai0511
force-pushed
the
get-rule-api-PR
branch
6 times, most recently
from
d9d1387 to
58cac7a
Compare
kaushalmahi12
force-pushed
the
get-rule-api-PR
branch
from
26712c4 to
e7f544e
Compare
ruai0511
force-pushed
the
get-rule-api-PR
branch
from
e2200ce to
402bf1a
Compare
kaushalmahi12
force-pushed
the
get-rule-api-PR
branch
from
196748e to
0b819c4
Compare
…roject#17951) Signed-off-by: Chloe Gao <[email protected]>
kaushalmahi12
force-pushed
the
get-rule-api-PR
branch
from
0b819c4 to
37ac465
Compare
* visit the subquery Signed-off-by: Varun Jain <[email protected]> * Fix visit method of constant score query and function score query to iterate recursively Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]>
…ject#17532) Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
…earch-project#17682) * Removed includeDiscoveryNodes from BaseNodesRequest Signed-off-by: Manik Garg <[email protected]>
…/test/framework (opensearch-project#17922) * Bump com.github.spotbugs:spotbugs-annotations in /test/framework Bumps [com.github.spotbugs:spotbugs-annotations](https://github.com/spotbugs/spotbugs) from 4.9.0 to 4.9.3. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](spotbugs/spotbugs@4.9.0...4.9.3) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs-annotations dependency-version: 4.9.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ository-azure (opensearch-project#17925) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.18.0 to 1.20.0. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.18.0...1.20.0) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-version: 1.20.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> * Fix test failure by modifying the error message Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Binlong Gao <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Binlong Gao <[email protected]>
…s/hdfs-fixture (opensearch-project#17923) * Bump com.google.code.gson:gson in /test/fixtures/hdfs-fixture Bumps [com.google.code.gson:gson](https://github.com/google/gson) from 2.12.1 to 2.13.0. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/main/CHANGELOG.md) - [Commits](google/gson@gson-parent-2.12.1...gson-parent-2.13.0) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-version: 2.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Add change log Remove duplicate line Signed-off-by: 10000-ki <[email protected]>
We'll need to come back and update this after the 3.0 release but for now we should not be enforcing breaking changes against 3.0. Signed-off-by: Andrew Ross <[email protected]>
…cessController.doPrivileged (opensearch-project#17894) Signed-off-by: Craig Perkins <[email protected]>
…#18034) Signed-off-by: Andrew Ross <[email protected]>
…nsearch.plugin.transport.grpc (opensearch-project#18031) Signed-off-by: Karen Xu <[email protected]>
…roject#18040) We've seen multiple failures where the 3 second timeout was breached. This happens in the test setup of many different tests so multiple individual test failures have been reported. Also replace deprecated method in Kafka API and simplify a couple other code paths. Signed-off-by: Andrew Ross <[email protected]>
ruai0511
force-pushed
the
get-rule-api-PR
branch
5 times, most recently
from
f1f2108 to
d6b3e79
Compare
…h-project#18041) Signed-off-by: Andriy Redko <[email protected]>
…project#17370) Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
…7336) * add get rule api logic Signed-off-by: Ruirui Zhang <[email protected]> * modify based on comments Signed-off-by: Ruirui Zhang <[email protected]> * rebase from main after the schema merged Signed-off-by: Ruirui Zhang <[email protected]> * modify based on comments Signed-off-by: Ruirui Zhang <[email protected]> * extract common logics to libs Signed-off-by: Ruirui Zhang <[email protected]> * Add javadocs for libs Signed-off-by: Ruirui Zhang <[email protected]> * modify based on comments Signed-off-by: Ruirui Zhang <[email protected]> * modify based on comments Signed-off-by: Ruirui Zhang <[email protected]> * modify based on comments Signed-off-by: Ruirui Zhang <[email protected]> * correct UT Signed-off-by: Ruirui Zhang <[email protected]> * modify based on comments Signed-off-by: Ruirui Zhang <[email protected]> r * refactor code and fix ut Signed-off-by: Kaushal Kumar <[email protected]> * remove commented code Signed-off-by: Kaushal Kumar <[email protected]> * address comments Signed-off-by: Kaushal Kumar <[email protected]> * change method name Signed-off-by: Kaushal Kumar <[email protected]> * fix merge conflicts Signed-off-by: Kaushal Kumar <[email protected]> * rename queryGroup to workloadGroup Signed-off-by: Kaushal Kumar <[email protected]> * add guice binding related changes Signed-off-by: Kaushal Kumar <[email protected]> * refactor code to create a generic rule framework structure Signed-off-by: Kaushal Kumar <[email protected]> * fix javadoc Signed-off-by: Ruirui Zhang <[email protected]> * fix UT Signed-off-by: Ruirui Zhang <[email protected]> * restructure tests Signed-off-by: Kaushal Kumar <[email protected]> * rebase with mainline Signed-off-by: Kaushal Kumar <[email protected]> * fix gradlew file Signed-off-by: Ruirui Zhang <[email protected]> * add UT Signed-off-by: Ruirui Zhang <[email protected]> * add action UTs Signed-off-by: Kaushal Kumar <[email protected]> * correct the comment Signed-off-by: Kaushal Kumar <[email protected]> * add more UT Signed-off-by: Ruirui Zhang <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]> Co-authored-by: Kaushal Kumar <[email protected]>
…quests for update_by_query and reindex (opensearch-project#18003) * Fix ingest pipeline cannot be executed when retry the failed index requests for update_by_query API and reindex API Signed-off-by: Binlong Gao <[email protected]> * Modify changelog Signed-off-by: Binlong Gao <[email protected]> * Optimize some code Signed-off-by: Binlong Gao <[email protected]> * Fix precommit failure Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: Binlong Gao <[email protected]>
opensearch-project#17977) * emit lag metric for pull-based ingestion poller Signed-off-by: Yupeng Fu <[email protected]> * changelog Signed-off-by: Yupeng Fu <[email protected]> * fix ut Signed-off-by: Yupeng Fu <[email protected]> --------- Signed-off-by: Yupeng Fu <[email protected]>
…er (opensearch-project#18027) Signed-off-by: Sandeep Kumawat <[email protected]>
…ch-project#18017) Signed-off-by: Prudhvi Godithi <[email protected]>
…ject#17978) * Enable concurrent_segment_search auto mode by default Signed-off-by: Vikasht34 <[email protected]> * Make Default Slice count to 1 for Non-Concurrent Path Signed-off-by: Vikasht34 <[email protected]> * Add tolerance to matrix_stats agg correlation value assertion The correlation metric could be different for different document distribution across shards, or slices. slice1(doc1,doc2), slice2(doc3,doc4,doc5) could give different correlation from slice1(doc1,doc2,doc3), slice2(doc4,doc5) The tolerance followed here is 0.000000000000001 Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: Vikasht34 <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
…ct#18018) Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
I observed a failure in local testing due to this issue. The code previously was assuming it would observe a yellow cluster after restarting a node, but the node could restart and re-join the cluster before the assertion causing a failure. The `onNodeStopped` callback lets the test execute code before the node is restarted, so it should fix this issue. Signed-off-by: Andrew Ross <[email protected]>
…opensearch-project#17711) Signed-off-by: Manik Garg <[email protected]>
Signed-off-by: Shreyansh Ray <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Lindsay-00
force-pushed
the
delete-rule-api-PR
branch
from
63c1854 to
8999a60
Compare
Signed-off-by: Ruirui Zhang <[email protected]> rebase Signed-off-by: Lingxi Chen <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]> rebase Signed-off-by: Lingxi Chen <[email protected]>
Signed-off-by: Ruirui Zhang <[email protected]> rebase Signed-off-by: Lingxi Chen <[email protected]>
rebase Signed-off-by: Lingxi Chen <[email protected]>
Signed-off-by: Lingxi Chen <[email protected]>
Signed-off-by: Lingxi Chen <[email protected]>
Lindsay-00
force-pushed
the
delete-rule-api-PR
branch
from
eae3370 to
2a03a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the Delete Rule API Logic.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.