-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Visit the subquery builder recursively #17953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visit the subquery builder recursively #17953
Conversation
Signed-off-by: Varun Jain <[email protected]>
❕ Gradle check result for cc79a23: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17953 +/- ##
============================================
- Coverage 72.57% 72.44% -0.14%
+ Complexity 67066 66969 -97
============================================
Files 5470 5473 +3
Lines 309697 309816 +119
Branches 45045 45062 +17
============================================
- Hits 224776 224459 -317
- Misses 66602 67003 +401
- Partials 18319 18354 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…iterate recursively Signed-off-by: Varun Jain <[email protected]>
@msfroh Can you review this PR once as you have the most context on this one. There are few bugs and it resolves all of them. |
❌ Gradle check result for 2087542: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2087542: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2087542: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2087542: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2087542: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Check is failing due to flaky tests. @getsaurabh02 how can we merge this PR? |
Hey @vibrantvarun, |
❌ Gradle check result for 2087542: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
* visit the subquery Signed-off-by: Varun Jain <[email protected]> * Fix visit method of constant score query and function score query to iterate recursively Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit b9046eb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* visit the subquery * Fix visit method of constant score query and function score query to iterate recursively --------- (cherry picked from commit b9046eb) Signed-off-by: Varun Jain <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* visit the subquery Signed-off-by: Varun Jain <[email protected]> * Fix visit method of constant score query and function score query to iterate recursively Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]> (cherry picked from commit b9046eb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* visit the subquery Signed-off-by: Varun Jain <[email protected]> * Fix visit method of constant score query and function score query to iterate recursively Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]> Signed-off-by: Tanishq Ranjan <[email protected]>
* visit the subquery * Fix visit method of constant score query and function score query to iterate recursively --------- (cherry picked from commit b9046eb) Signed-off-by: Varun Jain <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ensearch-project#18063) * visit the subquery * Fix visit method of constant score query and function score query to iterate recursively --------- (cherry picked from commit b9046eb) Signed-off-by: Varun Jain <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Prudhvi Godithi <[email protected]>
* visit the subquery Signed-off-by: Varun Jain <[email protected]> * Fix visit method of constant score query and function score query to iterate recursively Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
* visit the subquery Signed-off-by: Varun Jain <[email protected]> * Fix visit method of constant score query and function score query to iterate recursively Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Description
This PR contains changes to iterate subquery builder recursively.
Related Issues
17829
1269
1251
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.