Skip to content

Visit the subquery builder recursively #17953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vibrantvarun
Copy link
Member

@vibrantvarun vibrantvarun commented Apr 15, 2025

Description

This PR contains changes to iterate subquery builder recursively.

Related Issues

17829
1269
1251

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Varun Jain <[email protected]>
Copy link
Contributor

❕ Gradle check result for cc79a23: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.44%. Comparing base (5799fe7) to head (2087542).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
...nsearch/index/query/ConstantScoreQueryBuilder.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17953      +/-   ##
============================================
- Coverage     72.57%   72.44%   -0.14%     
+ Complexity    67066    66969      -97     
============================================
  Files          5470     5473       +3     
  Lines        309697   309816     +119     
  Branches      45045    45062      +17     
============================================
- Hits         224776   224459     -317     
- Misses        66602    67003     +401     
- Partials      18319    18354      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vibrantvarun
Copy link
Member Author

@msfroh Can you review this PR once as you have the most context on this one. There are few bugs and it resolves all of them.

@vibrantvarun vibrantvarun changed the title Visit the subquery builder reursively Visit the subquery builder recursively Apr 15, 2025
Copy link
Contributor

❌ Gradle check result for 2087542: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2087542: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2087542: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2087542: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2087542: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vibrantvarun
Copy link
Member Author

Check is failing due to flaky tests. @getsaurabh02 how can we merge this PR?

@prudhvigodithi
Copy link
Member

Hey @vibrantvarun,
Here is the summary of all the flaky failures related to this PR. I have re-triggered the Gradle check, but FYI there are some mechanisms in progress #17939 #17974 to deal with the flaky tests. With green Gradle check maintainers should be able to merge the PR.

Copy link
Contributor

❌ Gradle check result for 2087542: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 2087542: SUCCESS

@jainankitk jainankitk added the backport 2.x Backport to 2.x branch label Apr 22, 2025
@jainankitk jainankitk merged commit b9046eb into opensearch-project:main Apr 22, 2025
64 of 66 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 22, 2025
* visit the subquery

Signed-off-by: Varun Jain <[email protected]>

* Fix visit method of constant score query and function score query to iterate recursively

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit b9046eb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jainankitk pushed a commit that referenced this pull request Apr 22, 2025
* visit the subquery



* Fix visit method of constant score query and function score query to iterate recursively



---------


(cherry picked from commit b9046eb)

Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 23, 2025
* visit the subquery

Signed-off-by: Varun Jain <[email protected]>

* Fix visit method of constant score query and function score query to iterate recursively

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit b9046eb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
x-INFiN1TY-x pushed a commit to x-INFiN1TY-x/OpenSearch_Local that referenced this pull request Apr 24, 2025
* visit the subquery

Signed-off-by: Varun Jain <[email protected]>

* Fix visit method of constant score query and function score query to iterate recursively

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Tanishq Ranjan <[email protected]>
jainankitk pushed a commit that referenced this pull request Apr 24, 2025
* visit the subquery



* Fix visit method of constant score query and function score query to iterate recursively



---------


(cherry picked from commit b9046eb)

Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi pushed a commit to prudhvigodithi/OpenSearch that referenced this pull request May 6, 2025
…ensearch-project#18063)

* visit the subquery

* Fix visit method of constant score query and function score query to iterate recursively

---------

(cherry picked from commit b9046eb)

Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Prudhvi Godithi <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
* visit the subquery

Signed-off-by: Varun Jain <[email protected]>

* Fix visit method of constant score query and function score query to iterate recursively

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
* visit the subquery

Signed-off-by: Varun Jain <[email protected]>

* Fix visit method of constant score query and function score query to iterate recursively

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants