-
Notifications
You must be signed in to change notification settings - Fork 2k
Enable concurrent_segment_search auto mode by default #17978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Gradle check result for 8633e9f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
{"run-benchmark-test": "id_4"} |
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2882/ . Final results will be published once the job is completed. |
Signed-off-by: bowenlan-amzn <[email protected]>
{"run-benchmark-test": "id_6"} |
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/2959/ . Final results will be published once the job is completed. |
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/2959/
|
❌ Gradle check result for 932fa0f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@github-actions commented on Apr 23, 2025, 2:49 PM PDT:
Flaky test #16576 |
Signed-off-by: Vikasht34 <[email protected]>
❌ Gradle check result for 1925434: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-3.0 3.0
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-3.0
# Create a new branch
git switch --create backport/backport-17978-to-3.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e7ed33f60d275c3482ee7b82007ff8bdb00dbe90
# Push it to GitHub
git push --set-upstream origin backport/backport-17978-to-3.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-3.0 Then, create a pull request where the |
…ject#17978) * Enable concurrent_segment_search auto mode by default Signed-off-by: Vikasht34 <[email protected]> * Make Default Slice count to 1 for Non-Concurrent Path Signed-off-by: Vikasht34 <[email protected]> * Add tolerance to matrix_stats agg correlation value assertion The correlation metric could be different for different document distribution across shards, or slices. slice1(doc1,doc2), slice2(doc3,doc4,doc5) could give different correlation from slice1(doc1,doc2,doc3), slice2(doc4,doc5) The tolerance followed here is 0.000000000000001 Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: Vikasht34 <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]>
* Enable concurrent_segment_search auto mode by default * Make Default Slice count to 1 for Non-Concurrent Path * Add tolerance to matrix_stats agg correlation value assertion The correlation metric could be different for different document distribution across shards, or slices. slice1(doc1,doc2), slice2(doc3,doc4,doc5) could give different correlation from slice1(doc1,doc2,doc3), slice2(doc4,doc5) The tolerance followed here is 0.000000000000001 --------- Signed-off-by: Vikasht34 <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: Vikasht34 <[email protected]>
Description
Related Issues
Resolves #17981
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.