fix UT

Signed-off-by: Ruirui Zhang <[email protected]>

Author: ruai0511

modules/autotagging-commons/common/src/test/java/org/opensearch/rule/service/IndexStoredRulePersistenceServiceTests.java

@@ -26,6 +26,7 @@
 import org.opensearch.rule.RulePersistenceService;
 import org.opensearch.rule.RuleQueryMapper;
 import org.opensearch.rule.autotagging.Rule;
+import org.opensearch.rule.utils.RuleTestUtils;
 import org.opensearch.search.SearchHit;
 import org.opensearch.search.SearchHits;
 import org.opensearch.test.OpenSearchTestCase;
@@ -90,6 +91,7 @@ public void testGetRuleByIdSuccess() {
             return null;
         }).when(searchRequestBuilder).execute(any(ActionListener.class));
 
+        when(getRuleRequest.getFeatureType()).thenReturn(RuleTestUtils.MockRuleFeatureType.INSTANCE);
         rulePersistenceService.getRule(getRuleRequest, listener);
 
         ArgumentCaptor<GetRuleResponse> responseCaptor = ArgumentCaptor.forClass(GetRuleResponse.class);
@@ -132,6 +134,7 @@ public void testGetRuleByIdNotFound() {
             return null;
         }).when(searchRequestBuilder).execute(any(ActionListener.class));
 
+        when(getRuleRequest.getFeatureType()).thenReturn(RuleTestUtils.MockRuleFeatureType.INSTANCE);
         rulePersistenceService.getRule(getRuleRequest, listener);
 
         ArgumentCaptor<Exception> exceptionCaptor = ArgumentCaptor.forClass(Exception.class);

modules/autotagging-commons/common/src/test/java/org/opensearch/rule/utils/RuleTestUtils.java

@@ -70,7 +70,6 @@ public enum MockRuleAttributes implements Attribute {
         MOCK_RULE_ATTRIBUTE_ONE(ATTRIBUTE_VALUE_ONE),
         MOCK_RULE_ATTRIBUTE_TWO(ATTRIBUTE_VALUE_TWO),
         INVALID_ATTRIBUTE(RuleTestUtils.INVALID_ATTRIBUTE);
-        ;
 
         private final String name;
 

modules/autotagging-commons/src/test/java/org/opensearch/rule/InMemoryRuleProcessingServiceTests.java

@@ -8,15 +8,14 @@
 
 package org.opensearch.rule;
 
-import org.opensearch.core.common.io.stream.StreamOutput;
 import org.opensearch.rule.attribute_extractor.AttributeExtractor;
 import org.opensearch.rule.autotagging.Attribute;
+import org.opensearch.rule.autotagging.AutoTaggingRegistry;
 import org.opensearch.rule.autotagging.FeatureType;
 import org.opensearch.rule.autotagging.Rule;
 import org.opensearch.rule.storage.DefaultAttributeValueStore;
 import org.opensearch.test.OpenSearchTestCase;
 
-import java.io.IOException;
 import java.util.List;
 import java.util.Map;
 import java.util.Optional;
@@ -124,9 +123,13 @@ public Iterable<String> extract() {
     public enum WLMFeatureType implements FeatureType {
         WLM;
 
+        static {
+            WLM.registerFeatureType();
+        }
+
         @Override
         public String getName() {
-            return "";
+            return "wlm";
         }
 
         @Override
@@ -135,7 +138,9 @@ public Map<String, Attribute> getAllowedAttributesRegistry() {
         }
 
         @Override
-        public void registerFeatureType() {}
+        public void registerFeatureType() {
+            AutoTaggingRegistry.registerFeatureType(WLM);
+        }
     }
 
     public enum TestAttribute implements Attribute {
@@ -155,8 +160,5 @@ public String getName() {
 
         @Override
         public void validateAttribute() {}
-
-        @Override
-        public void writeTo(StreamOutput out) throws IOException {}
     }
 }

modules/autotagging-commons/src/test/java/org/opensearch/rule/action/GetRuleResponseTests.java

@@ -109,17 +109,17 @@ public void testToXContentGetSingleRule() throws IOException {
         String expected = "{\n"
             + "  \"rules\" : [\n"
             + "    {\n"
-            + "      \"_id\" : \"AgfUO5Ja9yfvhdONlYi3TQ==\",\n"
+            + "      \"_id\" : \"id_1\",\n"
             + "      \"description\" : \"description_1\",\n"
-            + "      \"mock_attribute_one\" : [\n"
+            + "      \"test_attribute\" : [\n"
             + "        \"mock_attribute_one\"\n"
             + "      ],\n"
-            + "      \"mock_feature_type\" : \"feature_value_one\",\n"
+            + "      \"wlm\" : \"feature_value_one\",\n"
             + "      \"updated_at\" : \"2024-01-26T08:58:57.558Z\"\n"
             + "    }\n"
             + "  ],\n"
             + "  \"search_after\" : [\n"
-            + "    \"search_after_id\"\n"
+            + "    \"search_after\"\n"
             + "  ]\n"
             + "}";
         assertEquals(expected, actual);