feat(streaming): introduce sort operator based on watermark #6085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 2275 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1080 | 2 | 1193 | 0 |
Click to see the invalid file list
- src/stream/src/executor/sort.rs
- src/stream/src/from_proto/sort.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Please fix clippy lints |
Codecov Report
@@ Coverage Diff @@
## main #6085 +/- ##
==========================================
- Coverage 74.36% 74.20% -0.16%
==========================================
Files 935 939 +4
Lines 150096 150811 +715
==========================================
+ Hits 111612 111915 +303
- Misses 38484 38896 +412
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
BugenZhao
reviewed
Oct 31, 2022
|
You may need also to update the generated proto for the dashboard. |
fuyufjh
approved these changes
Nov 3, 2022
Comment on lines
+268
to
+271
| for (owned_vnode, _) in newly_owned_vnodes | ||
| .iter() | ||
| .filter(|is_set| *is_set) | ||
| .enumerate() |
There was a problem hiding this comment.
May add a new function on Bitmap to iterate on all set bits.
There was a problem hiding this comment.
I have added this function in the WatermarkFilter branch. I'll modify this to use the function in my PR.
yuhao-su
approved these changes
Nov 3, 2022
This was referenced Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Summarize your change
Introduce sort operator, which consumes unordered input and outputs ordered data based on watermark.
How does this PR work? Need a brief introduction for the changed logic
View implementation design doc for basic logics. There's also detailed comments within the code in this PR.
Describe any limitations of the current code
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
StreamSortplan node #6070Sortoperator #6060