Skip to content

Sort Operator should delay irrelevant watermarks #6297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
soundOfDestiny opened this issue Nov 10, 2022 · 1 comment
Closed

Sort Operator should delay irrelevant watermarks #6297

soundOfDestiny opened this issue Nov 10, 2022 · 1 comment
Assignees
@soundOfDestiny
Labels
type/bug Type: Bug. Only for issues.
Milestone
release-1.1

Comments

@soundOfDestiny
Copy link
Contributor

Describe the bug

Sort Operator should have delayed irrelevant watermarks, or it may emit buffered chunks that is earlier than the watermark which it has emitted.

To Reproduce

No response

Expected behavior

Sort Operator should not emit irrelevant watermarks until corresponding chunks are all emitted.

Additional context

#6085
@soundOfDestiny soundOfDestiny added the type/bug Type: Bug. Only for issues. label Nov 10, 2022
@github-actions github-actions bot added this to the release-0.1.14 milestone Nov 10, 2022
soundOfDestiny pushed a commit that referenced this issue Nov 10, 2022
fix(sort operator): Sort Operator should delay irrelevant watermarks (c…
3b756fa 
…lose #6297)
@soundOfDestiny soundOfDestiny mentioned this issue Nov 10, 2022
Closed
3 tasks
@soundOfDestiny soundOfDestiny self-assigned this Nov 10, 2022
soundOfDestiny pushed a commit that referenced this issue Nov 11, 2022
fix(sort operator): Sort Operator should delay irrelevant watermarks (c…
5695b03 
…lose #6297)
soundOfDestiny pushed a commit that referenced this issue Nov 11, 2022
fix(sort operator): Sort Operator should delay irrelevant watermarks (c…
86bc78d 
…lose #6297)
soundOfDestiny pushed a commit that referenced this issue Nov 11, 2022
fix(sort operator): Sort Operator should delay irrelevant watermarks (c…
d7b2ba1 
…lose #6297)
@soundOfDestiny
Copy link
Contributor Author

closed because sort_v0 is unused now. It has been replaced with sort by RC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soundOfDestiny soundOfDestiny

Labels
type/bug Type: Bug. Only for issues.
Projects
None yet
Milestone
release-1.1
Development

Successfully merging a pull request may close this issue.

fix(sort operator): Sort Operator should delay irrelevant watermarks … risingwavelabs/risingwave
2 participants
@fuyufjh @soundOfDestiny