Skip to content

fix(sort operator): enumerate() should be before filter() #6310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

soundOfDestiny
Copy link
Contributor

@soundOfDestiny soundOfDestiny commented Nov 11, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

enumerate() should be before filter()

Checklist

  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#6085

@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #6310 (f4ec707) into main (daf3ea3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6310   +/-   ##
=======================================
  Coverage   74.34%   74.34%           
=======================================
  Files         953      953           
  Lines      154348   154348           
=======================================
  Hits       114754   114754           
  Misses      39594    39594           
Flag Coverage Δ
rust 74.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/sort.rs 88.57% <100.00%> (ø)
src/stream/src/executor/aggregation/minput.rs 96.39% <0.00%> (-0.11%) ⬇️
src/common/src/types/ordered_float.rs 33.00% <0.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct 🤔. PTAL @xx01cyx

@mergify mergify bot merged commit 84c7aa9 into main Nov 11, 2022
@mergify mergify bot deleted the zl_fixsort2 branch November 11, 2022 03:41
@BugenZhao
Copy link
Member

@yuhao-su has extracted a method for this. How about using that?

@soundOfDestiny
Copy link
Contributor Author

@yuhao-su has extracted a method for this. How about using that?

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants