-
Notifications
You must be signed in to change notification settings - Fork 640
style(batch): rename OrderByExecutor to SortExecutor #6100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: TennyZhuang <[email protected]>
@skyzh PTAL the changes in dashboard, I regenerated plans, but seems it's not up-to-date before the PR. |
Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #6100 +/- ##
==========================================
- Coverage 74.71% 74.70% -0.01%
==========================================
Files 933 933
Lines 149011 149010 -1
==========================================
- Hits 111328 111315 -13
- Misses 37683 37695 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. The large stub code is expected.
Seems dashboard is broken |
Column property is removed some days before 😭 |
Signed-off-by: TennyZhuang [email protected]
What's changed and what's your intention?
SortExecutor
is a better name.And keep consistent with StreamSort. #6085
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)