Skip to content

style(batch): rename OrderByExecutor to SortExecutor #6100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 29, 2022

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Oct 28, 2022

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

SortExecutor is a better name.

And keep consistent with StreamSort. #6085

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/style Type: Coding style. label Oct 28, 2022
@TennyZhuang
Copy link
Contributor Author

@skyzh PTAL the changes in dashboard, I regenerated plans, but seems it's not up-to-date before the PR.

Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #6100 (d0c0a90) into main (50b1ad1) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #6100      +/-   ##
==========================================
- Coverage   74.71%   74.70%   -0.01%     
==========================================
  Files         933      933              
  Lines      149011   149010       -1     
==========================================
- Hits       111328   111315      -13     
- Misses      37683    37695      +12     
Flag Coverage Δ
rust 74.70% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 72.30% <ø> (ø)
src/frontend/src/optimizer/plan_node/batch_sort.rs 75.00% <0.00%> (ø)
src/batch/src/executor/order_by.rs 95.32% <82.35%> (+0.17%) ⬆️
src/batch/src/executor/join/lookup_join.rs 58.05% <100.00%> (ø)
src/batch/src/executor/group_top_n.rs 68.07% <0.00%> (-6.63%) ⬇️
src/batch/src/task/task_execution.rs 50.29% <0.00%> (-0.60%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. The large stub code is expected.

@TennyZhuang
Copy link
Contributor Author

Looks great. The large stub code is expected.

Looks great. The large stub code is expected.

Seems dashboard is broken

@skyzh
Copy link
Contributor

skyzh commented Oct 28, 2022

Column property is removed some days before 😭

@mergify mergify bot merged commit 4c354d7 into main Oct 29, 2022
@mergify mergify bot deleted the style/rename-to-sort-executor branch October 29, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/style Type: Coding style.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants