Skip to content

br: add table filter for Pitr restore #57613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
10 of 15 tasks
Tracked by #60283
Tristan1900 opened this issue Nov 22, 2024 · 0 comments · Fixed by #57394 or #60023
Open
10 of 15 tasks
Tracked by #60283

br: add table filter for Pitr restore #57613

Tristan1900 opened this issue Nov 22, 2024 · 0 comments · Fixed by #57394 or #60023
Labels
component/br This issue is related to BR of TiDB. type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@Tristan1900
Copy link
Contributor

Tristan1900 commented Nov 22, 2024 •
edited by BornChanger
Loading

Feature Request

Right now only snapshot backup/restore supports filter, users are asking for Pitr to support it. We only need to add filter for log restore but not backup

Need to consider table rename corner cases

  1. table renamed into the filter during log replay should be kept after restore
  2. table renamed out of filter range during log replay should be dropped after restore
  3. Should naturally works with insertGCRow, repairIndex and TiFlash

Tasks:

Bugfixes
@Tristan1900 Tristan1900 added the type/feature-request Categorizes issue or PR as related to a new feature. label Nov 22, 2024
@Tristan1900 Tristan1900 mentioned this issue Nov 22, 2024
Merged
13 tasks
@kennytm kennytm added the component/br This issue is related to BR of TiDB. label Jan 3, 2025
ti-chi-bot bot pushed a commit that referenced this issue Feb 12, 2025
@Tristan1900
br: add table filter for log restore (#57394)
b7e9769 
close #57613
@BornChanger BornChanger reopened this Feb 15, 2025
@Leavrth Leavrth mentioned this issue Feb 20, 2025
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 28, 2025
@Leavrth
br: add log restore ts into snapshot checkpoint metadata (#59678)
4297e12 
ref #57613
@Tristan1900 Tristan1900 mentioned this issue Mar 11, 2025
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in fc51975 Mar 12, 2025
@ti-chi-bot ti-chi-bot mentioned this issue Mar 12, 2025
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Mar 17, 2025
@ti-chi-bot
br: fix pitr meta kv fail to parse in during table filter code refact…
2d3ecc0 
…or (#60023) (#60039)

close #57613, close #60024
@jebter jebter mentioned this issue Mar 27, 2025
Open
14 tasks
zeminzhou pushed a commit to zeminzhou/tidb that referenced this issue May 6, 2025
@Tristan1900 @zeminzhou
br: add table filter for log restore (pingcap#57394)
b415681 
close pingcap#57613
zeminzhou pushed a commit to zeminzhou/tidb that referenced this issue May 6, 2025
@Leavrth @zeminzhou
br: add log restore ts into snapshot checkpoint metadata (pingcap#59678)
b3bcf2c 
ref pingcap#57613
zeminzhou pushed a commit to zeminzhou/tidb that referenced this issue May 6, 2025
@Tristan1900 @zeminzhou
br: fix pitr meta kv fail to parse in during table filter code refact…
a35b3a2 
…or (pingcap#60023)

close pingcap#57613, close pingcap#60024
@BornChanger BornChanger reopened this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/br This issue is related to BR of TiDB. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
3 participants
@kennytm @Tristan1900 @BornChanger