-
Notifications
You must be signed in to change notification settings - Fork 5.9k
br: fix table filter nil pointer issue #61225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Wenqi Mou <[email protected]>
Skipping CI for Draft Pull Request. |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61225 +/- ##
================================================
+ Coverage 73.1437% 75.0991% +1.9554%
================================================
Files 1726 1726
Lines 478033 483193 +5160
================================================
+ Hits 349651 362874 +13223
+ Misses 106948 98188 -8760
- Partials 21434 22131 +697
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
@Tristan1900 Are these tests stable and can pass in local? Please check the check list in PR description. |
/cc @BornChanger |
@wuhuizuo yes, these can be passed local and on CI stably, but accidentally commented out during merge yesterday |
/hold |
Signed-off-by: Wenqi Mou <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/unhold |
What problem does this PR solve?
Issue Number: close #61226
Problem Summary:
What changed and how does it work?
Need to take into account of multiple segments of PiTR.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.