Skip to content

br: fix table filter nil pointer issue #61225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented May 21, 2025

What problem does this PR solve?

Issue Number: close #61226

Problem Summary:

What changed and how does it work?

Need to take into account of multiple segments of PiTR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Wenqi Mou <[email protected]>
Copy link

ti-chi-bot bot commented May 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 21, 2025
@Tristan1900 Tristan1900 marked this pull request as ready for review May 21, 2025 01:22
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 21, 2025
Copy link

tiprow bot commented May 21, 2025

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.0991%. Comparing base (802eb47) to head (ae4020e).
Report is 17 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61225        +/-   ##
================================================
+ Coverage   73.1437%   75.0991%   +1.9554%     
================================================
  Files          1726       1726                
  Lines        478033     483193      +5160     
================================================
+ Hits         349651     362874     +13223     
+ Misses       106948      98188      -8760     
- Partials      21434      22131       +697     
Flag Coverage Δ
integration 46.3903% <70.0000%> (?)
unit 72.6291% <0.0000%> (+0.2423%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 63.5104% <70.0000%> (+15.9462%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented May 21, 2025

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

@Tristan1900 Are these tests stable and can pass in local? Please check the check list in PR description.

@wuhuizuo
Copy link
Contributor

/cc @BornChanger

@ti-chi-bot ti-chi-bot bot requested a review from BornChanger May 21, 2025 02:45
@Tristan1900
Copy link
Contributor Author

Tristan1900 commented May 21, 2025

@wuhuizuo yes, these can be passed local and on CI stably, but accidentally commented out during merge yesterday

@Tristan1900
Copy link
Contributor Author

/hold
might piggyback some fixes using this PR

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/needs-tests-checked labels May 21, 2025
Signed-off-by: Wenqi Mou <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2025
@Tristan1900 Tristan1900 changed the title br: uncomment int test br: fix table filter nil pointer issue May 21, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/needs-triage-completed labels May 22, 2025
Copy link

ti-chi-bot bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 22, 2025
Copy link

ti-chi-bot bot commented May 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-22 10:47:37.366901812 +0000 UTC m=+89361.783961375: ☑️ agreed by Leavrth.
  • 2025-05-22 11:57:48.185515901 +0000 UTC m=+93572.602575461: ☑️ agreed by BornChanger.

@Tristan1900
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2025
@ti-chi-bot ti-chi-bot bot merged commit a8281b6 into pingcap:master May 22, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when restore point: invalid memory address or nil pointer
4 participants