-
Notifications
You must be signed in to change notification settings - Fork 5.9k
br: add restoreid to idmap table #61278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Wenqi Mou <[email protected]>
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -1626,31 +1630,6 @@ func upgrade(s sessiontypes.Session) { | |||
} | |||
} | |||
|
|||
// checkOwnerVersion is used to wait the DDL owner to be elected in the cluster and check it is the same version as this TiDB. | |||
func checkOwnerVersion(ctx context.Context, dom *domain.Domain) (bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused method so removed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61278 +/- ##
================================================
+ Coverage 73.1581% 74.7228% +1.5646%
================================================
Files 1726 1726
Lines 478264 478380 +116
================================================
+ Hits 349889 357459 +7570
+ Misses 106905 98788 -8117
- Partials 21470 22133 +663
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Wenqi Mou <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #61277
Problem Summary:
What changed and how does it work?
Adding a restore id column to the restore idmap table to allow multiples restore happens and not stepping on each other's toe
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.