Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cplint workflow support for minimal lint-only builds #5225

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Add cplint workflow support for minimal lint-only builds #5225

wants to merge 28 commits into from

Conversation

blackdragoon26
Copy link

@blackdragoon26 blackdragoon26 commented Apr 7, 2025 •
edited
Loading

Working on this issue #4534
I made the tweaks in the lint workflow so that we can run cpplint without needing to build everything.

I ran these following commands

  • mkdir -p build && cd build
  • cmake .. -DCMAKE_LINT_ONLY=ON
  • cmake --build . --target cpplint

I am thinking as next step to further dig in to check for running once isolated docker env.

@fruffy
Copy link
Collaborator

fruffy commented Apr 8, 2025

As you can see, the step fails. This problem is about minimizing the requirements for running cmake .. with the -DCMAKE_LINT_ONLY option.

@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Apr 8, 2025
@blackdragoon26
Copy link
Author

Alright, will dig into CMakefile.txt and I suspect for issue of incomplete if (NOT Linting) Conditions.

Btw, I ran make command which started the actual build, and my whole Laptop crashed(was working in docker env then).
Is it a normal expected behaviour of my weak system config or of my already existing p4c in my system or both?
Note sure about that.
20250329_141329

@fruffy
Copy link
Collaborator

fruffy commented Apr 8, 2025

No, this is not expected behavior but it is possible that you run out of memory if your system does not have a lot of RAM.

@AkarshSahlot
Copy link
Contributor

hey @blackdragoon26! I found out that , you are doing amazing work, I was reading the logs of failed check, it was due to the outdated version setup tools, you should modify the ci workflow with this command -pip install --upgrade setuptools
and If u dont have access or permission to make changes in it , then request @fruffy sir to update or fix it . 🤗

@blackdragoon26
Copy link
Author

Thanks alot, I would look into it @AkarshSahlot

@blackdragoon26 blackdragoon26 force-pushed the troubleshootingLint branch 2 times, most recently from bcf5123 to e4a4de0 Compare April 10, 2025 22:52
AkarshSahlot and others added 21 commits April 12, 2025 16:59
@AkarshSahlot @fruffy
@jafingerhut @blackdragoon26
Skip PSATernaryTest on Ubuntu 22.04 and add Black formatting (p4lang#…
1fc44c6 
…5209)

Signed-off-by: Akarsh Sahlot <[email protected]>
Signed-off-by: fruffy <[email protected]>
Signed-off-by: Akarsh Sahlot <[email protected]>
Signed-off-by: Andy Fingerhut <[email protected]>
Signed-off-by: Andy Fingerhut <[email protected]>
Co-authored-by: Fabian Ruffy <[email protected]>
Co-authored-by: Andy Fingerhut <[email protected]>
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
Ad cplint workflow support for minimal lint-only builds
f20478b 
Signed-off-by: blackdragoon26 <[email protected]>
@fruffy @blackdragoon26
[Core] Fix namespace mismatch in irutils.h (p4lang#5220)
cb608ab 
Signed-off-by: fruffy <[email protected]>
Signed-off-by: blackdragoon26 <[email protected]>
@fruffy @blackdragoon26
[Tofino] Try to fix the dependency of mksizes in bf-asm CMake. (p4lan…
b0c2d57 
…g#5221)

Signed-off-by: fruffy <[email protected]>
Signed-off-by: blackdragoon26 <[email protected]>
@jafingerhut @blackdragoon26
Replace proprietary notice and CC license on two test files with Apac…
89c7c0e 
…he-2.0 (p4lang#5191)

Signed-off-by: Andy Fingerhut <[email protected]>
Signed-off-by: blackdragoon26 <[email protected]>
@jafingerhut @blackdragoon26
Remove confidential & proprietary notices from Tofino testgen test pr…
1281422 
…ograms (p4lang#5189)

Signed-off-by: Andy Fingerhut <[email protected]>
Signed-off-by: blackdragoon26 <[email protected]>
@fruffy @vlstill @blackdragoon26
Try to make exename portable. Refactor searchForIncludePath. (p4lang#…
4064318 
…5185)

Signed-off-by: fruffy <[email protected]>
Signed-off-by: Fabian Ruffy <[email protected]>
Co-authored-by: Vladimír Štill <[email protected]>
Signed-off-by: blackdragoon26 <[email protected]>
@psivanup @blackdragoon26
Fixed P4C driver utility find_bin to return on first match (p4lang#5226)
c66bcba 
Signed-off-by: Pitchumani Sivanupandi <[email protected]>
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
cpplint, clang,black , isort formatters should work now
14bfd3e 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
setuptools version conflict handling for 61+
33b94ec 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
explicitly upgrading setuptools in workflow
d2ec62b 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
resolving version conflict
5c98f3d 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
double quotation addition
3eac1d4 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
debugging version incompatibility issue
5f2c9c9 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
skip build isolation and ignore warnings from scapy in toml file
2ac8dba 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
strip_trailing_zero argument error
57fe1b7 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
bash terminal in clang
af5fb31 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
bash terminal in clang again
b4488b6 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
clang Command made it to POSIX safe variant
89f3e8c 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
Revert "clang Command made it to POSIX safe variant"
89fb471 
This reverts commit 2a14ff8.

Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
cmake changes
70fdca9 
Signed-off-by: blackdragoon26 <[email protected]>
ChrisDodd and others added 6 commits April 12, 2025 16:59
@ChrisDodd @blackdragoon26
improve SideEffects and StrengthReduction (p4lang#5229)
50a1447 
Signed-off-by: Chris Dodd <[email protected]>
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
bash issue
d8d3c15 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
bash issue
eb2dae4 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
bash issue
2736314 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
changed the broken code in cmake
6d61ac8 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
removed unwanted brackets
2bb9a9b 
Signed-off-by: blackdragoon26 <[email protected]>
@blackdragoon26
Copy link
Author

@fruffy , kindly review it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blackdragoon26 @fruffy @AkarshSahlot @jafingerhut @psivanup @ChrisDodd