Remove confidential & proprietary notices from Tofino testgen test programs #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ograms All of these files had an Intel copyright notice and Apache-2.0 license _before_ the older confidential & proprietary notices that are being removed in this change. It appears that some automated process was used to add the new copyright notices before publication, but they failed to remove the old one. Signed-off-by: Andy Fingerhut <[email protected]>
|
@pkotikal It would be very good to have an Intel employee approve this PR, if it is acceptable to Intel, since the files are marked as copyright by Intel. |
fruffy
approved these changes
Mar 23, 2025
|
@psivanup Pinging you, in case you are able to review and approve this, in your capacity as someone from Intel, which owns the copyright on these files. |
|
@jafingerhut , I'll get back as soon as I get feedback from my team. |
jafingerhut
deleted the
remove-confidential-notices-from-tofino-testgen-test-programs
branch
blackdragoon26
pushed a commit
to blackdragoon26/p4c
that referenced
this pull request
Apr 10, 2025
…ograms (p4lang#5189) Signed-off-by: Andy Fingerhut <[email protected]> Signed-off-by: blackdragoon26 <[email protected]>
blackdragoon26
pushed a commit
to blackdragoon26/p4c
that referenced
this pull request
Apr 10, 2025
…ograms (p4lang#5189) Signed-off-by: Andy Fingerhut <[email protected]> Signed-off-by: blackdragoon26 <[email protected]>
blackdragoon26
pushed a commit
to blackdragoon26/p4c
that referenced
this pull request
Apr 12, 2025
…ograms (p4lang#5189) Signed-off-by: Andy Fingerhut <[email protected]> Signed-off-by: blackdragoon26 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these files had an Intel copyright notice and Apache-2.0 license earlier in the file's text than the older confidential & proprietary notices that are being removed in this change. It appears that some automated process was used to add the new copyright notices before publication, but they failed to remove the old one.
With these changes, every one of the changed files still has a copyright notes and an Apache-2.0 license notice, which I am not adding, but leaving there unchanged.