[Tofino] Try to fix the dependency of mksizes in bf-asm CMake. #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tofino
ChrisDodd
approved these changes
Apr 6, 2025
| add_custom_target(bfasm_yaml DEPENDS ${BFASM_GEN_DIR}/lex-yaml.c) | ||
| add_dependencies(bfasm_yaml bfasm_uptr) | ||
|
|
||
| set_source_files_properties(${BFASM_GEN_DIR}/lex-yaml.c PROPERTIES GENERATED TRUE) |
There was a problem hiding this comment.
should a similar line be added for uptr_sizes.h as that is also a generated file?
There was a problem hiding this comment.
Couple lines down they are actually added, will remove this line.
Beats me, also seems to change based on the CMake version. Just trying to make it explicit as possible that mksizes needs to be generated before the other utilities use it. This version seems to consistently work. |
Signed-off-by: fruffy <[email protected]>
fruffy
force-pushed
the
fruffy/mksizes-cmake
branch
from
1e4afe5 to
aa0c174
Compare
blackdragoon26
pushed a commit
to blackdragoon26/p4c
that referenced
this pull request
Apr 10, 2025
…g#5221) Signed-off-by: fruffy <[email protected]> Signed-off-by: blackdragoon26 <[email protected]>
blackdragoon26
pushed a commit
to blackdragoon26/p4c
that referenced
this pull request
Apr 10, 2025
…g#5221) Signed-off-by: fruffy <[email protected]> Signed-off-by: blackdragoon26 <[email protected]>
blackdragoon26
pushed a commit
to blackdragoon26/p4c
that referenced
this pull request
Apr 12, 2025
…g#5221) Signed-off-by: fruffy <[email protected]> Signed-off-by: blackdragoon26 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can happen that the generation of
uptr_sizes.hoccurs beforemksizeshas been built.