-
Notifications
You must be signed in to change notification settings - Fork 463
Add cplint workflow support for minimal lint-only builds #5225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
blackdragoon26
wants to merge
29
commits into
p4lang:main
Choose a base branch
from
blackdragoon26:troubleshootingLint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
1fc44c6
Skip PSATernaryTest on Ubuntu 22.04 and add Black formatting (#5209)
AkarshSahlot f20478b
Ad cplint workflow support for minimal lint-only builds
blackdragoon26 cb608ab
[Core] Fix namespace mismatch in irutils.h (#5220)
fruffy b0c2d57
[Tofino] Try to fix the dependency of mksizes in bf-asm CMake. (#5221)
fruffy 89c7c0e
Replace proprietary notice and CC license on two test files with Apac…
jafingerhut 1281422
Remove confidential & proprietary notices from Tofino testgen test pr…
jafingerhut 4064318
Try to make exename portable. Refactor searchForIncludePath. (#5185)
fruffy c66bcba
Fixed P4C driver utility find_bin to return on first match (#5226)
psivanup 14bfd3e
cpplint, clang,black , isort formatters should work now
blackdragoon26 33b94ec
setuptools version conflict handling for 61+
blackdragoon26 d2ec62b
explicitly upgrading setuptools in workflow
blackdragoon26 5c98f3d
resolving version conflict
blackdragoon26 3eac1d4
double quotation addition
blackdragoon26 5f2c9c9
debugging version incompatibility issue
blackdragoon26 2ac8dba
skip build isolation and ignore warnings from scapy in toml file
blackdragoon26 57fe1b7
strip_trailing_zero argument error
blackdragoon26 af5fb31
bash terminal in clang
blackdragoon26 b4488b6
bash terminal in clang again
blackdragoon26 89f3e8c
clang Command made it to POSIX safe variant
blackdragoon26 89fb471
Revert "clang Command made it to POSIX safe variant"
blackdragoon26 70fdca9
cmake changes
blackdragoon26 50a1447
improve SideEffects and StrengthReduction (#5229)
ChrisDodd d8d3c15
bash issue
blackdragoon26 eb2dae4
bash issue
blackdragoon26 2736314
bash issue
blackdragoon26 6d61ac8
changed the broken code in cmake
blackdragoon26 2bb9a9b
removed unwanted brackets
blackdragoon26 1a1630c
Merge branch 'main' into troubleshootingLint
blackdragoon26 3d56868
Merge branch 'main' into troubleshootingLint
blackdragoon26 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really what I have been looking for. This just copies what is already there in the Linters file but without all the options.
You should be able to pass linting with with
cmake .. -DCMAKE_LINT_ONLY
and also use the functions present inhttps://github.com/p4lang/p4c/blob/main/cmake/Linters.cmake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would mean you should make the changes in the back ends and around the checks that fail in CMake.