pkg/asset/installconfig/pullsecret: Point to cloud.openshift.com #886
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
wking
force-pushed
the
pull-secret-cloud-openshift-com
branch
from
a492cd7 to
cdc1998
Compare
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
try.openshift.com used to be an HTML redirect to cloud.openshift.com, but now it's a page in its own right talking about what OpenShift 4 is. Folks who are trying to find a pull secret for the installer are already pretty interested, so they shouldn't have to dig too hard to get the JSON they need. This will also help avoid confusion like we saw for the CoreOS flow [1], where the pull secret was not immediately obvious to several users due to an undocumented "register for a Tectonic plan" intermediate [2,3]. Currently the JavaScript on /clusters/install is stripping the '#pull-secret' fragment. Hopefully that will get sorted out soon and this link will drop users right into the section with the pull-secret. [1]: openshift#663 (comment) [2]: openshift#677 [3]: openshift#691
wking
force-pushed
the
pull-secret-cloud-openshift-com
branch
from
cdc1998 to
7afc506
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -24,7 +24,7 @@ func (a *pullSecret) Generate(asset.Parents) error { | |||
| { | |||
| Prompt: &survey.Input{ | |||
| Message: "Pull Secret", | |||
| Help: "The container registry pull secret for this cluster, as a single line of JSON (e.g. {\"auths\": {...}}).\n\nYou can get this secret from https://try.openshift.com", | |||
| Help: "The container registry pull secret for this cluster, as a single line of JSON (e.g. {\"auths\": {...}}).\n\nYou can get this secret from https://cloud.openshift.com/clusters/install#pull-secret", | |||
There was a problem hiding this comment.
The #pull-secret anchor exists on the page, but doesn't really work — it's lost somewhere in auth redirects (cloud.openshift.com goes to developers.redhat.com, which, if logged in immediately redirects back to https://cloud.openshift.com/clusters/install#state=ebc6d391-...&session_state=1de96462-... — anyway the fragment is lost).
Is this important, do you want to get that fixed? (I'm not sure how exactly, but will at least track it on our side...)
There was a problem hiding this comment.
The
#pull-secretanchor exists on the page, but doesn't really work — it's lost somewhere in auth redirects...
I'd pointed that out to @kbsingh, but yeah, if you want to file an issue to track it, that would be great :).
try.openshift.com used to be an HTML redirect to cloud.openshift.com, but now it's a page in its own right talking about what OpenShift 4 is. Folks who are trying to find a pull secret for the installer are already pretty interested, so they shouldn't have to dig too hard to get the JSON they need.
This will also help avoid confusion like we saw for the CoreOS flow, where the pull secret was not immediately obvious to several users due to an undocumented "register for a Tectonic plan" intermediate (#677, #691).
Currently the JavaScript on
/clusters/installis stripping the#pull-secretfragment. Hopefully we'll get that sorted out soon and we'll be able to link directly to the section with the pull-secret. CC @kbsinghThe environment file tweak will conflict with #861, but it should be easy to rebase whichever branch lands second. CC @crawford