Skip to content

pkg/asset/installconfig/pullsecret: Point to cloud.openshift.com #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2018
Merged

pkg/asset/installconfig/pullsecret: Point to cloud.openshift.com #886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/asset/installconfig/pullsecret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func (a *pullSecret) Generate(asset.Parents) error {
{
Prompt: &survey.Input{
Message: "Pull Secret",
Help: "The container registry pull secret for this cluster, as a single line of JSON (e.g. {\"auths\": {...}}).\n\nYou can get this secret from https://try.openshift.com",
Help: "The container registry pull secret for this cluster, as a single line of JSON (e.g. {\"auths\": {...}}).\n\nYou can get this secret from https://cloud.openshift.com/clusters/install#pull-secret",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #pull-secret anchor exists on the page, but doesn't really work — it's lost somewhere in auth redirects (cloud.openshift.com goes to developers.redhat.com, which, if logged in immediately redirects back to https://cloud.openshift.com/clusters/install#state=ebc6d391-...&session_state=1de96462-... — anyway the fragment is lost).

Is this important, do you want to get that fixed? (I'm not sure how exactly, but will at least track it on our side...)

Copy link
Member Author

@wking wking Dec 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #pull-secret anchor exists on the page, but doesn't really work — it's lost somewhere in auth redirects...

I'd pointed that out to @kbsingh, but yeah, if you want to file an issue to track it, that would be great :).

},
Validate: survey.ComposeValidators(survey.Required, func(ans interface{}) error {
return validate.JSON([]byte(ans.(string)))
Expand Down