Skip to content

Elaborate what it means to download pull secret #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Nov 15, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: flaper87

If they are not already assigned, you can assign the PR to them by writing /assign @flaper87 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Nov 15, 2018

/close

I'm surprised that URL still works at all. Folks looking for a pull secret will very shortly be pointed at try.openshift.com (in flight with #663). And in that PR I'm removing this section (because getting a pull secret is not libvirt-specific). Maybe weigh in there with any wording changes you think I'm missing?

@openshift-ci-robot
Copy link
Contributor

@wking: Closing this PR.

In response to this:

/close

I'm surprised that URL still works at all. Folks looking for a pull secret will very shortly be pointed at try.openshift.com (in flight with #663). And in that PR I'm removing this section (because getting a pull secret is not libvirt-specific). Maybe weigh in there with any wording changes you think I'm missing?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/openshift-installer that referenced this pull request Dec 13, 2018
try.openshift.com used to be an HTML redirect to cloud.openshift.com,
but now it's a page in its own right talking about what OpenShift 4
is.  Folks who are trying to find a pull secret for the installer are
already pretty interested, so they shouldn't have to dig too hard to
get the JSON they need.

This will also help avoid confusion like we saw for the CoreOS flow
[1], where the pull secret was not immediately obvious to several
users due to an undocumented "register for a Tectonic plan"
intermediate [2,3].

Currently the JavaScript on /clusters/install is stripping the
'#pull-secret' fragment.  Hopefully that will get sorted out soon and
this link will drop users right into the section with the pull-secret.

[1]: openshift#663 (comment)
[2]: openshift#677
[3]: openshift#691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants