Skip to content

Add instructions for getting a pull secret #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add instructions for getting a pull secret #691

wants to merge 1 commit into from

Conversation

raesene
Copy link

@raesene raesene commented Nov 16, 2018

If you sign-up on account.coreos.com there is no mention anywhere of pull secrets initially. Only after you sign-up for tectonic within that portal, does the pull secret section appear. This change to the install file hopefully makes that clearer...

If you sign-up on account.coreos.com there is no mention anywhere of pull secrets initially.  Only after you sign-up for tectonic within that portal, does the pull secret section appear.  This change to the install file hopefully makes that clearer...
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 16, 2018
@openshift-ci-robot
Copy link
Contributor

Hi @raesene. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raesene
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wking

If they are not already assigned, you can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Nov 16, 2018

/close

This is a lot like #677, and I still think we want to push forward with #663 for this.

@openshift-ci-robot
Copy link
Contributor

@wking: Closing this PR.

In response to this:

/close

This is a lot like #677, and I still think we want to push forward with #663 for this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/openshift-installer that referenced this pull request Dec 13, 2018
try.openshift.com used to be an HTML redirect to cloud.openshift.com,
but now it's a page in its own right talking about what OpenShift 4
is.  Folks who are trying to find a pull secret for the installer are
already pretty interested, so they shouldn't have to dig too hard to
get the JSON they need.

This will also help avoid confusion like we saw for the CoreOS flow
[1], where the pull secret was not immediately obvious to several
users due to an undocumented "register for a Tectonic plan"
intermediate [2,3].

Currently the JavaScript on /clusters/install is stripping the
'#pull-secret' fragment.  Hopefully that will get sorted out soon and
this link will drop users right into the section with the pull-secret.

[1]: openshift#663 (comment)
[2]: openshift#677
[3]: openshift#691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants