Skip to content

feat: allow solo to deploy pre-configured resource profiles #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Apr 7, 2024

Conversation

leninmehedy
Copy link
Contributor

@leninmehedy leninmehedy commented Mar 21, 2024

Description

This pull request changes the following:

  • feat: support pre-configured resource profile for network deployment
  • Improve robustness by adding more steps to check that different resources are up

Related Issues

Copy link
Contributor

github-actions bot commented Mar 21, 2024

Unit Test Results

  1 files   17 suites   1m 14s ⏱️
114 tests 114 ✅ 0 💤 0 ❌
139 runs  139 ✅ 0 💤 0 ❌

Results for commit 9394895.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 21, 2024

E2E Test Results

 1 files  10 suites   9m 8s ⏱️
74 tests 74 ✅ 0 💤 0 ❌
76 runs  76 ✅ 0 💤 0 ❌

Results for commit 9394895.

♻️ This comment has been updated with latest results.

@leninmehedy leninmehedy force-pushed the 00097-pre-configured-profiles branch 3 times, most recently from 253b475 to bbfa631 Compare March 25, 2024 20:41
@leninmehedy leninmehedy force-pushed the 00097-pre-configured-profiles branch from bbfa631 to 7702627 Compare April 2, 2024 02:39
@wiz-inc-8f76296f7c
Copy link

wiz-inc-8f76296f7c bot commented Apr 2, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 4M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 4M 0L 0I
Secrets 0🔑

@leninmehedy leninmehedy force-pushed the 00097-pre-configured-profiles branch from 7702627 to 9c0f8a7 Compare April 2, 2024 02:46
@leninmehedy leninmehedy force-pushed the 00097-pre-configured-profiles branch from 9c0f8a7 to 5898ab4 Compare April 2, 2024 07:25
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
@leninmehedy leninmehedy force-pushed the 00097-pre-configured-profiles branch from 607905d to a4fb454 Compare April 5, 2024 15:13
@leninmehedy leninmehedy force-pushed the 00097-pre-configured-profiles branch from a4fb454 to 3012780 Compare April 5, 2024 15:20
jeromy-cannon
jeromy-cannon previously approved these changes Apr 5, 2024
@leninmehedy leninmehedy force-pushed the 00097-pre-configured-profiles branch from 41087e9 to 32c463c Compare April 5, 2024 16:15
Copy link

codacy-production bot commented Apr 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.86% (target: -1.00%) 81.59%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (dea5ea5) 2594 1986 76.56%
Head commit (9394895) 2874 (+280) 2225 (+239) 77.42% (+0.86%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#175) 353 288 81.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 82.09719% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 77.13%. Comparing base (fbcf7ca) to head (9394895).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   76.18%   77.13%   +0.94%     
==========================================
  Files          32       33       +1     
  Lines        3107     3415     +308     
  Branches      553      636      +83     
==========================================
+ Hits         2367     2634     +267     
- Misses        740      781      +41     
Files Coverage Δ
src/commands/base.mjs 92.85% <100.00%> (+7.14%) ⬆️
src/commands/flags.mjs 94.23% <100.00%> (+0.23%) ⬆️
src/core/config_manager.mjs 91.56% <100.00%> (ø)
src/core/constants.mjs 94.50% <100.00%> (+0.99%) ⬆️
src/core/helm.mjs 90.90% <100.00%> (ø)
src/core/helpers.mjs 97.43% <100.00%> (+0.13%) ⬆️
src/core/templates.mjs 80.30% <100.00%> (+2.36%) ⬆️
test/test_util.js 90.58% <100.00%> (+1.30%) ⬆️
version.mjs 100.00% <100.00%> (ø)
src/commands/init.mjs 76.36% <92.30%> (+0.89%) ⬆️
... and 9 more

... and 1 file with indirect coverage changes

Impacted file tree graph

@leninmehedy leninmehedy merged commit fef8a48 into main Apr 7, 2024
@leninmehedy leninmehedy deleted the 00097-pre-configured-profiles branch April 7, 2024 23:26
swirlds-automation added a commit that referenced this pull request Apr 19, 2024
## [0.24.0](v0.23.0...v0.24.0) (2024-04-19)

### Features

* add `solo account create` account alias support ([#227](#227)) ([fe865f8](fe865f8))
* add node refresh subcommand ([#211](#211)) ([d1017d8](d1017d8))
* add node refresh subcommand ([#211](#211)) ([d38918c](d38918c))
* adding some type check ([#217](#217)) ([d055496](d055496))
* allow solo to deploy pre-configured resource profiles ([#175](#175)) ([fef8a48](fef8a48))

### Bug Fixes

* add recursive option to mkdir ([#215](#215)) ([9d9a126](9d9a126))
* address PR comments from [#211](#211) ([#224](#224)) ([6cc237c](6cc237c))
* return chart-path correctly when chart-directory is specified ([#212](#212)) ([90616cc](90616cc))
* update how documented generated ([#216](#216)) ([7d2499e](7d2499e))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow solo to deploy pre-configured network to support desired workload
4 participants