Skip to content

feat: add solo account create account alias support #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 14, 2024

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Apr 12, 2024

Description

This pull request changes the following:

  • add solo account create --ecdsa-private-key "@@@" --set-alias
  • fix issue where creating Kuberenetes secret was not using base64 encoding
  • add npm run test-coverage with supporting scripts in package.json

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Apr 12, 2024
Copy link
Contributor

github-actions bot commented Apr 12, 2024

Unit Test Results - Linux

  1 files  ±0   17 suites  ±0   1m 17s ⏱️ +4s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
139 runs  ±0  139 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2f0b6b9. ± Comparison against base commit d055496.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Unit Test Results - Windows

  1 files  ±0   17 suites  ±0   1m 24s ⏱️ -4s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
139 runs  ±0  139 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2f0b6b9. ± Comparison against base commit d055496.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 12, 2024

E2E Test Results

 1 files  ±0  10 suites  ±0   11m 42s ⏱️ - 1m 32s
85 tests +1  85 ✅ +1  0 💤 ±0  0 ❌ ±0 
87 runs  +1  87 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 2f0b6b9. ± Comparison against base commit d055496.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Apr 12, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.14% (target: -1.00%) 78.57%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d055496) 3015 2345 77.78%
Head commit (2f0b6b9) 3034 (+19) 2364 (+19) 77.92% (+0.14%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#227) 28 22 78.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 77.72%. Comparing base (d055496) to head (2f0b6b9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   77.60%   77.72%   +0.12%     
==========================================
  Files          33       33              
  Lines        3586     3601      +15     
  Branches      593      600       +7     
==========================================
+ Hits         2783     2799      +16     
+ Misses        803      802       -1     
Files Coverage Δ
src/commands/account.mjs 68.13% <100.00%> (+0.47%) ⬆️
src/commands/flags.mjs 94.44% <100.00%> (+0.21%) ⬆️
src/core/k8.mjs 86.38% <75.00%> (+1.09%) ⬆️
src/core/account_manager.mjs 71.36% <75.00%> (+0.47%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon marked this pull request as ready for review April 12, 2024 21:28
@jeromy-cannon jeromy-cannon requested review from a team and leninmehedy as code owners April 12, 2024 21:28
@jeromy-cannon jeromy-cannon reopened this Apr 14, 2024
@jeromy-cannon jeromy-cannon merged commit fe865f8 into main Apr 14, 2024
@jeromy-cannon jeromy-cannon deleted the 00141-account-alias branch April 14, 2024 11:09
swirlds-automation added a commit that referenced this pull request Apr 19, 2024
## [0.24.0](v0.23.0...v0.24.0) (2024-04-19)

### Features

* add `solo account create` account alias support ([#227](#227)) ([fe865f8](fe865f8))
* add node refresh subcommand ([#211](#211)) ([d1017d8](d1017d8))
* add node refresh subcommand ([#211](#211)) ([d38918c](d38918c))
* adding some type check ([#217](#217)) ([d055496](d055496))
* allow solo to deploy pre-configured resource profiles ([#175](#175)) ([fef8a48](fef8a48))

### Bug Fixes

* add recursive option to mkdir ([#215](#215)) ([9d9a126](9d9a126))
* address PR comments from [#211](#211) ([#224](#224)) ([6cc237c](6cc237c))
* return chart-path correctly when chart-directory is specified ([#212](#212)) ([90616cc](90616cc))
* update how documented generated ([#216](#216)) ([7d2499e](7d2499e))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ECDSA and Alias Account Support in account subcommand
3 participants