test: reduce error logging in the console for failed test to avoid confusion in CI logs

Signed-off-by: Lenin Mehedy <[email protected]>

Author: leninmehedy

src/core/helm.mjs

@@ -44,7 +44,7 @@ export class Helm extends ShellRunner {
      * @returns {Promise<Array>} console output as an array of strings
      */
   async install (...args) {
-    return this.run(this.prepareCommand('install', ...args), true)
+    return this.run(this.prepareCommand('install', ...args))
   }
 
   /**

test/e2e/commands/cluster.test.mjs

@@ -20,21 +20,26 @@ import {
   beforeEach,
   describe,
   expect,
-  it
+  it, jest
 } from '@jest/globals'
 import {
   bootstrapTestVariables,
   getDefaultArgv,
   TEST_CLUSTER
 } from '../../test_util.js'
 import {
-  constants
+  constants,
+  logging
 } from '../../../src/core/index.mjs'
 import { flags } from '../../../src/commands/index.mjs'
 import { sleep } from '../../../src/core/helpers.mjs'
 import * as version from '../../../version.mjs'
 
 describe('ClusterCommand', () => {
+  // mock showUser and showJSON to silent logging during tests
+  jest.spyOn(logging.Logger.prototype, 'showUser').mockImplementation()
+  jest.spyOn(logging.Logger.prototype, 'showJSON').mockImplementation()
+
   const testName = 'cluster-cmd-e2e'
   const namespace = testName
   const argv = getDefaultArgv()
@@ -75,7 +80,6 @@ describe('ClusterCommand', () => {
       try {
         await expect(clusterCmd.reset(argv)).resolves.toBeTruthy()
       } catch (e) {
-        clusterCmd.logger.showUserError(e)
         expect(e).toBeNull()
       }
     }
@@ -89,7 +93,6 @@ describe('ClusterCommand', () => {
     try {
       await expect(clusterCmd.setup(argv)).rejects.toThrowError('Error on cluster setup')
     } catch (e) {
-      clusterCmd.logger.showUserError(e)
       expect(e).toBeNull()
     }
   }, 60000)
@@ -102,7 +105,6 @@ describe('ClusterCommand', () => {
     try {
       await expect(clusterCmd.setup(argv)).resolves.toBeTruthy()
     } catch (e) {
-      clusterCmd.logger.showUserError(e)
       expect(e).toBeNull()
     }
   }, 60000)
@@ -111,7 +113,6 @@ describe('ClusterCommand', () => {
     try {
       await expect(clusterCmd.getClusterInfo()).resolves.toBeTruthy()
     } catch (e) {
-      clusterCmd.logger.showUserError(e)
       expect(e).toBeNull()
     }
   }, 60000)
@@ -120,7 +121,6 @@ describe('ClusterCommand', () => {
     try {
       await expect(clusterCmd.showClusterList()).resolves.toBeTruthy()
     } catch (e) {
-      clusterCmd.logger.showUserError(e)
       expect(e).toBeNull()
     }
   }, 60000)
@@ -129,7 +129,6 @@ describe('ClusterCommand', () => {
     try {
       await expect(clusterCmd.showInstalledChartList()).resolves.toBeUndefined()
     } catch (e) {
-      clusterCmd.logger.showUserError(e)
       expect(e).toBeNull()
     }
   }, 60000)
@@ -156,7 +155,6 @@ describe('ClusterCommand', () => {
     try {
       await expect(clusterCmd.reset(argv)).resolves.toBeTruthy()
     } catch (e) {
-      clusterCmd.logger.showUserError(e)
       expect(e).toBeNull()
     }
   }, 60000)

test/unit/core/helm.test.mjs

@@ -30,7 +30,7 @@ describe.each([
 
   it('should run helm install', async () => {
     await helm.install('arg')
-    expect(shellSpy).toHaveBeenCalledWith(`${helmPath} install arg`, true)
+    expect(shellSpy).toHaveBeenCalledWith(`${helmPath} install arg`)
   })
 
   it('should run helm uninstall', async () => {