fix: use port forward if load balancer IP is not in supported network interface subnets

Signed-off-by: Lenin Mehedy <[email protected]>

Author: leninmehedy

package-lock.json

@@ -38,6 +38,7 @@
     "figlet": "^1.7.0",
     "got": "^14.2.0",
     "inquirer": "^9.2.15",
+    "ip": "^2.0.1",
     "js-base64": "^3.7.7",
     "js-yaml": "^4.1.0",
     "listr2": "^8.0.2",

package.json

@@ -498,7 +498,7 @@ export class NodeCommand extends BaseCommand {
             for (const nodeId of ctx.config.nodeIds) {
               const podName = ctx.config.podNames[nodeId]
               subTasks.push({
-                title: `Node: ${chalk.yellow(nodeId)}`,
+                title: `Updating node: ${chalk.yellow(nodeId)}`,
                 task: () =>
                   self.plaformInstaller.fetchPlatform(podName, config.releaseTag)
               })

src/commands/node.mjs

@@ -16,6 +16,7 @@
  */
 import * as HashgraphProto from '@hashgraph/proto'
 import * as Base64 from 'js-base64'
+import os from 'os'
 import * as constants from './constants.mjs'
 import {
   AccountCreateTransaction,
@@ -32,6 +33,7 @@ import {
 } from '@hashgraph/sdk'
 import { FullstackTestingError, MissingArgumentError } from './errors.mjs'
 import { Templates } from './templates.mjs'
+import ip from 'ip'
 
 const REASON_FAILED_TO_GET_KEYS = 'failed to get keys for accountId'
 const REASON_SKIPPED = 'skipped since it does not have a genesis key'
@@ -178,6 +180,35 @@ export class AccountManager {
     }
   }
 
+  shouldUseLocalHostPortForward (serviceObject) {
+    if (!serviceObject.loadBalancerIp) return true
+
+    const loadBalancerIp = serviceObject.loadBalancerIp
+    const interfaces = os.networkInterfaces()
+    let usePortForward = true
+    const loadBalancerIpFormat = ip.isV6Format(loadBalancerIp) ? 'ipv4' : 'ipv6'
+
+    // check if serviceIP falls into any subnet of the network interfaces
+    for (const nic of Object.keys(interfaces)) {
+      const inf = interfaces[nic]
+      for (const item of inf) {
+        if (item.family.toLowerCase() === loadBalancerIpFormat &&
+          ip.cidrSubnet(item.cidr).contains(loadBalancerIp)) {
+          usePortForward = false
+          break
+        }
+      }
+    }
+
+    if (usePortForward) {
+      this.logger.debug('Local network and Load balancer are in different network, using local host port forward')
+    } else {
+      this.logger.debug('Local network and Load balancer are in the same network, using load balancer IP port forward')
+    }
+
+    return usePortForward
+  }
+
   /**
    * Returns a node client that can be used to make calls against
    * @param namespace the namespace for which the node client resides
@@ -192,7 +223,7 @@ export class AccountManager {
       let localPort = constants.LOCAL_NODE_START_PORT
 
       for (const serviceObject of serviceMap.values()) {
-        const usePortForward = !(serviceObject.loadBalancerIp)
+        const usePortForward = this.shouldUseLocalHostPortForward(serviceObject)
         const host = usePortForward ? '127.0.0.1' : serviceObject.loadBalancerIp
         const port = serviceObject.grpcPort
         const targetPort = usePortForward ? localPort : port

src/core/account_manager.mjs

@@ -53,4 +53,10 @@ describe('AccountManager', () => {
 
     expect(accountManager._portForwards.length).toStrictEqual(0)
   })
+
+  it('should be able to load a new client', async () => {
+    await accountManager.loadNodeClient(configManager.getFlag(flags.namespace))
+    expect(accountManager._nodeClient).not.toBeNull()
+    await accountManager.close()
+  })
 })