feat(multi-cluster): 'solo relay deploy' to handle cluster-ref value #1394

instamenta · 2025-02-14T15:32:22Z

Description

update the solo relay deploy command to understand the --cluster-ref flag
update relevant tasks to run against the specified --cluster-ref context to run helm and k8 commands

Related Issues

Closes # Update solo relay deploy --deployment <deployment> --cluster-ref <cluster-ref> to handle cluster-ref value #1362

Signed-off-by: instamenta <[email protected]>

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value # Conflicts: # src/commands/base.ts

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value # Conflicts: # src/commands/base.ts # src/commands/flags.ts

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value

Signed-off-by: instamenta <[email protected]>

github-actions · 2025-02-14T15:38:35Z

Unit Test Results - Linux

1 files ±0 62 suites ±0 3s ⏱️ -1s
241 tests ±0 241 ✅ ±0 0 💤 ±0 0 ❌ ±0
250 runs ±0 250 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit d9cb75a. ± Comparison against base commit 2dca095.

♻️ This comment has been updated with latest results.

github-actions · 2025-02-14T15:38:46Z

Unit Test Results - Windows

1 files ±0 62 suites ±0 2s ⏱️ ±0s
241 tests ±0 241 ✅ ±0 0 💤 ±0 0 ❌ ±0
250 runs ±0 250 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit d9cb75a. ± Comparison against base commit 2dca095.

♻️ This comment has been updated with latest results.

src/commands/relay.ts

github-actions · 2025-02-14T16:12:13Z

E2E Test Report

17 files 126 suites 1h 34m 43s ⏱️
270 tests 270 ✅ 0 💤 0 ❌
285 runs 285 ✅ 0 💤 0 ❌

Results for commit d9cb75a.

♻️ This comment has been updated with latest results.

codecov · 2025-02-14T16:13:44Z

Codecov Report

Attention: Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.67%. Comparing base (23e17aa) to head (d9cb75a).
Report is 41 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/relay.ts	86.20%	0 Missing and 4 partials ⚠️
src/core/account_manager.ts	96.55%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1394      +/-   ##
==========================================
- Coverage   83.79%   83.67%   -0.13%     
==========================================
  Files         132      132              
  Lines       25074    25165      +91     
  Branches     2480     1774     -706     
==========================================
+ Hits        21012    21057      +45     
- Misses       3842     4040     +198     
+ Partials      220       68     -152

Files with missing lines	Coverage Δ
src/commands/node/tasks.ts	`93.73% <100.00%> (ø)`
src/core/helpers.ts	`79.35% <ø> (-0.79%)`	⬇️
src/core/platform_installer.ts	`90.21% <100.00%> (-0.06%)`	⬇️
src/core/account_manager.ts	`85.40% <96.55%> (+0.21%)`	⬆️
src/commands/relay.ts	`83.84% <86.20%> (+0.28%)`	⬆️

... and 51 files with indirect coverage changes

Signed-off-by: instamenta <[email protected]>

codacy-production · 2025-02-14T16:19:24Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `2dca095`¹	✅ 98.41%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`2dca095`)	Report Missing	Report Missing	Report Missing
Head commit (`d9cb75a`)	25165	21338	84.79%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1394)	63	62	98.41%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

Signed-off-by: instamenta <[email protected]>

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value # Conflicts: # src/core/account_manager.ts

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value

Signed-off-by: instamenta <[email protected]>

## [0.35.0](v0.34.0...v0.35.0) (2025-02-20) ### Features * Add adminKey flag to node setup command ([#1193](#1193)) ([b044fcc](b044fcc)) * add BaseCommand.getConsensusNodes() method ([#1364](#1364)) ([44703a4](44703a4)) * add BaseCommand.getContexts() method ([#1366](#1366)) ([7a5b05b](7a5b05b)) * add basic multi-cluster support to `solo network deploy` ([#1389](#1389)) ([22ed9ae](22ed9ae)) * add clusters fluent interface implementation ([#1291](#1291)) ([95c71f0](95c71f0)) * add concurrent to the task of copying hedera jar files to network node ([#1289](#1289)) ([c50f4c3](c50f4c3)) * add configmaps fluent interface implementation ([#1295](#1295)) ([2c5d6f3](2c5d6f3)) * add contexts fluent interface implementation ([#1297](#1297)) ([938a956](938a956)) * add factory and injection logic ([#1352](#1352)) ([c794610](c794610)) * add flags to support aws as storage destination ([#1372](#1372)) ([5ca0e47](5ca0e47)) * add secrets fluent interface implementation ([#1312](#1312)) ([fb92fd6](fb92fd6)) * add service and services fluent interface implementation ([#1303](#1303)) ([8ef6998](8ef6998)) * add support for --force-port-forward as a top level flag ([#1404](#1404)) ([5c18967](5c18967)) * add support for multi-cluster testing via KinD ([#1392](#1392)) ([ec7eca1](ec7eca1)) * add support for using load balancer address in gossip configuration ([#1405](#1405)) ([0e3f41f](0e3f41f)) * **cli:** add new command `solo deployment list` that lists deployments on that specific cluster ([#1220](#1220)) ([6b0b486](6b0b486)) * **cli:** reduce redundancy on context to cluster flags in command `deployment create` ([#1156](#1156)) ([4ab4dd5](4ab4dd5)) * create the v059x node-override.yaml via solo ([#1192](#1192)) ([283d35c](283d35c)) * **external-database:** add ability to pass readonly user to the external database ([#1350](#1350)) ([d9626ac](d9626ac)) * **local-remote-config:** added solo version to local config and remote config ([#1384](#1384)) ([2dca095](2dca095)) * **mirror-node:** Enhance mirror-node external database feature ([#1230](#1230)) ([bce75d5](bce75d5)) * **multi-cluster:** 'solo relay deploy' to handle cluster-ref value ([#1394](#1394)) ([e73114c](e73114c)) * **multi-cluster:** make remote config validation compatible with multi-cluster K8 implementation ([#1407](#1407)) ([7614a39](7614a39)) * **multi-cluster:** Update `solo node setup` to support multiple clusters ([#1368](#1368)) ([4618a43](4618a43)) * **remote-config:** instead of keeping just the command and the subcommand inside the remote config keep the flags as passed ([#1208](#1208)) ([a31498e](a31498e)) * **remote-config:** save reusable solo flags in remoteconfig ([#1191](#1191)) ([809d0ab](809d0ab)) * Separate concepts for namespace and deployment name ([#1231](#1231)) ([2566c90](2566c90)) * update solo to support pathPrefix of mirror node importer ([#1204](#1204)) ([d9a3592](d9a3592)) ### Bug Fixes * ensure network active check supports multi-cluster deployments ([#1431](#1431)) ([a07801f](a07801f)) * ensure staking updates support multi-cluster deployments ([#1432](#1432)) ([ef5435e](ef5435e)) * fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme ([#1396](#1396)) ([cc672c2](cc672c2)) * fixed merge issue with incorrect license header ([#1235](#1235)) ([cb91806](cb91806)) * increase number of attempts to wait for active nodes ([#1430](#1430)) ([d113167](d113167)) * mirror node command changes required for multi-cluster support ([#1433](#1433)) ([f43870e](f43870e)) * **multi-cluster:** fix 'solo node setup' command, failing when running multiple clusters ([#1421](#1421)) ([eacdf1f](eacdf1f)) * **network-command:** wrong value passed to addDebugOptions inside the 'network' command ([#1415](#1415)) ([c2e5c3b](c2e5c3b)) * Resolve `cannot read properties of undefined `error thrown during `solo network deploy` ([#1410](#1410)) ([401b937](401b937)) * test script of google storage ([#1397](#1397)) ([370f57b](370f57b)) * update default solo helm chart version ([#1378](#1378)) ([5b5e276](5b5e276)) * update RemoteConfig to handle multi-cluster networking ([#1348](#1348)) ([77b769f](77b769f)) * use better internal IPs for 0.58.5+ ([#1429](#1429)) ([26279ac](26279ac))

swirlds-automation · 2025-02-20T01:51:18Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation · 2025-02-24T01:50:31Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

instamenta added 6 commits February 13, 2025 00:04

modified most of the methods for the relay

50e35ac

Signed-off-by: instamenta <[email protected]>

Added support for to use the --cluster-ref flag and it's tasks

2093425

Signed-off-by: instamenta <[email protected]>

Merge remote-tracking branch 'origin/main' into 01362-update-solo-rel…

356640f

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value # Conflicts: # src/commands/base.ts

Merge remote-tracking branch 'origin/main' into 01362-update-solo-rel…

3c31f2a

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value # Conflicts: # src/commands/base.ts # src/commands/flags.ts

Merge remote-tracking branch 'origin/main' into 01362-update-solo-rel…

43be20f

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value

Merge remote-tracking branch 'origin/main' into 01362-update-solo-rel…

2fa9771

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value

instamenta requested review from leninmehedy and a team as code owners February 14, 2025 15:32

instamenta linked an issue Feb 14, 2025 that may be closed by this pull request

Update solo relay deploy --deployment <deployment> --cluster-ref <cluster-ref> to handle cluster-ref value #1362

Closed

instamenta self-assigned this Feb 14, 2025

instamenta requested review from jeromy-cannon and nathanklick February 14, 2025 15:32

lint-fix

7650c34

Signed-off-by: instamenta <[email protected]>

jeromy-cannon reviewed Feb 14, 2025

View reviewed changes

src/commands/relay.ts Outdated Show resolved Hide resolved

jeromy-cannon previously approved these changes Feb 14, 2025

View reviewed changes

jeromy-cannon added the PR: Ready to Merge A pull request that is ready to merge. label Feb 14, 2025

remove redundant conditional logic for k8Factory.getK8()

5ca3945

Signed-off-by: instamenta <[email protected]>

instamenta dismissed jeromy-cannon’s stale review via 5ca3945 February 14, 2025 16:17

remove redundant conditional logic for k8Factory.getK8()

2330423

Signed-off-by: instamenta <[email protected]>

jeromy-cannon previously approved these changes Feb 14, 2025

View reviewed changes

instamenta added 3 commits February 14, 2025 19:05

Merge remote-tracking branch 'origin/main' into 01362-update-solo-rel…

ba5f744

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value # Conflicts: # src/core/account_manager.ts

Merge remote-tracking branch 'origin/main' into 01362-update-solo-rel…

2ca32a1

…ay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value

lint-fix and resolved issues after merge

d9cb75a

Signed-off-by: instamenta <[email protected]>

instamenta dismissed jeromy-cannon’s stale review via d9cb75a February 14, 2025 17:18

jeromy-cannon approved these changes Feb 14, 2025

View reviewed changes

jeromy-cannon merged commit e73114c into main Feb 14, 2025
40 checks passed

jeromy-cannon deleted the 01362-update-solo-relay-deploy---deployment-deployment---cluster-ref-cluster-ref-to-handle-cluster-ref-value branch February 14, 2025 18:15

swirlds-automation added the released label Feb 20, 2025

swirlds-automation added the released on @0.35.x label Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(multi-cluster): 'solo relay deploy' to handle cluster-ref value #1394

feat(multi-cluster): 'solo relay deploy' to handle cluster-ref value #1394

Uh oh!

instamenta commented Feb 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2025 •

edited

Loading

Uh oh!

codecov bot commented Feb 14, 2025 •

edited

Loading

Uh oh!

codacy-production bot commented Feb 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

swirlds-automation commented Feb 20, 2025

Uh oh!

swirlds-automation commented Feb 24, 2025

Uh oh!

Uh oh!

feat(multi-cluster): 'solo relay deploy' to handle cluster-ref value #1394

feat(multi-cluster): 'solo relay deploy' to handle cluster-ref value #1394

Uh oh!

Conversation

instamenta commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Uh oh!

github-actions bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results - Linux

Uh oh!

github-actions bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results - Windows

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Report

Uh oh!

codecov bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codacy-production bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

Uh oh!

Uh oh!

swirlds-automation commented Feb 20, 2025

Uh oh!

swirlds-automation commented Feb 24, 2025

Uh oh!

Uh oh!

instamenta commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

codecov bot commented Feb 14, 2025 •

edited

Loading

codacy-production bot commented Feb 14, 2025 •

edited

Loading