Skip to content

feat: add secrets fluent interface implementation #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

nathanklick
Copy link
Contributor

Description

This pull request changes the following:

  • Adds K8ClientSecrets class which implements the Secrets interface
  • Refactors and reduces code duplication across PodName, PodRef, ContainerRef, and ContainerName classes
  • Misc refactors or enhancements

Related Issues

@nathanklick nathanklick requested review from leninmehedy and a team as code owners February 7, 2025 22:15
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   2s ⏱️ ±0s
231 tests ±0  231 ✅ ±0  0 💤 ±0  0 ❌ ±0 
240 runs  ±0  240 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fc636a4. ± Comparison against base commit 136cd7b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   3s ⏱️ ±0s
231 tests ±0  231 ✅ ±0  0 💤 ±0  0 ❌ ±0 
240 runs  ±0  240 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fc636a4. ± Comparison against base commit 136cd7b.

♻️ This comment has been updated with latest results.

Signed-off-by: Nathan Klick <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 8, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 28m 38s ⏱️ + 1m 48s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fc636a4. ± Comparison against base commit 136cd7b.

Copy link
Contributor

github-actions bot commented Feb 8, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 28m 38s ⏱️ + 1m 48s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fc636a4. ± Comparison against base commit 136cd7b.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.11% (target: -1.00%) 87.32%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (136cd7b) 22281 18500 83.03%
Head commit (fc636a4) 22426 (+145) 18646 (+146) 83.14% (+0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1312) 473 413 87.32%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 86.04651% with 66 lines in your changes missing coverage. Please review.

Project coverage is 82.15%. Comparing base (136cd7b) to head (fc636a4).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
src/core/kube/k8_client/k8_client_secrets.ts 87.19% 21 Missing ⚠️
src/core/kube/nested_resource_ref.ts 73.68% 8 Missing and 2 partials ⚠️
src/core/kube/resource_ref.ts 73.68% 8 Missing and 2 partials ⚠️
src/core/kube/k8_client/k8_client_container.ts 78.26% 4 Missing and 1 partial ⚠️
src/core/kube/resource_name.ts 93.44% 4 Missing ⚠️
src/core/kube/k8_client/k8_client_pod.ts 66.66% 3 Missing ⚠️
src/core/kube/errors/missing_namespace_error.ts 88.88% 2 Missing ⚠️
.../core/kube/errors/missing_parent_resource_error.ts 88.88% 2 Missing ⚠️
...rc/core/kube/errors/missing_resource_name_error.ts 88.88% 2 Missing ⚠️
src/core/kube/k8_client/k8_client_config_maps.ts 60.00% 1 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   82.03%   82.15%   +0.11%     
==========================================
  Files         110      118       +8     
  Lines       22281    22426     +145     
  Branches     1424     2251     +827     
==========================================
+ Hits        18279    18424     +145     
+ Misses       3990     3799     -191     
- Partials       12      203     +191     
Files with missing lines Coverage Δ
src/core/kube/container_name.ts 100.00% <100.00%> (+14.66%) ⬆️
src/core/kube/container_ref.ts 100.00% <100.00%> (+26.41%) ⬆️
...rc/core/kube/errors/invalid_resource_name_error.ts 100.00% <100.00%> (ø)
...c/core/kube/errors/namespace_name_invalid_error.ts 90.90% <ø> (+0.08%) ⬆️
src/core/kube/k8_client.ts 96.62% <100.00%> (+0.81%) ⬆️
src/core/kube/k8_client/k8_client_pods.ts 89.13% <100.00%> (ø)
src/core/kube/kube_api_response.ts 78.68% <100.00%> (-0.26%) ⬇️
src/core/kube/pod_name.ts 100.00% <100.00%> (+8.00%) ⬆️
src/core/kube/pod_ref.ts 100.00% <100.00%> (+23.52%) ⬆️
src/core/kube/resource_type.ts 100.00% <100.00%> (ø)
... and 13 more

... and 44 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit fb92fd6 into main Feb 8, 2025
42 checks passed
@jeromy-cannon jeromy-cannon deleted the 01245-k8s-secrets-impl branch February 8, 2025 13:22
swirlds-automation added a commit that referenced this pull request Feb 20, 2025
## [0.35.0](v0.34.0...v0.35.0) (2025-02-20)

### Features

* Add adminKey flag to node setup command ([#1193](#1193)) ([b044fcc](b044fcc))
* add BaseCommand.getConsensusNodes() method ([#1364](#1364)) ([44703a4](44703a4))
* add BaseCommand.getContexts() method ([#1366](#1366)) ([7a5b05b](7a5b05b))
* add basic multi-cluster support to `solo network deploy` ([#1389](#1389)) ([22ed9ae](22ed9ae))
* add clusters fluent interface implementation ([#1291](#1291)) ([95c71f0](95c71f0))
* add concurrent to the task of copying hedera jar files to network node ([#1289](#1289)) ([c50f4c3](c50f4c3))
* add configmaps fluent interface implementation ([#1295](#1295)) ([2c5d6f3](2c5d6f3))
* add contexts fluent interface implementation ([#1297](#1297)) ([938a956](938a956))
* add factory and injection logic ([#1352](#1352)) ([c794610](c794610))
* add flags to support aws as storage destination ([#1372](#1372)) ([5ca0e47](5ca0e47))
* add secrets fluent interface implementation ([#1312](#1312)) ([fb92fd6](fb92fd6))
* add service and services fluent interface implementation ([#1303](#1303)) ([8ef6998](8ef6998))
* add support for --force-port-forward as a top level flag ([#1404](#1404)) ([5c18967](5c18967))
* add support for multi-cluster testing via KinD ([#1392](#1392)) ([ec7eca1](ec7eca1))
* add support for using load balancer address in gossip configuration ([#1405](#1405)) ([0e3f41f](0e3f41f))
* **cli:** add new command `solo deployment list` that lists deployments on that specific cluster ([#1220](#1220)) ([6b0b486](6b0b486))
* **cli:** reduce redundancy on context to cluster flags in command `deployment create` ([#1156](#1156)) ([4ab4dd5](4ab4dd5))
* create the v059x node-override.yaml via solo ([#1192](#1192)) ([283d35c](283d35c))
* **external-database:** add ability to pass readonly user to the external database ([#1350](#1350)) ([d9626ac](d9626ac))
* **local-remote-config:** added solo version to local config and remote config ([#1384](#1384)) ([2dca095](2dca095))
* **mirror-node:** Enhance mirror-node external database feature ([#1230](#1230)) ([bce75d5](bce75d5))
* **multi-cluster:** 'solo relay deploy' to handle cluster-ref value ([#1394](#1394)) ([e73114c](e73114c))
* **multi-cluster:** make remote config validation compatible with multi-cluster K8 implementation ([#1407](#1407)) ([7614a39](7614a39))
* **multi-cluster:** Update `solo node setup` to support multiple clusters ([#1368](#1368)) ([4618a43](4618a43))
* **remote-config:** instead of keeping just the command and the subcommand inside the remote config keep the flags as passed ([#1208](#1208)) ([a31498e](a31498e))
* **remote-config:** save reusable solo flags in remoteconfig ([#1191](#1191)) ([809d0ab](809d0ab))
* Separate concepts for namespace and deployment name ([#1231](#1231)) ([2566c90](2566c90))
* update solo to support pathPrefix of mirror node importer ([#1204](#1204)) ([d9a3592](d9a3592))

### Bug Fixes

* ensure network active check supports multi-cluster deployments ([#1431](#1431)) ([a07801f](a07801f))
* ensure staking updates support multi-cluster deployments  ([#1432](#1432)) ([ef5435e](ef5435e))
* fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme ([#1396](#1396)) ([cc672c2](cc672c2))
* fixed merge issue with incorrect license header ([#1235](#1235)) ([cb91806](cb91806))
* increase number of attempts to wait for active nodes ([#1430](#1430)) ([d113167](d113167))
* mirror node command changes required for multi-cluster support ([#1433](#1433)) ([f43870e](f43870e))
* **multi-cluster:** fix 'solo node setup' command, failing when running multiple clusters ([#1421](#1421)) ([eacdf1f](eacdf1f))
* **network-command:** wrong value passed to addDebugOptions inside the 'network' command ([#1415](#1415)) ([c2e5c3b](c2e5c3b))
* Resolve `cannot read properties of undefined `error thrown during `solo network deploy` ([#1410](#1410)) ([401b937](401b937))
* test script of google storage ([#1397](#1397)) ([370f57b](370f57b))
* update default solo helm chart version ([#1378](#1378)) ([5b5e276](5b5e276))
* update RemoteConfig to handle multi-cluster networking ([#1348](#1348)) ([77b769f](77b769f))
* use better internal IPs for 0.58.5+ ([#1429](#1429)) ([26279ac](26279ac))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create secrets implementation and update k8client methods to use
3 participants