feat: add flags to support aws as storage destination #1372

JeffreyDallas · 2025-02-12T15:27:43Z

Description

This pull request changes the following:

Add new set of flags to support aws storage bucket
network.ts use gcs??? and aws??? as destination bucket parameters
mirror-node.ts use storage??? as download bucket parameters
update test script to se aws set of of parameter to store to GCS storage

Related Issues

Add support to Solo to provide S3, GCS, and Minio combinations #1102

Storage test result

https://github.com/hashgraph/solo/actions/runs/13291631566

Signed-off-by: Jeffrey Tang <[email protected]>

Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/network.ts

Signed-off-by: Jeffrey Tang <[email protected]>

github-actions · 2025-02-12T15:29:33Z

Unit Test Results - Linux

1 files ±0 61 suites ±0 1s ⏱️ -1s
237 tests ±0 237 ✅ ±0 0 💤 ±0 0 ❌ ±0
246 runs ±0 246 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 863379d. ± Comparison against base commit 8411ff3.

github-actions · 2025-02-12T15:31:29Z

Unit Test Results - Windows

1 files ±0 61 suites ±0 3s ⏱️ ±0s
237 tests ±0 237 ✅ ±0 0 💤 ±0 0 ❌ ±0
246 runs ±0 246 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 863379d. ± Comparison against base commit 8411ff3.

github-actions · 2025-02-12T15:57:39Z

E2E Test Report

17 files 126 suites 1h 28m 49s ⏱️
254 tests 254 ✅ 0 💤 0 ❌
265 runs 265 ✅ 0 💤 0 ❌

Results for commit 863379d.

♻️ This comment has been updated with latest results.

codacy-production · 2025-02-12T15:57:56Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.18% (target: -1.00%)	✅ 83.46%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`8411ff3`)	23707	19815	83.58%
Head commit (`863379d`)	23853 (+146)	19981 (+166)	83.77% (+0.18%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1372)	254	212	83.46%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2025-02-12T15:58:56Z

Codecov Report

Attention: Patch coverage is 81.88976% with 46 lines in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (8411ff3) to head (863379d).
Report is 54 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/network.ts	58.94%	39 Missing ⚠️
src/commands/mirror_node.ts	12.50%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1372      +/-   ##
==========================================
+ Coverage   82.51%   82.67%   +0.15%     
==========================================
  Files         130      130              
  Lines       23707    23853     +146     
  Branches     2246     1475     -771     
==========================================
+ Hits        19563    19720     +157     
- Misses       3948     4116     +168     
+ Partials      196       17     -179

Files with missing lines	Coverage Δ
src/commands/flags.ts	`77.05% <100.00%> (+1.43%)`	⬆️
src/core/constants.ts	`97.28% <100.00%> (-0.02%)`	⬇️
src/commands/mirror_node.ts	`69.71% <12.50%> (-0.24%)`	⬇️
src/commands/network.ts	`68.08% <58.94%> (+2.04%)`	⬆️

... and 45 files with indirect coverage changes

## [0.35.0](v0.34.0...v0.35.0) (2025-02-20) ### Features * Add adminKey flag to node setup command ([#1193](#1193)) ([b044fcc](b044fcc)) * add BaseCommand.getConsensusNodes() method ([#1364](#1364)) ([44703a4](44703a4)) * add BaseCommand.getContexts() method ([#1366](#1366)) ([7a5b05b](7a5b05b)) * add basic multi-cluster support to `solo network deploy` ([#1389](#1389)) ([22ed9ae](22ed9ae)) * add clusters fluent interface implementation ([#1291](#1291)) ([95c71f0](95c71f0)) * add concurrent to the task of copying hedera jar files to network node ([#1289](#1289)) ([c50f4c3](c50f4c3)) * add configmaps fluent interface implementation ([#1295](#1295)) ([2c5d6f3](2c5d6f3)) * add contexts fluent interface implementation ([#1297](#1297)) ([938a956](938a956)) * add factory and injection logic ([#1352](#1352)) ([c794610](c794610)) * add flags to support aws as storage destination ([#1372](#1372)) ([5ca0e47](5ca0e47)) * add secrets fluent interface implementation ([#1312](#1312)) ([fb92fd6](fb92fd6)) * add service and services fluent interface implementation ([#1303](#1303)) ([8ef6998](8ef6998)) * add support for --force-port-forward as a top level flag ([#1404](#1404)) ([5c18967](5c18967)) * add support for multi-cluster testing via KinD ([#1392](#1392)) ([ec7eca1](ec7eca1)) * add support for using load balancer address in gossip configuration ([#1405](#1405)) ([0e3f41f](0e3f41f)) * **cli:** add new command `solo deployment list` that lists deployments on that specific cluster ([#1220](#1220)) ([6b0b486](6b0b486)) * **cli:** reduce redundancy on context to cluster flags in command `deployment create` ([#1156](#1156)) ([4ab4dd5](4ab4dd5)) * create the v059x node-override.yaml via solo ([#1192](#1192)) ([283d35c](283d35c)) * **external-database:** add ability to pass readonly user to the external database ([#1350](#1350)) ([d9626ac](d9626ac)) * **local-remote-config:** added solo version to local config and remote config ([#1384](#1384)) ([2dca095](2dca095)) * **mirror-node:** Enhance mirror-node external database feature ([#1230](#1230)) ([bce75d5](bce75d5)) * **multi-cluster:** 'solo relay deploy' to handle cluster-ref value ([#1394](#1394)) ([e73114c](e73114c)) * **multi-cluster:** make remote config validation compatible with multi-cluster K8 implementation ([#1407](#1407)) ([7614a39](7614a39)) * **multi-cluster:** Update `solo node setup` to support multiple clusters ([#1368](#1368)) ([4618a43](4618a43)) * **remote-config:** instead of keeping just the command and the subcommand inside the remote config keep the flags as passed ([#1208](#1208)) ([a31498e](a31498e)) * **remote-config:** save reusable solo flags in remoteconfig ([#1191](#1191)) ([809d0ab](809d0ab)) * Separate concepts for namespace and deployment name ([#1231](#1231)) ([2566c90](2566c90)) * update solo to support pathPrefix of mirror node importer ([#1204](#1204)) ([d9a3592](d9a3592)) ### Bug Fixes * ensure network active check supports multi-cluster deployments ([#1431](#1431)) ([a07801f](a07801f)) * ensure staking updates support multi-cluster deployments ([#1432](#1432)) ([ef5435e](ef5435e)) * fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme ([#1396](#1396)) ([cc672c2](cc672c2)) * fixed merge issue with incorrect license header ([#1235](#1235)) ([cb91806](cb91806)) * increase number of attempts to wait for active nodes ([#1430](#1430)) ([d113167](d113167)) * mirror node command changes required for multi-cluster support ([#1433](#1433)) ([f43870e](f43870e)) * **multi-cluster:** fix 'solo node setup' command, failing when running multiple clusters ([#1421](#1421)) ([eacdf1f](eacdf1f)) * **network-command:** wrong value passed to addDebugOptions inside the 'network' command ([#1415](#1415)) ([c2e5c3b](c2e5c3b)) * Resolve `cannot read properties of undefined `error thrown during `solo network deploy` ([#1410](#1410)) ([401b937](401b937)) * test script of google storage ([#1397](#1397)) ([370f57b](370f57b)) * update default solo helm chart version ([#1378](#1378)) ([5b5e276](5b5e276)) * update RemoteConfig to handle multi-cluster networking ([#1348](#1348)) ([77b769f](77b769f)) * use better internal IPs for 0.58.5+ ([#1429](#1429)) ([26279ac](26279ac))

swirlds-automation · 2025-02-20T01:51:42Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation · 2025-02-24T01:50:55Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

JeffreyDallas added 30 commits February 10, 2025 11:54

add aws storage flags

790efa6

Signed-off-by: Jeffrey Tang <[email protected]>

change script

42be505

Signed-off-by: Jeffrey Tang <[email protected]>

save

88e14df

Signed-off-by: Jeffrey Tang <[email protected]>

save

f1cd3a2

Signed-off-by: Jeffrey Tang <[email protected]>

fix cluster name

f0dd2dc

Signed-off-by: Jeffrey Tang <[email protected]>

save

345b115

Signed-off-by: Jeffrey Tang <[email protected]>

save

d461f51

Signed-off-by: Jeffrey Tang <[email protected]>

save

f871fcf

Signed-off-by: Jeffrey Tang <[email protected]>

save

c582fec

Signed-off-by: Jeffrey Tang <[email protected]>

save

686eec9

Signed-off-by: Jeffrey Tang <[email protected]>

save

7cad052

Signed-off-by: Jeffrey Tang <[email protected]>

save

61819aa

Signed-off-by: Jeffrey Tang <[email protected]>

save

69c5e78

Signed-off-by: Jeffrey Tang <[email protected]>

save

8f88cb1

Signed-off-by: Jeffrey Tang <[email protected]>

save

ec97723

Signed-off-by: Jeffrey Tang <[email protected]>

save

288e4b8

Signed-off-by: Jeffrey Tang <[email protected]>

save

9af7697

Signed-off-by: Jeffrey Tang <[email protected]>

save

842f441

Signed-off-by: Jeffrey Tang <[email protected]>

save

e5d5175

Signed-off-by: Jeffrey Tang <[email protected]>

save

05d8241

Signed-off-by: Jeffrey Tang <[email protected]>

save

3c13b09

Signed-off-by: Jeffrey Tang <[email protected]>

save

5a98015

Signed-off-by: Jeffrey Tang <[email protected]>

save

aeffbb2

Signed-off-by: Jeffrey Tang <[email protected]>

save

1fac1ec

Signed-off-by: Jeffrey Tang <[email protected]>

Merge branch 'main' into 01102-D-s3-bucket

c45370d

Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/network.ts

save

c70609b

Signed-off-by: Jeffrey Tang <[email protected]>

save

b7f2220

Signed-off-by: Jeffrey Tang <[email protected]>

save

be818ff

Signed-off-by: Jeffrey Tang <[email protected]>

save

c076c72

Signed-off-by: Jeffrey Tang <[email protected]>

save

8650f0e

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas added 3 commits February 11, 2025 20:16

save

bd57705

Signed-off-by: Jeffrey Tang <[email protected]>

save

a59d849

Signed-off-by: Jeffrey Tang <[email protected]>

Merge branch 'main' into 01102-D-s3-bucket

863379d

JeffreyDallas requested review from a team and leninmehedy as code owners February 12, 2025 15:27

JeffreyDallas requested a review from rbarker-dev February 12, 2025 15:27

JeffreyDallas requested a review from jeromy-cannon February 12, 2025 17:48

jeromy-cannon approved these changes Feb 12, 2025

View reviewed changes

jeromy-cannon merged commit 5ca0e47 into main Feb 12, 2025
44 of 45 checks passed

jeromy-cannon deleted the 01102-D-s3-bucket branch February 12, 2025 22:02

swirlds-automation added the released label Feb 20, 2025

swirlds-automation added the released on @0.35.x label Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add flags to support aws as storage destination #1372

feat: add flags to support aws as storage destination #1372

Uh oh!

JeffreyDallas commented Feb 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

codacy-production bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

codecov bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

swirlds-automation commented Feb 20, 2025

Uh oh!

swirlds-automation commented Feb 24, 2025

Uh oh!

Uh oh!

feat: add flags to support aws as storage destination #1372

feat: add flags to support aws as storage destination #1372

Uh oh!

Conversation

JeffreyDallas commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Uh oh!

github-actions bot commented Feb 12, 2025

Unit Test Results - Linux

Uh oh!

github-actions bot commented Feb 12, 2025

Unit Test Results - Windows

Uh oh!

github-actions bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Report

Uh oh!

codacy-production bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Uh oh!

codecov bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

swirlds-automation commented Feb 20, 2025

Uh oh!

swirlds-automation commented Feb 24, 2025

Uh oh!

Uh oh!

JeffreyDallas commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

codacy-production bot commented Feb 12, 2025 •

edited

Loading

codecov bot commented Feb 12, 2025 •

edited

Loading