feat: add BaseCommand.getConsensusNodes() method #1364

jeromy-cannon · 2025-02-11T19:14:50Z

Description

This pull request changes the following:

add BaseCommand.getConsensusNodes() method
add a new ConsensusNode class

Related Issues

Relates to Update solo network deploy --deployment to support multiple clusters #1357

Signed-off-by: Jeromy Cannon <[email protected]>

…aseCommand Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

github-actions · 2025-02-11T19:16:50Z

Unit Test Results - Linux

1 files ±0 61 suites +1 1s ⏱️ ±0s
236 tests +1 236 ✅ +1 0 💤 ±0 0 ❌ ±0
245 runs +1 245 ✅ +1 0 💤 ±0 0 ❌ ±0

Results for commit 8a952a8. ± Comparison against base commit ae7d44f.

github-actions · 2025-02-11T19:18:04Z

Unit Test Results - Windows

1 files ±0 61 suites +1 5s ⏱️ -1s
236 tests +1 236 ✅ +1 0 💤 ±0 0 ❌ ±0
245 runs +1 245 ✅ +1 0 💤 ±0 0 ❌ ±0

Results for commit 8a952a8. ± Comparison against base commit ae7d44f.

github-actions · 2025-02-11T20:03:35Z

E2E Test Report

17 files ±0 126 suites ±0 1h 27m 27s ⏱️ -20s
254 tests ±0 254 ✅ ±0 0 💤 ±0 0 ❌ ±0
265 runs ±0 265 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 8a952a8. ± Comparison against base commit ae7d44f.

♻️ This comment has been updated with latest results.

codacy-production · 2025-02-11T20:03:51Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.02% (target: -1.00%)	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`ae7d44f`)	23589	19693	83.48%
Head commit (`8a952a8`)	23628 (+39)	19731 (+38)	83.51% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1364)	52	52	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2025-02-11T20:05:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (ae7d44f) to head (8a952a8).
Report is 58 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
+ Coverage   82.41%   82.43%   +0.02%     
==========================================
  Files         129      130       +1     
  Lines       23589    23628      +39     
  Branches     2348     1556     -792     
==========================================
+ Hits        19440    19477      +37     
- Misses       3903     4073     +170     
+ Partials      246       78     -168

Files with missing lines	Coverage Δ
src/commands/base.ts	`94.52% <100.00%> (+0.57%)`	⬆️
src/core/model/consensus_node.ts	`100.00% <100.00%> (ø)`

... and 49 files with indirect coverage changes

commit 73f43f0 Author: Jeromy Cannon <[email protected]> Date: Wed Feb 12 10:22:08 2025 +0000 refactor and fix test cases Signed-off-by: Jeromy Cannon <[email protected]> commit 29a2d73 Author: Jeffrey Tang <[email protected]> Date: Wed Feb 12 00:22:54 2025 -0600 Fix unit test Signed-off-by: Jeffrey Tang <[email protected]> commit 0f1015f Author: Jeffrey Tang <[email protected]> Date: Tue Feb 11 23:13:24 2025 -0600 save Signed-off-by: Jeffrey Tang <[email protected]> commit 07b43b6 Merge: a666091 369065e Author: Jeffrey Tang <[email protected]> Date: Tue Feb 11 16:47:11 2025 -0600 Merge commit '369065ec21eb01784269b252f9546532da3420dd' into 01363-D-chart-manager-with-context commit 369065e Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 21:02:00 2025 +0000 ci: set unique e2e job names to prevent failure and set e2e parallel jobs to 5 (#1367) Signed-off-by: Jeromy Cannon <[email protected]> commit 7a5b05b Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 21:00:45 2025 +0000 feat: add BaseCommand.getContexts() method (#1366) Signed-off-by: Jeromy Cannon <[email protected]> commit a666091 Author: Jeffrey Tang <[email protected]> Date: Tue Feb 11 14:24:47 2025 -0600 save Signed-off-by: Jeffrey Tang <[email protected]> commit 0e7e014 Author: Jeffrey Tang <[email protected]> Date: Tue Feb 11 14:08:30 2025 -0600 add kubeContext parameter Signed-off-by: Jeffrey Tang <[email protected]> commit 44703a4 Author: Jeromy Cannon <[email protected]> Date: Tue Feb 11 20:06:38 2025 +0000 feat: add BaseCommand.getConsensusNodes() method (#1364) Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

## [0.35.0](v0.34.0...v0.35.0) (2025-02-20) ### Features * Add adminKey flag to node setup command ([#1193](#1193)) ([b044fcc](b044fcc)) * add BaseCommand.getConsensusNodes() method ([#1364](#1364)) ([44703a4](44703a4)) * add BaseCommand.getContexts() method ([#1366](#1366)) ([7a5b05b](7a5b05b)) * add basic multi-cluster support to `solo network deploy` ([#1389](#1389)) ([22ed9ae](22ed9ae)) * add clusters fluent interface implementation ([#1291](#1291)) ([95c71f0](95c71f0)) * add concurrent to the task of copying hedera jar files to network node ([#1289](#1289)) ([c50f4c3](c50f4c3)) * add configmaps fluent interface implementation ([#1295](#1295)) ([2c5d6f3](2c5d6f3)) * add contexts fluent interface implementation ([#1297](#1297)) ([938a956](938a956)) * add factory and injection logic ([#1352](#1352)) ([c794610](c794610)) * add flags to support aws as storage destination ([#1372](#1372)) ([5ca0e47](5ca0e47)) * add secrets fluent interface implementation ([#1312](#1312)) ([fb92fd6](fb92fd6)) * add service and services fluent interface implementation ([#1303](#1303)) ([8ef6998](8ef6998)) * add support for --force-port-forward as a top level flag ([#1404](#1404)) ([5c18967](5c18967)) * add support for multi-cluster testing via KinD ([#1392](#1392)) ([ec7eca1](ec7eca1)) * add support for using load balancer address in gossip configuration ([#1405](#1405)) ([0e3f41f](0e3f41f)) * **cli:** add new command `solo deployment list` that lists deployments on that specific cluster ([#1220](#1220)) ([6b0b486](6b0b486)) * **cli:** reduce redundancy on context to cluster flags in command `deployment create` ([#1156](#1156)) ([4ab4dd5](4ab4dd5)) * create the v059x node-override.yaml via solo ([#1192](#1192)) ([283d35c](283d35c)) * **external-database:** add ability to pass readonly user to the external database ([#1350](#1350)) ([d9626ac](d9626ac)) * **local-remote-config:** added solo version to local config and remote config ([#1384](#1384)) ([2dca095](2dca095)) * **mirror-node:** Enhance mirror-node external database feature ([#1230](#1230)) ([bce75d5](bce75d5)) * **multi-cluster:** 'solo relay deploy' to handle cluster-ref value ([#1394](#1394)) ([e73114c](e73114c)) * **multi-cluster:** make remote config validation compatible with multi-cluster K8 implementation ([#1407](#1407)) ([7614a39](7614a39)) * **multi-cluster:** Update `solo node setup` to support multiple clusters ([#1368](#1368)) ([4618a43](4618a43)) * **remote-config:** instead of keeping just the command and the subcommand inside the remote config keep the flags as passed ([#1208](#1208)) ([a31498e](a31498e)) * **remote-config:** save reusable solo flags in remoteconfig ([#1191](#1191)) ([809d0ab](809d0ab)) * Separate concepts for namespace and deployment name ([#1231](#1231)) ([2566c90](2566c90)) * update solo to support pathPrefix of mirror node importer ([#1204](#1204)) ([d9a3592](d9a3592)) ### Bug Fixes * ensure network active check supports multi-cluster deployments ([#1431](#1431)) ([a07801f](a07801f)) * ensure staking updates support multi-cluster deployments ([#1432](#1432)) ([ef5435e](ef5435e)) * fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme ([#1396](#1396)) ([cc672c2](cc672c2)) * fixed merge issue with incorrect license header ([#1235](#1235)) ([cb91806](cb91806)) * increase number of attempts to wait for active nodes ([#1430](#1430)) ([d113167](d113167)) * mirror node command changes required for multi-cluster support ([#1433](#1433)) ([f43870e](f43870e)) * **multi-cluster:** fix 'solo node setup' command, failing when running multiple clusters ([#1421](#1421)) ([eacdf1f](eacdf1f)) * **network-command:** wrong value passed to addDebugOptions inside the 'network' command ([#1415](#1415)) ([c2e5c3b](c2e5c3b)) * Resolve `cannot read properties of undefined `error thrown during `solo network deploy` ([#1410](#1410)) ([401b937](401b937)) * test script of google storage ([#1397](#1397)) ([370f57b](370f57b)) * update default solo helm chart version ([#1378](#1378)) ([5b5e276](5b5e276)) * update RemoteConfig to handle multi-cluster networking ([#1348](#1348)) ([77b769f](77b769f)) * use better internal IPs for 0.58.5+ ([#1429](#1429)) ([26279ac](26279ac))

swirlds-automation · 2025-02-20T01:52:24Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation · 2025-02-24T01:51:22Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon added 5 commits February 11, 2025 17:34

package-lock.json

b76fc7d

Signed-off-by: Jeromy Cannon <[email protected]>

add the ConsensusNode class and added a getConsensusNodes method to B…

2555528

…aseCommand Signed-off-by: Jeromy Cannon <[email protected]>

add the ConsensusNode class and added a getConsensusNodes method to B…

cce944b

…aseCommand Signed-off-by: Jeromy Cannon <[email protected]>

updated getConsensusNodes

529c28f

Signed-off-by: Jeromy Cannon <[email protected]>

added base test for getConsensusNodes

8a952a8

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon self-assigned this Feb 11, 2025

jeromy-cannon marked this pull request as ready for review February 11, 2025 19:15

jeromy-cannon requested review from a team and leninmehedy as code owners February 11, 2025 19:15

jeromy-cannon requested review from Ivo-Yankov, JeffreyDallas and instamenta February 11, 2025 19:16

instamenta approved these changes Feb 11, 2025

View reviewed changes

leninmehedy approved these changes Feb 11, 2025

View reviewed changes

jeromy-cannon merged commit 44703a4 into main Feb 11, 2025
42 checks passed

jeromy-cannon deleted the 01357-multi-cluster-network-deploy-part-1 branch February 11, 2025 20:06

swirlds-automation added the released label Feb 20, 2025

swirlds-automation added the released on @0.35.x label Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add BaseCommand.getConsensusNodes() method #1364

feat: add BaseCommand.getConsensusNodes() method #1364

Uh oh!

jeromy-cannon commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 11, 2025 •

edited

Loading

Uh oh!

codacy-production bot commented Feb 11, 2025

Uh oh!

codecov bot commented Feb 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

swirlds-automation commented Feb 20, 2025

Uh oh!

swirlds-automation commented Feb 24, 2025

Uh oh!

Uh oh!

feat: add BaseCommand.getConsensusNodes() method #1364

feat: add BaseCommand.getConsensusNodes() method #1364

Uh oh!

Conversation

jeromy-cannon commented Feb 11, 2025

Description

Related Issues

Uh oh!

github-actions bot commented Feb 11, 2025

Unit Test Results - Linux

Uh oh!

github-actions bot commented Feb 11, 2025

Unit Test Results - Windows

Uh oh!

github-actions bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Report

Uh oh!

codacy-production bot commented Feb 11, 2025

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Uh oh!

codecov bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

swirlds-automation commented Feb 20, 2025

Uh oh!

swirlds-automation commented Feb 24, 2025

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2025 •

edited

Loading

codecov bot commented Feb 11, 2025 •

edited

Loading